Compare commits
17 Commits
feature/is
...
feature/is
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
702653e52e | ||
|
|
854931bed2 | ||
| 33b5ff5e54 | |||
| 3923d03650 | |||
|
|
c57ccc4bca | ||
|
|
cb2e3fae57 | ||
| 5e4c68c9d8 | |||
|
|
95f540e5df | ||
| 0087a6b20a | |||
|
|
3dfd7c0935 | ||
| 4b2bb25d03 | |||
|
|
881bbb4240 | ||
| 5f7d61748b | |||
|
|
972e71a2f1 | ||
| 614b9939b1 | |||
|
|
6dbc2afbf4 | ||
| 6c96f9ac64 |
12
.env.example
12
.env.example
@@ -16,8 +16,9 @@ CONFIDENCE_THRESHOLD=80
|
|||||||
# Database
|
# Database
|
||||||
DB_PATH=data/trade_logs.db
|
DB_PATH=data/trade_logs.db
|
||||||
|
|
||||||
# Rate Limiting
|
# Rate Limiting (requests per second for KIS API)
|
||||||
RATE_LIMIT_RPS=10.0
|
# Reduced to 5.0 to avoid "초당 거래건수 초과" errors (EGW00201)
|
||||||
|
RATE_LIMIT_RPS=5.0
|
||||||
|
|
||||||
# Trading Mode (paper / live)
|
# Trading Mode (paper / live)
|
||||||
MODE=paper
|
MODE=paper
|
||||||
@@ -26,3 +27,10 @@ MODE=paper
|
|||||||
# NEWS_API_KEY=your_news_api_key_here
|
# NEWS_API_KEY=your_news_api_key_here
|
||||||
# NEWS_API_PROVIDER=alphavantage
|
# NEWS_API_PROVIDER=alphavantage
|
||||||
# MARKET_DATA_API_KEY=your_market_data_key_here
|
# MARKET_DATA_API_KEY=your_market_data_key_here
|
||||||
|
|
||||||
|
# Telegram Notifications (optional)
|
||||||
|
# Get bot token from @BotFather on Telegram
|
||||||
|
# Get chat ID from @userinfobot or your chat
|
||||||
|
# TELEGRAM_BOT_TOKEN=1234567890:ABCdefGHIjklMNOpqrsTUVwxyz
|
||||||
|
# TELEGRAM_CHAT_ID=123456789
|
||||||
|
# TELEGRAM_ENABLED=true
|
||||||
|
|||||||
31
CLAUDE.md
31
CLAUDE.md
@@ -17,6 +17,34 @@ pytest -v --cov=src
|
|||||||
python -m src.main --mode=paper
|
python -m src.main --mode=paper
|
||||||
```
|
```
|
||||||
|
|
||||||
|
## Telegram Notifications (Optional)
|
||||||
|
|
||||||
|
Get real-time alerts for trades, circuit breakers, and system events via Telegram.
|
||||||
|
|
||||||
|
### Quick Setup
|
||||||
|
|
||||||
|
1. **Create bot**: Message [@BotFather](https://t.me/BotFather) on Telegram → `/newbot`
|
||||||
|
2. **Get chat ID**: Message [@userinfobot](https://t.me/userinfobot) → `/start`
|
||||||
|
3. **Configure**: Add to `.env`:
|
||||||
|
```bash
|
||||||
|
TELEGRAM_BOT_TOKEN=1234567890:ABCdefGHIjklMNOpqrsTUVwxyz
|
||||||
|
TELEGRAM_CHAT_ID=123456789
|
||||||
|
TELEGRAM_ENABLED=true
|
||||||
|
```
|
||||||
|
4. **Test**: Start bot conversation (`/start`), then run the agent
|
||||||
|
|
||||||
|
**Full documentation**: [src/notifications/README.md](src/notifications/README.md)
|
||||||
|
|
||||||
|
### What You'll Get
|
||||||
|
|
||||||
|
- 🟢 Trade execution alerts (BUY/SELL with confidence)
|
||||||
|
- 🚨 Circuit breaker trips (automatic trading halt)
|
||||||
|
- ⚠️ Fat-finger rejections (oversized orders blocked)
|
||||||
|
- ℹ️ Market open/close notifications
|
||||||
|
- 📝 System startup/shutdown status
|
||||||
|
|
||||||
|
**Fail-safe**: Notifications never crash the trading system. Missing credentials or API errors are logged but trading continues normally.
|
||||||
|
|
||||||
## Documentation
|
## Documentation
|
||||||
|
|
||||||
- **[Workflow Guide](docs/workflow.md)** — Git workflow policy and agent-based development
|
- **[Workflow Guide](docs/workflow.md)** — Git workflow policy and agent-based development
|
||||||
@@ -42,11 +70,12 @@ src/
|
|||||||
├── core/ # Risk manager (READ-ONLY)
|
├── core/ # Risk manager (READ-ONLY)
|
||||||
├── evolution/ # Self-improvement optimizer
|
├── evolution/ # Self-improvement optimizer
|
||||||
├── markets/ # Market schedules and timezone handling
|
├── markets/ # Market schedules and timezone handling
|
||||||
|
├── notifications/ # Telegram real-time alerts
|
||||||
├── db.py # SQLite trade logging
|
├── db.py # SQLite trade logging
|
||||||
├── main.py # Trading loop orchestrator
|
├── main.py # Trading loop orchestrator
|
||||||
└── config.py # Settings (from .env)
|
└── config.py # Settings (from .env)
|
||||||
|
|
||||||
tests/ # 54 tests across 4 files
|
tests/ # 273 tests across 13 files
|
||||||
docs/ # Extended documentation
|
docs/ # Extended documentation
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|||||||
48
README.md
48
README.md
@@ -29,6 +29,7 @@ KIS(한국투자증권) API로 매매하고, Google Gemini로 판단하며, 자
|
|||||||
| 브로커 | `src/broker/kis_api.py` | KIS API 비동기 래퍼 (토큰 갱신, 레이트 리미터, 해시키) |
|
| 브로커 | `src/broker/kis_api.py` | KIS API 비동기 래퍼 (토큰 갱신, 레이트 리미터, 해시키) |
|
||||||
| 두뇌 | `src/brain/gemini_client.py` | Gemini 프롬프트 구성 및 JSON 응답 파싱 |
|
| 두뇌 | `src/brain/gemini_client.py` | Gemini 프롬프트 구성 및 JSON 응답 파싱 |
|
||||||
| 방패 | `src/core/risk_manager.py` | 서킷 브레이커 + 팻 핑거 체크 |
|
| 방패 | `src/core/risk_manager.py` | 서킷 브레이커 + 팻 핑거 체크 |
|
||||||
|
| 알림 | `src/notifications/telegram_client.py` | 텔레그램 실시간 거래 알림 (선택사항) |
|
||||||
| 진화 | `src/evolution/optimizer.py` | 실패 패턴 분석 → 새 전략 생성 → 테스트 → PR |
|
| 진화 | `src/evolution/optimizer.py` | 실패 패턴 분석 → 새 전략 생성 → 테스트 → PR |
|
||||||
| DB | `src/db.py` | SQLite 거래 로그 기록 |
|
| DB | `src/db.py` | SQLite 거래 로그 기록 |
|
||||||
|
|
||||||
@@ -75,6 +76,34 @@ python -m src.main --mode=paper
|
|||||||
docker compose up -d ouroboros
|
docker compose up -d ouroboros
|
||||||
```
|
```
|
||||||
|
|
||||||
|
## 텔레그램 알림 (선택사항)
|
||||||
|
|
||||||
|
거래 실행, 서킷 브레이커 발동, 시스템 상태 등을 텔레그램으로 실시간 알림 받을 수 있습니다.
|
||||||
|
|
||||||
|
### 빠른 설정
|
||||||
|
|
||||||
|
1. **봇 생성**: 텔레그램에서 [@BotFather](https://t.me/BotFather) 메시지 → `/newbot` 명령
|
||||||
|
2. **채팅 ID 확인**: [@userinfobot](https://t.me/userinfobot) 메시지 → `/start` 명령
|
||||||
|
3. **환경변수 설정**: `.env` 파일에 추가
|
||||||
|
```bash
|
||||||
|
TELEGRAM_BOT_TOKEN=1234567890:ABCdefGHIjklMNOpqrsTUVwxyz
|
||||||
|
TELEGRAM_CHAT_ID=123456789
|
||||||
|
TELEGRAM_ENABLED=true
|
||||||
|
```
|
||||||
|
4. **테스트**: 봇과 대화 시작 (`/start` 전송) 후 에이전트 실행
|
||||||
|
|
||||||
|
**상세 문서**: [src/notifications/README.md](src/notifications/README.md)
|
||||||
|
|
||||||
|
### 알림 종류
|
||||||
|
|
||||||
|
- 🟢 거래 체결 알림 (BUY/SELL + 신뢰도)
|
||||||
|
- 🚨 서킷 브레이커 발동 (자동 거래 중단)
|
||||||
|
- ⚠️ 팻 핑거 차단 (과도한 주문 차단)
|
||||||
|
- ℹ️ 장 시작/종료 알림
|
||||||
|
- 📝 시스템 시작/종료 상태
|
||||||
|
|
||||||
|
**안전장치**: 알림 실패해도 거래는 계속 진행됩니다. 텔레그램 API 오류나 설정 누락이 있어도 거래 시스템은 정상 작동합니다.
|
||||||
|
|
||||||
## 테스트
|
## 테스트
|
||||||
|
|
||||||
35개 테스트가 TDD 방식으로 구현 전에 먼저 작성되었습니다.
|
35개 테스트가 TDD 방식으로 구현 전에 먼저 작성되었습니다.
|
||||||
@@ -104,15 +133,16 @@ The-Ouroboros/
|
|||||||
│ ├── agents.md # AI 에이전트 페르소나 정의
|
│ ├── agents.md # AI 에이전트 페르소나 정의
|
||||||
│ └── skills.md # 사용 가능한 도구 목록
|
│ └── skills.md # 사용 가능한 도구 목록
|
||||||
├── src/
|
├── src/
|
||||||
│ ├── config.py # Pydantic 설정
|
│ ├── config.py # Pydantic 설정
|
||||||
│ ├── logging_config.py # JSON 구조화 로깅
|
│ ├── logging_config.py # JSON 구조화 로깅
|
||||||
│ ├── db.py # SQLite 거래 기록
|
│ ├── db.py # SQLite 거래 기록
|
||||||
│ ├── main.py # 비동기 거래 루프
|
│ ├── main.py # 비동기 거래 루프
|
||||||
│ ├── broker/kis_api.py # KIS API 클라이언트
|
│ ├── broker/kis_api.py # KIS API 클라이언트
|
||||||
│ ├── brain/gemini_client.py # Gemini 의사결정 엔진
|
│ ├── brain/gemini_client.py # Gemini 의사결정 엔진
|
||||||
│ ├── core/risk_manager.py # 리스크 관리
|
│ ├── core/risk_manager.py # 리스크 관리
|
||||||
│ ├── evolution/optimizer.py # 전략 진화 엔진
|
│ ├── notifications/telegram_client.py # 텔레그램 알림
|
||||||
│ └── strategies/base.py # 전략 베이스 클래스
|
│ ├── evolution/optimizer.py # 전략 진화 엔진
|
||||||
|
│ └── strategies/base.py # 전략 베이스 클래스
|
||||||
├── tests/ # TDD 테스트 스위트
|
├── tests/ # TDD 테스트 스위트
|
||||||
├── Dockerfile # 멀티스테이지 빌드
|
├── Dockerfile # 멀티스테이지 빌드
|
||||||
├── docker-compose.yml # 서비스 오케스트레이션
|
├── docker-compose.yml # 서비스 오케스트레이션
|
||||||
|
|||||||
@@ -51,7 +51,26 @@ Self-evolving AI trading agent for global stock markets via KIS (Korea Investmen
|
|||||||
- **Fat-Finger Protection**: Rejects orders exceeding 30% of available cash
|
- **Fat-Finger Protection**: Rejects orders exceeding 30% of available cash
|
||||||
- Must always be enforced, cannot be disabled
|
- Must always be enforced, cannot be disabled
|
||||||
|
|
||||||
### 4. Evolution (`src/evolution/optimizer.py`)
|
### 4. Notifications (`src/notifications/telegram_client.py`)
|
||||||
|
|
||||||
|
**TelegramClient** — Real-time event notifications via Telegram Bot API
|
||||||
|
|
||||||
|
- Sends alerts for trades, circuit breakers, fat-finger rejections, system events
|
||||||
|
- Non-blocking: failures are logged but never crash trading
|
||||||
|
- Rate-limited: 1 message/second default to respect Telegram API limits
|
||||||
|
- Auto-disabled when credentials missing
|
||||||
|
- Gracefully handles API errors, network timeouts, invalid tokens
|
||||||
|
|
||||||
|
**Notification Types:**
|
||||||
|
- Trade execution (BUY/SELL with confidence)
|
||||||
|
- Circuit breaker trips (critical alert)
|
||||||
|
- Fat-finger protection triggers (order rejection)
|
||||||
|
- Market open/close events
|
||||||
|
- System startup/shutdown status
|
||||||
|
|
||||||
|
**Setup:** See [src/notifications/README.md](../src/notifications/README.md) for bot creation and configuration.
|
||||||
|
|
||||||
|
### 5. Evolution (`src/evolution/optimizer.py`)
|
||||||
|
|
||||||
**StrategyOptimizer** — Self-improvement loop
|
**StrategyOptimizer** — Self-improvement loop
|
||||||
|
|
||||||
@@ -115,6 +134,14 @@ Self-evolving AI trading agent for global stock markets via KIS (Korea Investmen
|
|||||||
│
|
│
|
||||||
▼
|
▼
|
||||||
┌──────────────────────────────────┐
|
┌──────────────────────────────────┐
|
||||||
|
│ Notifications: Send Alert │
|
||||||
|
│ - Trade execution notification │
|
||||||
|
│ - Non-blocking (errors logged) │
|
||||||
|
│ - Rate-limited to 1/sec │
|
||||||
|
└──────────────────┬────────────────┘
|
||||||
|
│
|
||||||
|
▼
|
||||||
|
┌──────────────────────────────────┐
|
||||||
│ Database: Log Trade │
|
│ Database: Log Trade │
|
||||||
│ - SQLite (data/trades.db) │
|
│ - SQLite (data/trades.db) │
|
||||||
│ - Track: action, confidence, │
|
│ - Track: action, confidence, │
|
||||||
@@ -164,6 +191,11 @@ CONFIDENCE_THRESHOLD=80
|
|||||||
MAX_LOSS_PCT=3.0
|
MAX_LOSS_PCT=3.0
|
||||||
MAX_ORDER_PCT=30.0
|
MAX_ORDER_PCT=30.0
|
||||||
ENABLED_MARKETS=KR,US_NASDAQ # Comma-separated market codes
|
ENABLED_MARKETS=KR,US_NASDAQ # Comma-separated market codes
|
||||||
|
|
||||||
|
# Telegram Notifications (optional)
|
||||||
|
TELEGRAM_BOT_TOKEN=1234567890:ABCdefGHIjklMNOpqrsTUVwxyz
|
||||||
|
TELEGRAM_CHAT_ID=123456789
|
||||||
|
TELEGRAM_ENABLED=true
|
||||||
```
|
```
|
||||||
|
|
||||||
Tests use in-memory SQLite (`DB_PATH=":memory:"`) and dummy credentials via `tests/conftest.py`.
|
Tests use in-memory SQLite (`DB_PATH=":memory:"`) and dummy credentials via `tests/conftest.py`.
|
||||||
@@ -189,3 +221,12 @@ Tests use in-memory SQLite (`DB_PATH=":memory:"`) and dummy credentials via `tes
|
|||||||
- Wait until next market opens
|
- Wait until next market opens
|
||||||
- Use `get_next_market_open()` to calculate wait time
|
- Use `get_next_market_open()` to calculate wait time
|
||||||
- Sleep until market open time
|
- Sleep until market open time
|
||||||
|
|
||||||
|
### Telegram API Errors
|
||||||
|
- Log warning but continue trading
|
||||||
|
- Missing credentials → auto-disable notifications
|
||||||
|
- Network timeout → skip notification, no retry
|
||||||
|
- Invalid token → log error, trading unaffected
|
||||||
|
- Rate limit exceeded → queued via rate limiter
|
||||||
|
|
||||||
|
**Guarantee**: Notification failures never interrupt trading operations.
|
||||||
|
|||||||
@@ -83,8 +83,8 @@ class MarketScanner:
|
|||||||
# Convert to orderbook-like structure
|
# Convert to orderbook-like structure
|
||||||
orderbook = {
|
orderbook = {
|
||||||
"output1": {
|
"output1": {
|
||||||
"stck_prpr": price_data.get("output", {}).get("last", "0"),
|
"stck_prpr": price_data.get("output", {}).get("last", "0") or "0",
|
||||||
"acml_vol": price_data.get("output", {}).get("tvol", "0"),
|
"acml_vol": price_data.get("output", {}).get("tvol", "0") or "0",
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -55,6 +55,7 @@ class KISBroker:
|
|||||||
self._session: aiohttp.ClientSession | None = None
|
self._session: aiohttp.ClientSession | None = None
|
||||||
self._access_token: str | None = None
|
self._access_token: str | None = None
|
||||||
self._token_expires_at: float = 0.0
|
self._token_expires_at: float = 0.0
|
||||||
|
self._token_lock = asyncio.Lock()
|
||||||
self._rate_limiter = LeakyBucket(settings.RATE_LIMIT_RPS)
|
self._rate_limiter = LeakyBucket(settings.RATE_LIMIT_RPS)
|
||||||
|
|
||||||
def _get_session(self) -> aiohttp.ClientSession:
|
def _get_session(self) -> aiohttp.ClientSession:
|
||||||
@@ -80,30 +81,42 @@ class KISBroker:
|
|||||||
# ------------------------------------------------------------------
|
# ------------------------------------------------------------------
|
||||||
|
|
||||||
async def _ensure_token(self) -> str:
|
async def _ensure_token(self) -> str:
|
||||||
"""Return a valid access token, refreshing if expired."""
|
"""Return a valid access token, refreshing if expired.
|
||||||
|
|
||||||
|
Uses a lock to prevent concurrent token refresh attempts that would
|
||||||
|
hit the API's 1-per-minute rate limit (EGW00133).
|
||||||
|
"""
|
||||||
|
# Fast path: check without lock
|
||||||
now = asyncio.get_event_loop().time()
|
now = asyncio.get_event_loop().time()
|
||||||
if self._access_token and now < self._token_expires_at:
|
if self._access_token and now < self._token_expires_at:
|
||||||
return self._access_token
|
return self._access_token
|
||||||
|
|
||||||
logger.info("Refreshing KIS access token")
|
# Slow path: acquire lock and refresh
|
||||||
session = self._get_session()
|
async with self._token_lock:
|
||||||
url = f"{self._base_url}/oauth2/tokenP"
|
# Re-check after acquiring lock (another coroutine may have refreshed)
|
||||||
body = {
|
now = asyncio.get_event_loop().time()
|
||||||
"grant_type": "client_credentials",
|
if self._access_token and now < self._token_expires_at:
|
||||||
"appkey": self._app_key,
|
return self._access_token
|
||||||
"appsecret": self._app_secret,
|
|
||||||
}
|
|
||||||
|
|
||||||
async with session.post(url, json=body) as resp:
|
logger.info("Refreshing KIS access token")
|
||||||
if resp.status != 200:
|
session = self._get_session()
|
||||||
text = await resp.text()
|
url = f"{self._base_url}/oauth2/tokenP"
|
||||||
raise ConnectionError(f"Token refresh failed ({resp.status}): {text}")
|
body = {
|
||||||
data = await resp.json()
|
"grant_type": "client_credentials",
|
||||||
|
"appkey": self._app_key,
|
||||||
|
"appsecret": self._app_secret,
|
||||||
|
}
|
||||||
|
|
||||||
self._access_token = data["access_token"]
|
async with session.post(url, json=body) as resp:
|
||||||
self._token_expires_at = now + data.get("expires_in", 86400) - 60 # 1-min buffer
|
if resp.status != 200:
|
||||||
logger.info("Token refreshed successfully")
|
text = await resp.text()
|
||||||
return self._access_token
|
raise ConnectionError(f"Token refresh failed ({resp.status}): {text}")
|
||||||
|
data = await resp.json()
|
||||||
|
|
||||||
|
self._access_token = data["access_token"]
|
||||||
|
self._token_expires_at = now + data.get("expires_in", 86400) - 60 # 1-min buffer
|
||||||
|
logger.info("Token refreshed successfully")
|
||||||
|
return self._access_token
|
||||||
|
|
||||||
# ------------------------------------------------------------------
|
# ------------------------------------------------------------------
|
||||||
# Hash Key (required for POST bodies)
|
# Hash Key (required for POST bodies)
|
||||||
|
|||||||
@@ -37,7 +37,8 @@ class Settings(BaseSettings):
|
|||||||
DB_PATH: str = "data/trade_logs.db"
|
DB_PATH: str = "data/trade_logs.db"
|
||||||
|
|
||||||
# Rate Limiting (requests per second for KIS API)
|
# Rate Limiting (requests per second for KIS API)
|
||||||
RATE_LIMIT_RPS: float = 10.0
|
# Reduced to 5.0 to avoid EGW00201 "초당 거래건수 초과" errors
|
||||||
|
RATE_LIMIT_RPS: float = 5.0
|
||||||
|
|
||||||
# Trading mode
|
# Trading mode
|
||||||
MODE: str = Field(default="paper", pattern="^(paper|live)$")
|
MODE: str = Field(default="paper", pattern="^(paper|live)$")
|
||||||
@@ -54,6 +55,11 @@ class Settings(BaseSettings):
|
|||||||
S3_BUCKET_NAME: str | None = None
|
S3_BUCKET_NAME: str | None = None
|
||||||
S3_REGION: str = "us-east-1"
|
S3_REGION: str = "us-east-1"
|
||||||
|
|
||||||
|
# Telegram Notifications (optional)
|
||||||
|
TELEGRAM_BOT_TOKEN: str | None = None
|
||||||
|
TELEGRAM_CHAT_ID: str | None = None
|
||||||
|
TELEGRAM_ENABLED: bool = True
|
||||||
|
|
||||||
model_config = {"env_file": ".env", "env_file_encoding": "utf-8"}
|
model_config = {"env_file": ".env", "env_file_encoding": "utf-8"}
|
||||||
|
|
||||||
@property
|
@property
|
||||||
|
|||||||
144
src/main.py
144
src/main.py
@@ -10,6 +10,7 @@ import argparse
|
|||||||
import asyncio
|
import asyncio
|
||||||
import logging
|
import logging
|
||||||
import signal
|
import signal
|
||||||
|
import sys
|
||||||
from datetime import UTC, datetime
|
from datetime import UTC, datetime
|
||||||
from typing import Any
|
from typing import Any
|
||||||
|
|
||||||
@@ -23,14 +24,44 @@ from src.context.layer import ContextLayer
|
|||||||
from src.context.store import ContextStore
|
from src.context.store import ContextStore
|
||||||
from src.core.criticality import CriticalityAssessor
|
from src.core.criticality import CriticalityAssessor
|
||||||
from src.core.priority_queue import PriorityTaskQueue
|
from src.core.priority_queue import PriorityTaskQueue
|
||||||
from src.core.risk_manager import CircuitBreakerTripped, RiskManager
|
from src.core.risk_manager import CircuitBreakerTripped, FatFingerRejected, RiskManager
|
||||||
from src.db import init_db, log_trade
|
from src.db import init_db, log_trade
|
||||||
from src.logging.decision_logger import DecisionLogger
|
from src.logging.decision_logger import DecisionLogger
|
||||||
from src.logging_config import setup_logging
|
from src.logging_config import setup_logging
|
||||||
from src.markets.schedule import MarketInfo, get_next_market_open, get_open_markets
|
from src.markets.schedule import MarketInfo, get_next_market_open, get_open_markets
|
||||||
|
from src.notifications.telegram_client import TelegramClient
|
||||||
|
|
||||||
logger = logging.getLogger(__name__)
|
logger = logging.getLogger(__name__)
|
||||||
|
|
||||||
|
|
||||||
|
def safe_float(value: str | float | None, default: float = 0.0) -> float:
|
||||||
|
"""Convert to float, handling empty strings and None.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
value: Value to convert (string, float, or None)
|
||||||
|
default: Default value if conversion fails
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
Converted float or default value
|
||||||
|
|
||||||
|
Examples:
|
||||||
|
>>> safe_float("123.45")
|
||||||
|
123.45
|
||||||
|
>>> safe_float("")
|
||||||
|
0.0
|
||||||
|
>>> safe_float(None)
|
||||||
|
0.0
|
||||||
|
>>> safe_float("invalid", 99.0)
|
||||||
|
99.0
|
||||||
|
"""
|
||||||
|
if value is None or value == "":
|
||||||
|
return default
|
||||||
|
try:
|
||||||
|
return float(value)
|
||||||
|
except (ValueError, TypeError):
|
||||||
|
return default
|
||||||
|
|
||||||
|
|
||||||
# Target stock codes to monitor per market
|
# Target stock codes to monitor per market
|
||||||
WATCHLISTS = {
|
WATCHLISTS = {
|
||||||
"KR": ["005930", "000660", "035420"], # Samsung, SK Hynix, NAVER
|
"KR": ["005930", "000660", "035420"], # Samsung, SK Hynix, NAVER
|
||||||
@@ -62,6 +93,7 @@ async def trading_cycle(
|
|||||||
decision_logger: DecisionLogger,
|
decision_logger: DecisionLogger,
|
||||||
context_store: ContextStore,
|
context_store: ContextStore,
|
||||||
criticality_assessor: CriticalityAssessor,
|
criticality_assessor: CriticalityAssessor,
|
||||||
|
telegram: TelegramClient,
|
||||||
market: MarketInfo,
|
market: MarketInfo,
|
||||||
stock_code: str,
|
stock_code: str,
|
||||||
) -> None:
|
) -> None:
|
||||||
@@ -74,16 +106,16 @@ async def trading_cycle(
|
|||||||
balance_data = await broker.get_balance()
|
balance_data = await broker.get_balance()
|
||||||
|
|
||||||
output2 = balance_data.get("output2", [{}])
|
output2 = balance_data.get("output2", [{}])
|
||||||
total_eval = float(output2[0].get("tot_evlu_amt", "0")) if output2 else 0
|
total_eval = safe_float(output2[0].get("tot_evlu_amt", "0")) if output2 else 0
|
||||||
total_cash = float(
|
total_cash = safe_float(
|
||||||
balance_data.get("output2", [{}])[0].get("dnca_tot_amt", "0")
|
balance_data.get("output2", [{}])[0].get("dnca_tot_amt", "0")
|
||||||
if output2
|
if output2
|
||||||
else "0"
|
else "0"
|
||||||
)
|
)
|
||||||
purchase_total = float(output2[0].get("pchs_amt_smtl_amt", "0")) if output2 else 0
|
purchase_total = safe_float(output2[0].get("pchs_amt_smtl_amt", "0")) if output2 else 0
|
||||||
|
|
||||||
current_price = float(orderbook.get("output1", {}).get("stck_prpr", "0"))
|
current_price = safe_float(orderbook.get("output1", {}).get("stck_prpr", "0"))
|
||||||
foreigner_net = float(orderbook.get("output1", {}).get("frgn_ntby_qty", "0"))
|
foreigner_net = safe_float(orderbook.get("output1", {}).get("frgn_ntby_qty", "0"))
|
||||||
else:
|
else:
|
||||||
# Overseas market
|
# Overseas market
|
||||||
price_data = await overseas_broker.get_overseas_price(
|
price_data = await overseas_broker.get_overseas_price(
|
||||||
@@ -92,11 +124,19 @@ async def trading_cycle(
|
|||||||
balance_data = await overseas_broker.get_overseas_balance(market.exchange_code)
|
balance_data = await overseas_broker.get_overseas_balance(market.exchange_code)
|
||||||
|
|
||||||
output2 = balance_data.get("output2", [{}])
|
output2 = balance_data.get("output2", [{}])
|
||||||
total_eval = float(output2[0].get("frcr_evlu_tota", "0")) if output2 else 0
|
# Handle both list and dict response formats
|
||||||
total_cash = float(output2[0].get("frcr_dncl_amt_2", "0")) if output2 else 0
|
if isinstance(output2, list) and output2:
|
||||||
purchase_total = float(output2[0].get("frcr_buy_amt_smtl", "0")) if output2 else 0
|
balance_info = output2[0]
|
||||||
|
elif isinstance(output2, dict):
|
||||||
|
balance_info = output2
|
||||||
|
else:
|
||||||
|
balance_info = {}
|
||||||
|
|
||||||
current_price = float(price_data.get("output", {}).get("last", "0"))
|
total_eval = safe_float(balance_info.get("frcr_evlu_tota", "0") or "0")
|
||||||
|
total_cash = safe_float(balance_info.get("frcr_dncl_amt_2", "0") or "0")
|
||||||
|
purchase_total = safe_float(balance_info.get("frcr_buy_amt_smtl", "0") or "0")
|
||||||
|
|
||||||
|
current_price = safe_float(price_data.get("output", {}).get("last", "0"))
|
||||||
foreigner_net = 0.0 # Not available for overseas
|
foreigner_net = 0.0 # Not available for overseas
|
||||||
|
|
||||||
# Calculate daily P&L %
|
# Calculate daily P&L %
|
||||||
@@ -199,11 +239,23 @@ async def trading_cycle(
|
|||||||
order_amount = current_price * quantity
|
order_amount = current_price * quantity
|
||||||
|
|
||||||
# 4. Risk check BEFORE order
|
# 4. Risk check BEFORE order
|
||||||
risk.validate_order(
|
try:
|
||||||
current_pnl_pct=pnl_pct,
|
risk.validate_order(
|
||||||
order_amount=order_amount,
|
current_pnl_pct=pnl_pct,
|
||||||
total_cash=total_cash,
|
order_amount=order_amount,
|
||||||
)
|
total_cash=total_cash,
|
||||||
|
)
|
||||||
|
except FatFingerRejected as exc:
|
||||||
|
try:
|
||||||
|
await telegram.notify_fat_finger(
|
||||||
|
stock_code=stock_code,
|
||||||
|
order_amount=exc.order_amount,
|
||||||
|
total_cash=exc.total_cash,
|
||||||
|
max_pct=exc.max_pct,
|
||||||
|
)
|
||||||
|
except Exception as notify_exc:
|
||||||
|
logger.warning("Fat finger notification failed: %s", notify_exc)
|
||||||
|
raise # Re-raise to prevent trade
|
||||||
|
|
||||||
# 5. Send order
|
# 5. Send order
|
||||||
if market.is_domestic:
|
if market.is_domestic:
|
||||||
@@ -223,6 +275,19 @@ async def trading_cycle(
|
|||||||
)
|
)
|
||||||
logger.info("Order result: %s", result.get("msg1", "OK"))
|
logger.info("Order result: %s", result.get("msg1", "OK"))
|
||||||
|
|
||||||
|
# 5.5. Notify trade execution
|
||||||
|
try:
|
||||||
|
await telegram.notify_trade_execution(
|
||||||
|
stock_code=stock_code,
|
||||||
|
market=market.name,
|
||||||
|
action=decision.action,
|
||||||
|
quantity=quantity,
|
||||||
|
price=current_price,
|
||||||
|
confidence=decision.confidence,
|
||||||
|
)
|
||||||
|
except Exception as exc:
|
||||||
|
logger.warning("Telegram notification failed: %s", exc)
|
||||||
|
|
||||||
# 6. Log trade
|
# 6. Log trade
|
||||||
log_trade(
|
log_trade(
|
||||||
conn=db_conn,
|
conn=db_conn,
|
||||||
@@ -266,6 +331,13 @@ async def run(settings: Settings) -> None:
|
|||||||
decision_logger = DecisionLogger(db_conn)
|
decision_logger = DecisionLogger(db_conn)
|
||||||
context_store = ContextStore(db_conn)
|
context_store = ContextStore(db_conn)
|
||||||
|
|
||||||
|
# Initialize Telegram notifications
|
||||||
|
telegram = TelegramClient(
|
||||||
|
bot_token=settings.TELEGRAM_BOT_TOKEN,
|
||||||
|
chat_id=settings.TELEGRAM_CHAT_ID,
|
||||||
|
enabled=settings.TELEGRAM_ENABLED,
|
||||||
|
)
|
||||||
|
|
||||||
# Initialize volatility hunter
|
# Initialize volatility hunter
|
||||||
volatility_analyzer = VolatilityAnalyzer(min_volume_surge=2.0, min_price_change=1.0)
|
volatility_analyzer = VolatilityAnalyzer(min_volume_surge=2.0, min_price_change=1.0)
|
||||||
market_scanner = MarketScanner(
|
market_scanner = MarketScanner(
|
||||||
@@ -289,6 +361,9 @@ async def run(settings: Settings) -> None:
|
|||||||
# Track last scan time for each market
|
# Track last scan time for each market
|
||||||
last_scan_time: dict[str, float] = {}
|
last_scan_time: dict[str, float] = {}
|
||||||
|
|
||||||
|
# Track market open/close state for notifications
|
||||||
|
_market_states: dict[str, bool] = {} # market_code -> is_open
|
||||||
|
|
||||||
shutdown = asyncio.Event()
|
shutdown = asyncio.Event()
|
||||||
|
|
||||||
def _signal_handler() -> None:
|
def _signal_handler() -> None:
|
||||||
@@ -302,12 +377,31 @@ async def run(settings: Settings) -> None:
|
|||||||
logger.info("The Ouroboros is alive. Mode: %s", settings.MODE)
|
logger.info("The Ouroboros is alive. Mode: %s", settings.MODE)
|
||||||
logger.info("Enabled markets: %s", settings.enabled_market_list)
|
logger.info("Enabled markets: %s", settings.enabled_market_list)
|
||||||
|
|
||||||
|
# Notify system startup
|
||||||
|
try:
|
||||||
|
await telegram.notify_system_start(settings.MODE, settings.enabled_market_list)
|
||||||
|
except Exception as exc:
|
||||||
|
logger.warning("System startup notification failed: %s", exc)
|
||||||
|
|
||||||
try:
|
try:
|
||||||
while not shutdown.is_set():
|
while not shutdown.is_set():
|
||||||
# Get currently open markets
|
# Get currently open markets
|
||||||
open_markets = get_open_markets(settings.enabled_market_list)
|
open_markets = get_open_markets(settings.enabled_market_list)
|
||||||
|
|
||||||
if not open_markets:
|
if not open_markets:
|
||||||
|
# Notify market close for any markets that were open
|
||||||
|
for market_code, is_open in list(_market_states.items()):
|
||||||
|
if is_open:
|
||||||
|
try:
|
||||||
|
from src.markets.schedule import MARKETS
|
||||||
|
|
||||||
|
market_info = MARKETS.get(market_code)
|
||||||
|
if market_info:
|
||||||
|
await telegram.notify_market_close(market_info.name, 0.0)
|
||||||
|
except Exception as exc:
|
||||||
|
logger.warning("Market close notification failed: %s", exc)
|
||||||
|
_market_states[market_code] = False
|
||||||
|
|
||||||
# No markets open — wait until next market opens
|
# No markets open — wait until next market opens
|
||||||
try:
|
try:
|
||||||
next_market, next_open_time = get_next_market_open(
|
next_market, next_open_time = get_next_market_open(
|
||||||
@@ -333,6 +427,14 @@ async def run(settings: Settings) -> None:
|
|||||||
if shutdown.is_set():
|
if shutdown.is_set():
|
||||||
break
|
break
|
||||||
|
|
||||||
|
# Notify market open if it just opened
|
||||||
|
if not _market_states.get(market.code, False):
|
||||||
|
try:
|
||||||
|
await telegram.notify_market_open(market.name)
|
||||||
|
except Exception as exc:
|
||||||
|
logger.warning("Market open notification failed: %s", exc)
|
||||||
|
_market_states[market.code] = True
|
||||||
|
|
||||||
# Volatility Hunter: Scan market periodically to update watchlist
|
# Volatility Hunter: Scan market periodically to update watchlist
|
||||||
now_timestamp = asyncio.get_event_loop().time()
|
now_timestamp = asyncio.get_event_loop().time()
|
||||||
last_scan = last_scan_time.get(market.code, 0.0)
|
last_scan = last_scan_time.get(market.code, 0.0)
|
||||||
@@ -391,12 +493,22 @@ async def run(settings: Settings) -> None:
|
|||||||
decision_logger,
|
decision_logger,
|
||||||
context_store,
|
context_store,
|
||||||
criticality_assessor,
|
criticality_assessor,
|
||||||
|
telegram,
|
||||||
market,
|
market,
|
||||||
stock_code,
|
stock_code,
|
||||||
)
|
)
|
||||||
break # Success — exit retry loop
|
break # Success — exit retry loop
|
||||||
except CircuitBreakerTripped:
|
except CircuitBreakerTripped as exc:
|
||||||
logger.critical("Circuit breaker tripped — shutting down")
|
logger.critical("Circuit breaker tripped — shutting down")
|
||||||
|
try:
|
||||||
|
await telegram.notify_circuit_breaker(
|
||||||
|
pnl_pct=exc.pnl_pct,
|
||||||
|
threshold=exc.threshold,
|
||||||
|
)
|
||||||
|
except Exception as notify_exc:
|
||||||
|
logger.warning(
|
||||||
|
"Circuit breaker notification failed: %s", notify_exc
|
||||||
|
)
|
||||||
raise
|
raise
|
||||||
except ConnectionError as exc:
|
except ConnectionError as exc:
|
||||||
if attempt < MAX_CONNECTION_RETRIES:
|
if attempt < MAX_CONNECTION_RETRIES:
|
||||||
|
|||||||
@@ -49,6 +49,46 @@ class TestTokenManagement:
|
|||||||
|
|
||||||
await broker.close()
|
await broker.close()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_concurrent_token_refresh_calls_api_once(self, settings):
|
||||||
|
"""Multiple concurrent token requests should only call API once."""
|
||||||
|
broker = KISBroker(settings)
|
||||||
|
|
||||||
|
# Track how many times the mock API is called
|
||||||
|
call_count = [0]
|
||||||
|
|
||||||
|
def create_mock_resp():
|
||||||
|
call_count[0] += 1
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.json = AsyncMock(
|
||||||
|
return_value={
|
||||||
|
"access_token": "tok_concurrent",
|
||||||
|
"token_type": "Bearer",
|
||||||
|
"expires_in": 86400,
|
||||||
|
}
|
||||||
|
)
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
return mock_resp
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=create_mock_resp()):
|
||||||
|
# Launch 5 concurrent token requests
|
||||||
|
tokens = await asyncio.gather(
|
||||||
|
broker._ensure_token(),
|
||||||
|
broker._ensure_token(),
|
||||||
|
broker._ensure_token(),
|
||||||
|
broker._ensure_token(),
|
||||||
|
broker._ensure_token(),
|
||||||
|
)
|
||||||
|
|
||||||
|
# All should get the same token
|
||||||
|
assert all(t == "tok_concurrent" for t in tokens)
|
||||||
|
# API should be called only once (due to lock)
|
||||||
|
assert call_count[0] == 1
|
||||||
|
|
||||||
|
await broker.close()
|
||||||
|
|
||||||
|
|
||||||
# ---------------------------------------------------------------------------
|
# ---------------------------------------------------------------------------
|
||||||
# Network Error Handling
|
# Network Error Handling
|
||||||
|
|||||||
651
tests/test_main.py
Normal file
651
tests/test_main.py
Normal file
@@ -0,0 +1,651 @@
|
|||||||
|
"""Tests for main trading loop telegram integration."""
|
||||||
|
|
||||||
|
import asyncio
|
||||||
|
from unittest.mock import AsyncMock, MagicMock, patch
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
from src.core.risk_manager import CircuitBreakerTripped, FatFingerRejected
|
||||||
|
from src.main import safe_float, trading_cycle
|
||||||
|
|
||||||
|
|
||||||
|
class TestSafeFloat:
|
||||||
|
"""Test safe_float() helper function."""
|
||||||
|
|
||||||
|
def test_converts_valid_string(self):
|
||||||
|
"""Test conversion of valid numeric string."""
|
||||||
|
assert safe_float("123.45") == 123.45
|
||||||
|
assert safe_float("0") == 0.0
|
||||||
|
assert safe_float("-99.9") == -99.9
|
||||||
|
|
||||||
|
def test_handles_empty_string(self):
|
||||||
|
"""Test empty string returns default."""
|
||||||
|
assert safe_float("") == 0.0
|
||||||
|
assert safe_float("", 99.0) == 99.0
|
||||||
|
|
||||||
|
def test_handles_none(self):
|
||||||
|
"""Test None returns default."""
|
||||||
|
assert safe_float(None) == 0.0
|
||||||
|
assert safe_float(None, 42.0) == 42.0
|
||||||
|
|
||||||
|
def test_handles_invalid_string(self):
|
||||||
|
"""Test invalid string returns default."""
|
||||||
|
assert safe_float("invalid") == 0.0
|
||||||
|
assert safe_float("not_a_number", 100.0) == 100.0
|
||||||
|
assert safe_float("12.34.56") == 0.0
|
||||||
|
|
||||||
|
def test_handles_float_input(self):
|
||||||
|
"""Test float input passes through."""
|
||||||
|
assert safe_float(123.45) == 123.45
|
||||||
|
assert safe_float(0.0) == 0.0
|
||||||
|
|
||||||
|
def test_custom_default(self):
|
||||||
|
"""Test custom default value."""
|
||||||
|
assert safe_float("", -1.0) == -1.0
|
||||||
|
assert safe_float(None, 999.0) == 999.0
|
||||||
|
|
||||||
|
|
||||||
|
class TestTradingCycleTelegramIntegration:
|
||||||
|
"""Test telegram notifications in trading_cycle function."""
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_broker(self) -> MagicMock:
|
||||||
|
"""Create mock broker."""
|
||||||
|
broker = MagicMock()
|
||||||
|
broker.get_orderbook = AsyncMock(
|
||||||
|
return_value={
|
||||||
|
"output1": {
|
||||||
|
"stck_prpr": "50000",
|
||||||
|
"frgn_ntby_qty": "100",
|
||||||
|
}
|
||||||
|
}
|
||||||
|
)
|
||||||
|
broker.get_balance = AsyncMock(
|
||||||
|
return_value={
|
||||||
|
"output2": [
|
||||||
|
{
|
||||||
|
"tot_evlu_amt": "10000000",
|
||||||
|
"dnca_tot_amt": "5000000",
|
||||||
|
"pchs_amt_smtl_amt": "5000000",
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
)
|
||||||
|
broker.send_order = AsyncMock(return_value={"msg1": "OK"})
|
||||||
|
return broker
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_overseas_broker(self) -> MagicMock:
|
||||||
|
"""Create mock overseas broker."""
|
||||||
|
broker = MagicMock()
|
||||||
|
return broker
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_brain(self) -> MagicMock:
|
||||||
|
"""Create mock brain that decides to buy."""
|
||||||
|
brain = MagicMock()
|
||||||
|
decision = MagicMock()
|
||||||
|
decision.action = "BUY"
|
||||||
|
decision.confidence = 85
|
||||||
|
decision.rationale = "Test buy"
|
||||||
|
brain.decide = AsyncMock(return_value=decision)
|
||||||
|
return brain
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_risk(self) -> MagicMock:
|
||||||
|
"""Create mock risk manager."""
|
||||||
|
risk = MagicMock()
|
||||||
|
risk.validate_order = MagicMock()
|
||||||
|
return risk
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_db(self) -> MagicMock:
|
||||||
|
"""Create mock database connection."""
|
||||||
|
return MagicMock()
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_decision_logger(self) -> MagicMock:
|
||||||
|
"""Create mock decision logger."""
|
||||||
|
logger = MagicMock()
|
||||||
|
logger.log_decision = MagicMock()
|
||||||
|
return logger
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_context_store(self) -> MagicMock:
|
||||||
|
"""Create mock context store."""
|
||||||
|
store = MagicMock()
|
||||||
|
store.get_latest_timeframe = MagicMock(return_value=None)
|
||||||
|
return store
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_criticality_assessor(self) -> MagicMock:
|
||||||
|
"""Create mock criticality assessor."""
|
||||||
|
assessor = MagicMock()
|
||||||
|
assessor.assess_market_conditions = MagicMock(
|
||||||
|
return_value=MagicMock(value="NORMAL")
|
||||||
|
)
|
||||||
|
assessor.get_timeout = MagicMock(return_value=5.0)
|
||||||
|
return assessor
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_telegram(self) -> MagicMock:
|
||||||
|
"""Create mock telegram client."""
|
||||||
|
telegram = MagicMock()
|
||||||
|
telegram.notify_trade_execution = AsyncMock()
|
||||||
|
telegram.notify_fat_finger = AsyncMock()
|
||||||
|
telegram.notify_circuit_breaker = AsyncMock()
|
||||||
|
return telegram
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_market(self) -> MagicMock:
|
||||||
|
"""Create mock market info."""
|
||||||
|
market = MagicMock()
|
||||||
|
market.name = "Korea"
|
||||||
|
market.code = "KR"
|
||||||
|
market.exchange_code = "KRX"
|
||||||
|
market.is_domestic = True
|
||||||
|
return market
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_trade_execution_notification_sent(
|
||||||
|
self,
|
||||||
|
mock_broker: MagicMock,
|
||||||
|
mock_overseas_broker: MagicMock,
|
||||||
|
mock_brain: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test telegram notification sent on trade execution."""
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_broker,
|
||||||
|
overseas_broker=mock_overseas_broker,
|
||||||
|
brain=mock_brain,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_market,
|
||||||
|
stock_code="005930",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify notification was sent
|
||||||
|
mock_telegram.notify_trade_execution.assert_called_once()
|
||||||
|
call_kwargs = mock_telegram.notify_trade_execution.call_args.kwargs
|
||||||
|
assert call_kwargs["stock_code"] == "005930"
|
||||||
|
assert call_kwargs["market"] == "Korea"
|
||||||
|
assert call_kwargs["action"] == "BUY"
|
||||||
|
assert call_kwargs["confidence"] == 85
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_trade_execution_notification_failure_doesnt_crash(
|
||||||
|
self,
|
||||||
|
mock_broker: MagicMock,
|
||||||
|
mock_overseas_broker: MagicMock,
|
||||||
|
mock_brain: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test trading continues even if notification fails."""
|
||||||
|
# Make notification fail
|
||||||
|
mock_telegram.notify_trade_execution.side_effect = Exception("API error")
|
||||||
|
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
# Should not raise exception
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_broker,
|
||||||
|
overseas_broker=mock_overseas_broker,
|
||||||
|
brain=mock_brain,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_market,
|
||||||
|
stock_code="005930",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify notification was attempted
|
||||||
|
mock_telegram.notify_trade_execution.assert_called_once()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_fat_finger_notification_sent(
|
||||||
|
self,
|
||||||
|
mock_broker: MagicMock,
|
||||||
|
mock_overseas_broker: MagicMock,
|
||||||
|
mock_brain: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test telegram notification sent on fat finger rejection."""
|
||||||
|
# Make risk manager reject the order
|
||||||
|
mock_risk.validate_order.side_effect = FatFingerRejected(
|
||||||
|
order_amount=2000000,
|
||||||
|
total_cash=5000000,
|
||||||
|
max_pct=30.0,
|
||||||
|
)
|
||||||
|
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
with pytest.raises(FatFingerRejected):
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_broker,
|
||||||
|
overseas_broker=mock_overseas_broker,
|
||||||
|
brain=mock_brain,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_market,
|
||||||
|
stock_code="005930",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify notification was sent
|
||||||
|
mock_telegram.notify_fat_finger.assert_called_once()
|
||||||
|
call_kwargs = mock_telegram.notify_fat_finger.call_args.kwargs
|
||||||
|
assert call_kwargs["stock_code"] == "005930"
|
||||||
|
assert call_kwargs["order_amount"] == 2000000
|
||||||
|
assert call_kwargs["total_cash"] == 5000000
|
||||||
|
assert call_kwargs["max_pct"] == 30.0
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_fat_finger_notification_failure_still_raises(
|
||||||
|
self,
|
||||||
|
mock_broker: MagicMock,
|
||||||
|
mock_overseas_broker: MagicMock,
|
||||||
|
mock_brain: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test fat finger exception still raised even if notification fails."""
|
||||||
|
# Make risk manager reject the order
|
||||||
|
mock_risk.validate_order.side_effect = FatFingerRejected(
|
||||||
|
order_amount=2000000,
|
||||||
|
total_cash=5000000,
|
||||||
|
max_pct=30.0,
|
||||||
|
)
|
||||||
|
# Make notification fail
|
||||||
|
mock_telegram.notify_fat_finger.side_effect = Exception("API error")
|
||||||
|
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
with pytest.raises(FatFingerRejected):
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_broker,
|
||||||
|
overseas_broker=mock_overseas_broker,
|
||||||
|
brain=mock_brain,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_market,
|
||||||
|
stock_code="005930",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify notification was attempted
|
||||||
|
mock_telegram.notify_fat_finger.assert_called_once()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_no_notification_on_hold_decision(
|
||||||
|
self,
|
||||||
|
mock_broker: MagicMock,
|
||||||
|
mock_overseas_broker: MagicMock,
|
||||||
|
mock_brain: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test no trade notification sent when decision is HOLD."""
|
||||||
|
# Change brain decision to HOLD
|
||||||
|
decision = MagicMock()
|
||||||
|
decision.action = "HOLD"
|
||||||
|
decision.confidence = 50
|
||||||
|
decision.rationale = "Insufficient signal"
|
||||||
|
mock_brain.decide = AsyncMock(return_value=decision)
|
||||||
|
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_broker,
|
||||||
|
overseas_broker=mock_overseas_broker,
|
||||||
|
brain=mock_brain,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_market,
|
||||||
|
stock_code="005930",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify no trade notification sent
|
||||||
|
mock_telegram.notify_trade_execution.assert_not_called()
|
||||||
|
|
||||||
|
|
||||||
|
class TestRunFunctionTelegramIntegration:
|
||||||
|
"""Test telegram notifications in run function."""
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_circuit_breaker_notification_sent(self) -> None:
|
||||||
|
"""Test telegram notification sent when circuit breaker trips."""
|
||||||
|
mock_telegram = MagicMock()
|
||||||
|
mock_telegram.notify_circuit_breaker = AsyncMock()
|
||||||
|
|
||||||
|
# Simulate circuit breaker exception
|
||||||
|
exc = CircuitBreakerTripped(pnl_pct=-3.5, threshold=-3.0)
|
||||||
|
|
||||||
|
# Test the notification logic
|
||||||
|
try:
|
||||||
|
await mock_telegram.notify_circuit_breaker(
|
||||||
|
pnl_pct=exc.pnl_pct,
|
||||||
|
threshold=exc.threshold,
|
||||||
|
)
|
||||||
|
except Exception:
|
||||||
|
pass # Ignore errors in notification
|
||||||
|
|
||||||
|
# Verify notification was called
|
||||||
|
mock_telegram.notify_circuit_breaker.assert_called_once_with(
|
||||||
|
pnl_pct=-3.5,
|
||||||
|
threshold=-3.0,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
class TestOverseasBalanceParsing:
|
||||||
|
"""Test overseas balance output2 parsing handles different formats."""
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_overseas_broker_with_list(self) -> MagicMock:
|
||||||
|
"""Create mock overseas broker returning list format."""
|
||||||
|
broker = MagicMock()
|
||||||
|
broker.get_overseas_price = AsyncMock(
|
||||||
|
return_value={"output": {"last": "150.50"}}
|
||||||
|
)
|
||||||
|
broker.get_overseas_balance = AsyncMock(
|
||||||
|
return_value={
|
||||||
|
"output2": [
|
||||||
|
{
|
||||||
|
"frcr_evlu_tota": "10000.00",
|
||||||
|
"frcr_dncl_amt_2": "5000.00",
|
||||||
|
"frcr_buy_amt_smtl": "4500.00",
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
)
|
||||||
|
return broker
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_overseas_broker_with_dict(self) -> MagicMock:
|
||||||
|
"""Create mock overseas broker returning dict format."""
|
||||||
|
broker = MagicMock()
|
||||||
|
broker.get_overseas_price = AsyncMock(
|
||||||
|
return_value={"output": {"last": "150.50"}}
|
||||||
|
)
|
||||||
|
broker.get_overseas_balance = AsyncMock(
|
||||||
|
return_value={
|
||||||
|
"output2": {
|
||||||
|
"frcr_evlu_tota": "10000.00",
|
||||||
|
"frcr_dncl_amt_2": "5000.00",
|
||||||
|
"frcr_buy_amt_smtl": "4500.00",
|
||||||
|
}
|
||||||
|
}
|
||||||
|
)
|
||||||
|
return broker
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_overseas_broker_with_empty(self) -> MagicMock:
|
||||||
|
"""Create mock overseas broker returning empty output2."""
|
||||||
|
broker = MagicMock()
|
||||||
|
broker.get_overseas_price = AsyncMock(
|
||||||
|
return_value={"output": {"last": "150.50"}}
|
||||||
|
)
|
||||||
|
broker.get_overseas_balance = AsyncMock(return_value={"output2": []})
|
||||||
|
return broker
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_overseas_broker_with_empty_price(self) -> MagicMock:
|
||||||
|
"""Create mock overseas broker returning empty string for price."""
|
||||||
|
broker = MagicMock()
|
||||||
|
broker.get_overseas_price = AsyncMock(
|
||||||
|
return_value={"output": {"last": ""}} # Empty string
|
||||||
|
)
|
||||||
|
broker.get_overseas_balance = AsyncMock(
|
||||||
|
return_value={
|
||||||
|
"output2": [
|
||||||
|
{
|
||||||
|
"frcr_evlu_tota": "10000.00",
|
||||||
|
"frcr_dncl_amt_2": "5000.00",
|
||||||
|
"frcr_buy_amt_smtl": "4500.00",
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
)
|
||||||
|
return broker
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_domestic_broker(self) -> MagicMock:
|
||||||
|
"""Create minimal mock domestic broker."""
|
||||||
|
broker = MagicMock()
|
||||||
|
return broker
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_overseas_market(self) -> MagicMock:
|
||||||
|
"""Create mock overseas market info."""
|
||||||
|
market = MagicMock()
|
||||||
|
market.name = "NASDAQ"
|
||||||
|
market.code = "US_NASDAQ"
|
||||||
|
market.exchange_code = "NASD"
|
||||||
|
market.is_domestic = False
|
||||||
|
return market
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_brain_hold(self) -> MagicMock:
|
||||||
|
"""Create mock brain that always holds."""
|
||||||
|
brain = MagicMock()
|
||||||
|
decision = MagicMock()
|
||||||
|
decision.action = "HOLD"
|
||||||
|
decision.confidence = 50
|
||||||
|
decision.rationale = "Testing balance parsing"
|
||||||
|
brain.decide = AsyncMock(return_value=decision)
|
||||||
|
return brain
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_risk(self) -> MagicMock:
|
||||||
|
"""Create mock risk manager."""
|
||||||
|
return MagicMock()
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_db(self) -> MagicMock:
|
||||||
|
"""Create mock database."""
|
||||||
|
return MagicMock()
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_decision_logger(self) -> MagicMock:
|
||||||
|
"""Create mock decision logger."""
|
||||||
|
return MagicMock()
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_context_store(self) -> MagicMock:
|
||||||
|
"""Create mock context store."""
|
||||||
|
store = MagicMock()
|
||||||
|
store.get_latest_timeframe = MagicMock(return_value=None)
|
||||||
|
return store
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_criticality_assessor(self) -> MagicMock:
|
||||||
|
"""Create mock criticality assessor."""
|
||||||
|
assessor = MagicMock()
|
||||||
|
assessor.assess_market_conditions = MagicMock(
|
||||||
|
return_value=MagicMock(value="NORMAL")
|
||||||
|
)
|
||||||
|
assessor.get_timeout = MagicMock(return_value=5.0)
|
||||||
|
return assessor
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_telegram(self) -> MagicMock:
|
||||||
|
"""Create mock telegram client."""
|
||||||
|
return MagicMock()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_overseas_balance_list_format(
|
||||||
|
self,
|
||||||
|
mock_domestic_broker: MagicMock,
|
||||||
|
mock_overseas_broker_with_list: MagicMock,
|
||||||
|
mock_brain_hold: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_overseas_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test overseas balance parsing with list format (output2=[{...}])."""
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
# Should not raise KeyError
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_domestic_broker,
|
||||||
|
overseas_broker=mock_overseas_broker_with_list,
|
||||||
|
brain=mock_brain_hold,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_overseas_market,
|
||||||
|
stock_code="AAPL",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify balance API was called
|
||||||
|
mock_overseas_broker_with_list.get_overseas_balance.assert_called_once()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_overseas_balance_dict_format(
|
||||||
|
self,
|
||||||
|
mock_domestic_broker: MagicMock,
|
||||||
|
mock_overseas_broker_with_dict: MagicMock,
|
||||||
|
mock_brain_hold: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_overseas_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test overseas balance parsing with dict format (output2={...})."""
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
# Should not raise KeyError
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_domestic_broker,
|
||||||
|
overseas_broker=mock_overseas_broker_with_dict,
|
||||||
|
brain=mock_brain_hold,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_overseas_market,
|
||||||
|
stock_code="AAPL",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify balance API was called
|
||||||
|
mock_overseas_broker_with_dict.get_overseas_balance.assert_called_once()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_overseas_balance_empty_format(
|
||||||
|
self,
|
||||||
|
mock_domestic_broker: MagicMock,
|
||||||
|
mock_overseas_broker_with_empty: MagicMock,
|
||||||
|
mock_brain_hold: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_overseas_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test overseas balance parsing with empty output2."""
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
# Should not raise KeyError, should default to 0
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_domestic_broker,
|
||||||
|
overseas_broker=mock_overseas_broker_with_empty,
|
||||||
|
brain=mock_brain_hold,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_overseas_market,
|
||||||
|
stock_code="AAPL",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify balance API was called
|
||||||
|
mock_overseas_broker_with_empty.get_overseas_balance.assert_called_once()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_overseas_price_empty_string(
|
||||||
|
self,
|
||||||
|
mock_domestic_broker: MagicMock,
|
||||||
|
mock_overseas_broker_with_empty_price: MagicMock,
|
||||||
|
mock_brain_hold: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_overseas_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test overseas price parsing with empty string (issue #49)."""
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
# Should not raise ValueError, should default to 0.0
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_domestic_broker,
|
||||||
|
overseas_broker=mock_overseas_broker_with_empty_price,
|
||||||
|
brain=mock_brain_hold,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_overseas_market,
|
||||||
|
stock_code="AAPL",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify price API was called
|
||||||
|
mock_overseas_broker_with_empty_price.get_overseas_price.assert_called_once()
|
||||||
@@ -338,6 +338,28 @@ class TestMarketScanner:
|
|||||||
assert metrics.stock_code == "AAPL"
|
assert metrics.stock_code == "AAPL"
|
||||||
assert metrics.current_price == 150.50
|
assert metrics.current_price == 150.50
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_scan_stock_overseas_empty_price(
|
||||||
|
self,
|
||||||
|
scanner: MarketScanner,
|
||||||
|
mock_overseas_broker: OverseasBroker,
|
||||||
|
context_store: ContextStore,
|
||||||
|
) -> None:
|
||||||
|
"""Test scanning overseas stock with empty price string (issue #49)."""
|
||||||
|
mock_overseas_broker.get_overseas_price.return_value = {
|
||||||
|
"output": {
|
||||||
|
"last": "", # Empty string
|
||||||
|
"tvol": "", # Empty string
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
market = MARKETS["US_NASDAQ"]
|
||||||
|
metrics = await scanner.scan_stock("AAPL", market)
|
||||||
|
|
||||||
|
assert metrics is not None
|
||||||
|
assert metrics.stock_code == "AAPL"
|
||||||
|
assert metrics.current_price == 0.0 # Should default to 0.0
|
||||||
|
|
||||||
@pytest.mark.asyncio
|
@pytest.mark.asyncio
|
||||||
async def test_scan_stock_error_handling(
|
async def test_scan_stock_error_handling(
|
||||||
self,
|
self,
|
||||||
|
|||||||
Reference in New Issue
Block a user