Compare commits

...

4 Commits

Author SHA1 Message Date
agentson
cb2e3fae57 fix: reduce rate limit from 10 to 5 RPS to avoid API errors (issue #43)
Some checks failed
CI / test (pull_request) Has been cancelled
Reduce RATE_LIMIT_RPS from 10.0 to 5.0 to prevent "초당 거래건수를
초과하였습니다" (EGW00201) errors from KIS API.

Docker logs showed this was the most frequent error (70% of failures),
occurring when multiple stocks are scanned rapidly.

Changes:
- src/config.py: RATE_LIMIT_RPS 10.0 → 5.0
- .env.example: Update default and add explanation comment

Trade-off: Slower API throughput, but more reliable operation.
Can be tuned per deployment via environment variable.

Fixes: #43

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-05 00:12:57 +09:00
5e4c68c9d8 Merge pull request 'fix: add token refresh lock to prevent concurrent API calls (issue #42)' (#46) from feature/issue-42-token-refresh-lock into main
Some checks failed
CI / test (push) Has been cancelled
Reviewed-on: #46
2026-02-05 00:11:04 +09:00
agentson
95f540e5df fix: add token refresh lock to prevent concurrent API calls (issue #42)
Some checks failed
CI / test (pull_request) Has been cancelled
Add asyncio.Lock to prevent multiple coroutines from simultaneously
refreshing the KIS access token, which hits the 1-per-minute rate
limit (EGW00133: "접근토큰 발급 잠시 후 다시 시도하세요").

Changes:
- Add self._token_lock in KISBroker.__init__
- Wrap token refresh in async with self._token_lock
- Re-check token validity after acquiring lock (double-check pattern)
- Add concurrent token refresh test (5 parallel requests → 1 API call)

The lock ensures that when multiple coroutines detect an expired token,
only the first one refreshes while others wait and reuse the result.

Fixes: #42

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-05 00:08:56 +09:00
0087a6b20a Merge pull request 'fix: handle dict and list formats in overseas balance output2 (issue #41)' (#45) from feature/issue-41-keyerror-balance into main
Some checks failed
CI / test (push) Has been cancelled
Reviewed-on: #45
2026-02-05 00:06:25 +09:00
4 changed files with 76 additions and 21 deletions

View File

@@ -16,8 +16,9 @@ CONFIDENCE_THRESHOLD=80
# Database # Database
DB_PATH=data/trade_logs.db DB_PATH=data/trade_logs.db
# Rate Limiting # Rate Limiting (requests per second for KIS API)
RATE_LIMIT_RPS=10.0 # Reduced to 5.0 to avoid "초당 거래건수 초과" errors (EGW00201)
RATE_LIMIT_RPS=5.0
# Trading Mode (paper / live) # Trading Mode (paper / live)
MODE=paper MODE=paper

View File

@@ -55,6 +55,7 @@ class KISBroker:
self._session: aiohttp.ClientSession | None = None self._session: aiohttp.ClientSession | None = None
self._access_token: str | None = None self._access_token: str | None = None
self._token_expires_at: float = 0.0 self._token_expires_at: float = 0.0
self._token_lock = asyncio.Lock()
self._rate_limiter = LeakyBucket(settings.RATE_LIMIT_RPS) self._rate_limiter = LeakyBucket(settings.RATE_LIMIT_RPS)
def _get_session(self) -> aiohttp.ClientSession: def _get_session(self) -> aiohttp.ClientSession:
@@ -80,7 +81,19 @@ class KISBroker:
# ------------------------------------------------------------------ # ------------------------------------------------------------------
async def _ensure_token(self) -> str: async def _ensure_token(self) -> str:
"""Return a valid access token, refreshing if expired.""" """Return a valid access token, refreshing if expired.
Uses a lock to prevent concurrent token refresh attempts that would
hit the API's 1-per-minute rate limit (EGW00133).
"""
# Fast path: check without lock
now = asyncio.get_event_loop().time()
if self._access_token and now < self._token_expires_at:
return self._access_token
# Slow path: acquire lock and refresh
async with self._token_lock:
# Re-check after acquiring lock (another coroutine may have refreshed)
now = asyncio.get_event_loop().time() now = asyncio.get_event_loop().time()
if self._access_token and now < self._token_expires_at: if self._access_token and now < self._token_expires_at:
return self._access_token return self._access_token

View File

@@ -37,7 +37,8 @@ class Settings(BaseSettings):
DB_PATH: str = "data/trade_logs.db" DB_PATH: str = "data/trade_logs.db"
# Rate Limiting (requests per second for KIS API) # Rate Limiting (requests per second for KIS API)
RATE_LIMIT_RPS: float = 10.0 # Reduced to 5.0 to avoid EGW00201 "초당 거래건수 초과" errors
RATE_LIMIT_RPS: float = 5.0
# Trading mode # Trading mode
MODE: str = Field(default="paper", pattern="^(paper|live)$") MODE: str = Field(default="paper", pattern="^(paper|live)$")

View File

@@ -49,6 +49,46 @@ class TestTokenManagement:
await broker.close() await broker.close()
@pytest.mark.asyncio
async def test_concurrent_token_refresh_calls_api_once(self, settings):
"""Multiple concurrent token requests should only call API once."""
broker = KISBroker(settings)
# Track how many times the mock API is called
call_count = [0]
def create_mock_resp():
call_count[0] += 1
mock_resp = AsyncMock()
mock_resp.status = 200
mock_resp.json = AsyncMock(
return_value={
"access_token": "tok_concurrent",
"token_type": "Bearer",
"expires_in": 86400,
}
)
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
mock_resp.__aexit__ = AsyncMock(return_value=False)
return mock_resp
with patch("aiohttp.ClientSession.post", return_value=create_mock_resp()):
# Launch 5 concurrent token requests
tokens = await asyncio.gather(
broker._ensure_token(),
broker._ensure_token(),
broker._ensure_token(),
broker._ensure_token(),
broker._ensure_token(),
)
# All should get the same token
assert all(t == "tok_concurrent" for t in tokens)
# API should be called only once (due to lock)
assert call_count[0] == 1
await broker.close()
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
# Network Error Handling # Network Error Handling