jihoson/The-Ouroboros
1
0
Fork 0
Code Issues Pull Requests Actions 10 Packages Projects Releases Wiki Activity

fix: Telegram command handler errors (/status and /positions) #74

New Issue
Closed
opened 2026-02-05 18:54:24 +09:00 by agentson · 0 comments
agentson commented 2026-02-05 18:54:24 +09:00
Collaborator
Copy Link

Problem

Telegram commands /status and /positions are failing with AttributeError:

  1. Line 630: 'RiskManager' object has no attribute 'calculate_pnl'
  2. Line 645: 'RiskManager' object has no attribute 'circuit_breaker_threshold'
  3. Line 662/673: 'dict' object has no attribute 'stocks'

Root Cause

  • RiskManager doesn't have calculate_pnl() method (P&L calc is in main.py)
  • RiskManager uses private _cb_threshold attribute, not public circuit_breaker_threshold
  • broker.get_balance() returns dict, not object with .stocks attribute

Solution

/status Command

  • Remove invalid risk.calculate_pnl(balance) call
  • Inline P&L calculation from balance dict (output2)
  • Fix risk.circuit_breaker_threshold → risk._cb_threshold

/positions Command

  • Remove balance.stocks references
  • Show account summary instead of individual positions:
    • Total evaluation, cash, purchase total, P&L%
  • Add note about API enhancement needed for individual positions

Testing

  • All unit tests pass (27/27 telegram tests)
  • Live bot testing shows no errors
  • Commands execute successfully
## Problem Telegram commands `/status` and `/positions` are failing with AttributeError: 1. **Line 630**: `'RiskManager' object has no attribute 'calculate_pnl'` 2. **Line 645**: `'RiskManager' object has no attribute 'circuit_breaker_threshold'` 3. **Line 662/673**: `'dict' object has no attribute 'stocks'` ## Root Cause - RiskManager doesn't have `calculate_pnl()` method (P&L calc is in main.py) - RiskManager uses private `_cb_threshold` attribute, not public `circuit_breaker_threshold` - `broker.get_balance()` returns dict, not object with `.stocks` attribute ## Solution ### /status Command - Remove invalid `risk.calculate_pnl(balance)` call - Inline P&L calculation from balance dict (`output2`) - Fix `risk.circuit_breaker_threshold` → `risk._cb_threshold` ### /positions Command - Remove `balance.stocks` references - Show account summary instead of individual positions: - Total evaluation, cash, purchase total, P&L% - Add note about API enhancement needed for individual positions ## Testing - All unit tests pass (27/27 telegram tests) - Live bot testing shows no errors - Commands execute successfully
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agentson jihoson
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jihoson/The-Ouroboros#74
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?