2e550f8b58
Some checks failed
CI / test (pull_request) Has been cancelled
Three bugs found by comparing against KIS official GitHub examples:
1. FID_COND_SCR_DIV_CODE: "20001" → "20171" (volume-rank screen code)
2. FID_TRGT_EXLS_CLS_CODE: "000000" (6-digit) → "0000000000" (10-digit)
3. fluctuation ranking:
- TR_ID: "FHPST01710100" (invalid) → "FHPST01700000"
- path: /quotations/volume-rank → /ranking/fluctuation
- params: volume-rank params → lowercase fluctuation-specific params
(fid_rank_sort_cls_code, fid_input_cnt_1, fid_prc_cls_code,
fid_rsfl_rate1, fid_rsfl_rate2, etc.)
Note: VTS (paper trading) does not return data from ranking APIs regardless
of parameter correctness — this is a KIS policy restriction, not a code bug.
These fixes ensure correct behavior when switching to a live account.
Tests: TestFetchMarketRankings (3 tests) added to test_broker.py
Closes #155
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
378 lines
14 KiB
Python
378 lines
14 KiB
Python
"""TDD tests for broker/kis_api.py — written BEFORE implementation."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from src.broker.kis_api import KISBroker
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Token Management
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestTokenManagement:
|
|
"""Access token must be auto-refreshed and cached."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_fetches_token_on_first_call(self, settings):
|
|
broker = KISBroker(settings)
|
|
mock_resp = AsyncMock()
|
|
mock_resp.status = 200
|
|
mock_resp.json = AsyncMock(
|
|
return_value={
|
|
"access_token": "tok_abc123",
|
|
"token_type": "Bearer",
|
|
"expires_in": 86400,
|
|
}
|
|
)
|
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
|
|
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp):
|
|
token = await broker._ensure_token()
|
|
assert token == "tok_abc123"
|
|
|
|
await broker.close()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_reuses_cached_token(self, settings):
|
|
broker = KISBroker(settings)
|
|
broker._access_token = "cached_token"
|
|
broker._token_expires_at = asyncio.get_event_loop().time() + 3600
|
|
|
|
token = await broker._ensure_token()
|
|
assert token == "cached_token"
|
|
|
|
await broker.close()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_concurrent_token_refresh_calls_api_once(self, settings):
|
|
"""Multiple concurrent token requests should only call API once."""
|
|
broker = KISBroker(settings)
|
|
|
|
# Track how many times the mock API is called
|
|
call_count = [0]
|
|
|
|
def create_mock_resp():
|
|
call_count[0] += 1
|
|
mock_resp = AsyncMock()
|
|
mock_resp.status = 200
|
|
mock_resp.json = AsyncMock(
|
|
return_value={
|
|
"access_token": "tok_concurrent",
|
|
"token_type": "Bearer",
|
|
"expires_in": 86400,
|
|
}
|
|
)
|
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
|
return mock_resp
|
|
|
|
with patch("aiohttp.ClientSession.post", return_value=create_mock_resp()):
|
|
# Launch 5 concurrent token requests
|
|
tokens = await asyncio.gather(
|
|
broker._ensure_token(),
|
|
broker._ensure_token(),
|
|
broker._ensure_token(),
|
|
broker._ensure_token(),
|
|
broker._ensure_token(),
|
|
)
|
|
|
|
# All should get the same token
|
|
assert all(t == "tok_concurrent" for t in tokens)
|
|
# API should be called only once (due to lock)
|
|
assert call_count[0] == 1
|
|
|
|
await broker.close()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_token_refresh_cooldown_waits_then_retries(self, settings):
|
|
"""Token refresh should wait out cooldown then retry (issue #54)."""
|
|
broker = KISBroker(settings)
|
|
broker._refresh_cooldown = 0.1 # Short cooldown for testing
|
|
|
|
# All attempts fail with 403 (EGW00133)
|
|
mock_resp_403 = AsyncMock()
|
|
mock_resp_403.status = 403
|
|
mock_resp_403.text = AsyncMock(
|
|
return_value='{"error_code":"EGW00133","error_description":"접근토큰 발급 잠시 후 다시 시도하세요(1분당 1회)"}'
|
|
)
|
|
mock_resp_403.__aenter__ = AsyncMock(return_value=mock_resp_403)
|
|
mock_resp_403.__aexit__ = AsyncMock(return_value=False)
|
|
|
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp_403):
|
|
# First attempt should fail with 403
|
|
with pytest.raises(ConnectionError, match="Token refresh failed"):
|
|
await broker._ensure_token()
|
|
|
|
# Second attempt within cooldown should wait then retry (and still get 403)
|
|
with pytest.raises(ConnectionError, match="Token refresh failed"):
|
|
await broker._ensure_token()
|
|
|
|
await broker.close()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_token_refresh_allowed_after_cooldown(self, settings):
|
|
"""Token refresh should be allowed after cooldown period expires."""
|
|
broker = KISBroker(settings)
|
|
broker._refresh_cooldown = 0.1 # Very short cooldown for testing
|
|
|
|
# First attempt fails
|
|
mock_resp_403 = AsyncMock()
|
|
mock_resp_403.status = 403
|
|
mock_resp_403.text = AsyncMock(return_value='{"error_code":"EGW00133"}')
|
|
mock_resp_403.__aenter__ = AsyncMock(return_value=mock_resp_403)
|
|
mock_resp_403.__aexit__ = AsyncMock(return_value=False)
|
|
|
|
# Second attempt succeeds
|
|
mock_resp_200 = AsyncMock()
|
|
mock_resp_200.status = 200
|
|
mock_resp_200.json = AsyncMock(
|
|
return_value={
|
|
"access_token": "tok_after_cooldown",
|
|
"expires_in": 86400,
|
|
}
|
|
)
|
|
mock_resp_200.__aenter__ = AsyncMock(return_value=mock_resp_200)
|
|
mock_resp_200.__aexit__ = AsyncMock(return_value=False)
|
|
|
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp_403):
|
|
with pytest.raises(ConnectionError, match="Token refresh failed"):
|
|
await broker._ensure_token()
|
|
|
|
# Wait for cooldown to expire
|
|
await asyncio.sleep(0.15)
|
|
|
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp_200):
|
|
token = await broker._ensure_token()
|
|
assert token == "tok_after_cooldown"
|
|
|
|
await broker.close()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Network Error Handling
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestNetworkErrorHandling:
|
|
"""Broker must handle network timeouts and HTTP errors gracefully."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_timeout_raises_connection_error(self, settings):
|
|
broker = KISBroker(settings)
|
|
broker._access_token = "tok"
|
|
broker._token_expires_at = asyncio.get_event_loop().time() + 3600
|
|
|
|
with patch(
|
|
"aiohttp.ClientSession.get",
|
|
side_effect=TimeoutError(),
|
|
):
|
|
with pytest.raises(ConnectionError):
|
|
await broker.get_orderbook("005930")
|
|
|
|
await broker.close()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_http_500_raises_connection_error(self, settings):
|
|
broker = KISBroker(settings)
|
|
broker._access_token = "tok"
|
|
broker._token_expires_at = asyncio.get_event_loop().time() + 3600
|
|
|
|
mock_resp = AsyncMock()
|
|
mock_resp.status = 500
|
|
mock_resp.text = AsyncMock(return_value="Internal Server Error")
|
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
|
|
|
with patch("aiohttp.ClientSession.get", return_value=mock_resp):
|
|
with pytest.raises(ConnectionError):
|
|
await broker.get_orderbook("005930")
|
|
|
|
await broker.close()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Rate Limiter
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestRateLimiter:
|
|
"""The leaky bucket rate limiter must throttle requests."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_rate_limiter_does_not_block_under_limit(self, settings):
|
|
broker = KISBroker(settings)
|
|
# Should complete without blocking when under limit
|
|
await broker._rate_limiter.acquire()
|
|
await broker.close()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_send_order_acquires_rate_limiter_twice(self, settings):
|
|
"""send_order must acquire rate limiter for both hash key and order call."""
|
|
broker = KISBroker(settings)
|
|
broker._access_token = "tok"
|
|
broker._token_expires_at = asyncio.get_event_loop().time() + 3600
|
|
|
|
# Mock hash key response
|
|
mock_hash_resp = AsyncMock()
|
|
mock_hash_resp.status = 200
|
|
mock_hash_resp.json = AsyncMock(return_value={"HASH": "abc123"})
|
|
mock_hash_resp.__aenter__ = AsyncMock(return_value=mock_hash_resp)
|
|
mock_hash_resp.__aexit__ = AsyncMock(return_value=False)
|
|
|
|
# Mock order response
|
|
mock_order_resp = AsyncMock()
|
|
mock_order_resp.status = 200
|
|
mock_order_resp.json = AsyncMock(return_value={"rt_cd": "0"})
|
|
mock_order_resp.__aenter__ = AsyncMock(return_value=mock_order_resp)
|
|
mock_order_resp.__aexit__ = AsyncMock(return_value=False)
|
|
|
|
with patch(
|
|
"aiohttp.ClientSession.post", side_effect=[mock_hash_resp, mock_order_resp]
|
|
):
|
|
with patch.object(
|
|
broker._rate_limiter, "acquire", new_callable=AsyncMock
|
|
) as mock_acquire:
|
|
await broker.send_order("005930", "BUY", 1, 50000)
|
|
assert mock_acquire.call_count == 2
|
|
|
|
await broker.close()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Hash Key Generation
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestHashKey:
|
|
"""POST requests to KIS require a hash key."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_generates_hash_key_for_post_body(self, settings):
|
|
broker = KISBroker(settings)
|
|
broker._access_token = "tok"
|
|
broker._token_expires_at = asyncio.get_event_loop().time() + 3600
|
|
|
|
body = {"CANO": "12345678", "ACNT_PRDT_CD": "01"}
|
|
|
|
mock_resp = AsyncMock()
|
|
mock_resp.status = 200
|
|
mock_resp.json = AsyncMock(return_value={"HASH": "abc123hash"})
|
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
|
|
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp):
|
|
hash_key = await broker._get_hash_key(body)
|
|
assert isinstance(hash_key, str)
|
|
assert len(hash_key) > 0
|
|
|
|
await broker.close()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_hash_key_acquires_rate_limiter(self, settings):
|
|
"""_get_hash_key must go through the rate limiter to prevent burst."""
|
|
broker = KISBroker(settings)
|
|
broker._access_token = "tok"
|
|
broker._token_expires_at = asyncio.get_event_loop().time() + 3600
|
|
|
|
body = {"CANO": "12345678", "ACNT_PRDT_CD": "01"}
|
|
|
|
mock_resp = AsyncMock()
|
|
mock_resp.status = 200
|
|
mock_resp.json = AsyncMock(return_value={"HASH": "abc123hash"})
|
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
|
|
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp):
|
|
with patch.object(
|
|
broker._rate_limiter, "acquire", new_callable=AsyncMock
|
|
) as mock_acquire:
|
|
await broker._get_hash_key(body)
|
|
mock_acquire.assert_called_once()
|
|
|
|
await broker.close()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# fetch_market_rankings — TR_ID, path, params (issue #155)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def _make_ranking_mock(items: list[dict]) -> AsyncMock:
|
|
"""Build a mock HTTP response returning ranking items."""
|
|
mock_resp = AsyncMock()
|
|
mock_resp.status = 200
|
|
mock_resp.json = AsyncMock(return_value={"output": items})
|
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
|
return mock_resp
|
|
|
|
|
|
class TestFetchMarketRankings:
|
|
"""Verify correct TR_ID, API path, and params per ranking_type (issue #155)."""
|
|
|
|
@pytest.fixture
|
|
def broker(self, settings) -> KISBroker:
|
|
b = KISBroker(settings)
|
|
b._access_token = "tok"
|
|
b._token_expires_at = float("inf")
|
|
b._rate_limiter.acquire = AsyncMock()
|
|
return b
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_volume_uses_correct_tr_id_and_path(self, broker: KISBroker) -> None:
|
|
mock_resp = _make_ranking_mock([])
|
|
with patch("aiohttp.ClientSession.get", return_value=mock_resp) as mock_get:
|
|
await broker.fetch_market_rankings(ranking_type="volume")
|
|
|
|
call_kwargs = mock_get.call_args
|
|
url = call_kwargs[0][0] if call_kwargs[0] else call_kwargs[1].get("url", "")
|
|
headers = call_kwargs[1].get("headers", {})
|
|
params = call_kwargs[1].get("params", {})
|
|
|
|
assert "volume-rank" in url
|
|
assert headers.get("tr_id") == "FHPST01710000"
|
|
assert params.get("FID_COND_SCR_DIV_CODE") == "20171"
|
|
assert params.get("FID_TRGT_EXLS_CLS_CODE") == "0000000000"
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_fluctuation_uses_correct_tr_id_and_path(self, broker: KISBroker) -> None:
|
|
mock_resp = _make_ranking_mock([])
|
|
with patch("aiohttp.ClientSession.get", return_value=mock_resp) as mock_get:
|
|
await broker.fetch_market_rankings(ranking_type="fluctuation")
|
|
|
|
call_kwargs = mock_get.call_args
|
|
url = call_kwargs[0][0] if call_kwargs[0] else call_kwargs[1].get("url", "")
|
|
headers = call_kwargs[1].get("headers", {})
|
|
params = call_kwargs[1].get("params", {})
|
|
|
|
assert "ranking/fluctuation" in url
|
|
assert headers.get("tr_id") == "FHPST01700000"
|
|
assert params.get("fid_cond_scr_div_code") == "20170"
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_volume_returns_parsed_rows(self, broker: KISBroker) -> None:
|
|
items = [
|
|
{
|
|
"mksc_shrn_iscd": "005930",
|
|
"hts_kor_isnm": "삼성전자",
|
|
"stck_prpr": "75000",
|
|
"acml_vol": "10000000",
|
|
"prdy_ctrt": "2.5",
|
|
"vol_inrt": "150",
|
|
}
|
|
]
|
|
mock_resp = _make_ranking_mock(items)
|
|
with patch("aiohttp.ClientSession.get", return_value=mock_resp):
|
|
result = await broker.fetch_market_rankings(ranking_type="volume")
|
|
|
|
assert len(result) == 1
|
|
assert result[0]["stock_code"] == "005930"
|
|
assert result[0]["price"] == 75000.0
|
|
assert result[0]["change_rate"] == 2.5
|