Compare commits
42 Commits
feature/is
...
feature/is
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
18a098d9a6 | ||
| d2b07326ed | |||
|
|
1c5eadc23b | ||
| 10ff718045 | |||
|
|
0ca3fe9f5d | ||
| 462f8763ab | |||
|
|
57a45a24cb | ||
| a7696568cc | |||
|
|
70701bf73a | ||
| 20dbd94892 | |||
|
|
48a99962e3 | ||
| ee66ecc305 | |||
|
|
065c9daaad | ||
| c76b9d5c15 | |||
|
|
259f9d2e24 | ||
| 8e715c55cd | |||
|
|
0057de4d12 | ||
|
|
71ac59794e | ||
| be04820b00 | |||
| 10b6e34d44 | |||
| 58f1106dbd | |||
| cf5072cced | |||
|
|
702653e52e | ||
|
|
db0d966a6a | ||
|
|
a56adcd342 | ||
|
|
eaf509a895 | ||
|
|
854931bed2 | ||
| 33b5ff5e54 | |||
| 3923d03650 | |||
|
|
c57ccc4bca | ||
|
|
cb2e3fae57 | ||
| 5e4c68c9d8 | |||
|
|
95f540e5df | ||
| 0087a6b20a | |||
|
|
3dfd7c0935 | ||
| 4b2bb25d03 | |||
|
|
881bbb4240 | ||
| 5f7d61748b | |||
|
|
972e71a2f1 | ||
| 614b9939b1 | |||
|
|
6dbc2afbf4 | ||
| 6c96f9ac64 |
12
.env.example
12
.env.example
@@ -16,8 +16,9 @@ CONFIDENCE_THRESHOLD=80
|
|||||||
# Database
|
# Database
|
||||||
DB_PATH=data/trade_logs.db
|
DB_PATH=data/trade_logs.db
|
||||||
|
|
||||||
# Rate Limiting
|
# Rate Limiting (requests per second for KIS API)
|
||||||
RATE_LIMIT_RPS=10.0
|
# Reduced to 5.0 to avoid "초당 거래건수 초과" errors (EGW00201)
|
||||||
|
RATE_LIMIT_RPS=5.0
|
||||||
|
|
||||||
# Trading Mode (paper / live)
|
# Trading Mode (paper / live)
|
||||||
MODE=paper
|
MODE=paper
|
||||||
@@ -26,3 +27,10 @@ MODE=paper
|
|||||||
# NEWS_API_KEY=your_news_api_key_here
|
# NEWS_API_KEY=your_news_api_key_here
|
||||||
# NEWS_API_PROVIDER=alphavantage
|
# NEWS_API_PROVIDER=alphavantage
|
||||||
# MARKET_DATA_API_KEY=your_market_data_key_here
|
# MARKET_DATA_API_KEY=your_market_data_key_here
|
||||||
|
|
||||||
|
# Telegram Notifications (optional)
|
||||||
|
# Get bot token from @BotFather on Telegram
|
||||||
|
# Get chat ID from @userinfobot or your chat
|
||||||
|
# TELEGRAM_BOT_TOKEN=1234567890:ABCdefGHIjklMNOpqrsTUVwxyz
|
||||||
|
# TELEGRAM_CHAT_ID=123456789
|
||||||
|
# TELEGRAM_ENABLED=true
|
||||||
|
|||||||
41
CLAUDE.md
41
CLAUDE.md
@@ -17,6 +17,34 @@ pytest -v --cov=src
|
|||||||
python -m src.main --mode=paper
|
python -m src.main --mode=paper
|
||||||
```
|
```
|
||||||
|
|
||||||
|
## Telegram Notifications (Optional)
|
||||||
|
|
||||||
|
Get real-time alerts for trades, circuit breakers, and system events via Telegram.
|
||||||
|
|
||||||
|
### Quick Setup
|
||||||
|
|
||||||
|
1. **Create bot**: Message [@BotFather](https://t.me/BotFather) on Telegram → `/newbot`
|
||||||
|
2. **Get chat ID**: Message [@userinfobot](https://t.me/userinfobot) → `/start`
|
||||||
|
3. **Configure**: Add to `.env`:
|
||||||
|
```bash
|
||||||
|
TELEGRAM_BOT_TOKEN=1234567890:ABCdefGHIjklMNOpqrsTUVwxyz
|
||||||
|
TELEGRAM_CHAT_ID=123456789
|
||||||
|
TELEGRAM_ENABLED=true
|
||||||
|
```
|
||||||
|
4. **Test**: Start bot conversation (`/start`), then run the agent
|
||||||
|
|
||||||
|
**Full documentation**: [src/notifications/README.md](src/notifications/README.md)
|
||||||
|
|
||||||
|
### What You'll Get
|
||||||
|
|
||||||
|
- 🟢 Trade execution alerts (BUY/SELL with confidence)
|
||||||
|
- 🚨 Circuit breaker trips (automatic trading halt)
|
||||||
|
- ⚠️ Fat-finger rejections (oversized orders blocked)
|
||||||
|
- ℹ️ Market open/close notifications
|
||||||
|
- 📝 System startup/shutdown status
|
||||||
|
|
||||||
|
**Fail-safe**: Notifications never crash the trading system. Missing credentials or API errors are logged but trading continues normally.
|
||||||
|
|
||||||
## Documentation
|
## Documentation
|
||||||
|
|
||||||
- **[Workflow Guide](docs/workflow.md)** — Git workflow policy and agent-based development
|
- **[Workflow Guide](docs/workflow.md)** — Git workflow policy and agent-based development
|
||||||
@@ -25,6 +53,7 @@ python -m src.main --mode=paper
|
|||||||
- **[Context Tree](docs/context-tree.md)** — L1-L7 hierarchical memory system
|
- **[Context Tree](docs/context-tree.md)** — L1-L7 hierarchical memory system
|
||||||
- **[Testing](docs/testing.md)** — Test structure, coverage requirements, writing tests
|
- **[Testing](docs/testing.md)** — Test structure, coverage requirements, writing tests
|
||||||
- **[Agent Policies](docs/agents.md)** — Prime directives, constraints, prohibited actions
|
- **[Agent Policies](docs/agents.md)** — Prime directives, constraints, prohibited actions
|
||||||
|
- **[Requirements Log](docs/requirements-log.md)** — User requirements and feedback tracking
|
||||||
|
|
||||||
## Core Principles
|
## Core Principles
|
||||||
|
|
||||||
@@ -33,6 +62,15 @@ python -m src.main --mode=paper
|
|||||||
3. **Issue-Driven Development** — All work goes through Gitea issues → feature branches → PRs
|
3. **Issue-Driven Development** — All work goes through Gitea issues → feature branches → PRs
|
||||||
4. **Agent Specialization** — Use dedicated agents for design, coding, testing, docs, review
|
4. **Agent Specialization** — Use dedicated agents for design, coding, testing, docs, review
|
||||||
|
|
||||||
|
## Requirements Management
|
||||||
|
|
||||||
|
User requirements and feedback are tracked in [docs/requirements-log.md](docs/requirements-log.md):
|
||||||
|
|
||||||
|
- New requirements are added chronologically with dates
|
||||||
|
- Code changes should reference related requirements
|
||||||
|
- Helps maintain project evolution aligned with user needs
|
||||||
|
- Preserves context across conversations and development cycles
|
||||||
|
|
||||||
## Project Structure
|
## Project Structure
|
||||||
|
|
||||||
```
|
```
|
||||||
@@ -42,11 +80,12 @@ src/
|
|||||||
├── core/ # Risk manager (READ-ONLY)
|
├── core/ # Risk manager (READ-ONLY)
|
||||||
├── evolution/ # Self-improvement optimizer
|
├── evolution/ # Self-improvement optimizer
|
||||||
├── markets/ # Market schedules and timezone handling
|
├── markets/ # Market schedules and timezone handling
|
||||||
|
├── notifications/ # Telegram real-time alerts
|
||||||
├── db.py # SQLite trade logging
|
├── db.py # SQLite trade logging
|
||||||
├── main.py # Trading loop orchestrator
|
├── main.py # Trading loop orchestrator
|
||||||
└── config.py # Settings (from .env)
|
└── config.py # Settings (from .env)
|
||||||
|
|
||||||
tests/ # 54 tests across 4 files
|
tests/ # 273 tests across 13 files
|
||||||
docs/ # Extended documentation
|
docs/ # Extended documentation
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|||||||
30
README.md
30
README.md
@@ -29,6 +29,7 @@ KIS(한국투자증권) API로 매매하고, Google Gemini로 판단하며, 자
|
|||||||
| 브로커 | `src/broker/kis_api.py` | KIS API 비동기 래퍼 (토큰 갱신, 레이트 리미터, 해시키) |
|
| 브로커 | `src/broker/kis_api.py` | KIS API 비동기 래퍼 (토큰 갱신, 레이트 리미터, 해시키) |
|
||||||
| 두뇌 | `src/brain/gemini_client.py` | Gemini 프롬프트 구성 및 JSON 응답 파싱 |
|
| 두뇌 | `src/brain/gemini_client.py` | Gemini 프롬프트 구성 및 JSON 응답 파싱 |
|
||||||
| 방패 | `src/core/risk_manager.py` | 서킷 브레이커 + 팻 핑거 체크 |
|
| 방패 | `src/core/risk_manager.py` | 서킷 브레이커 + 팻 핑거 체크 |
|
||||||
|
| 알림 | `src/notifications/telegram_client.py` | 텔레그램 실시간 거래 알림 (선택사항) |
|
||||||
| 진화 | `src/evolution/optimizer.py` | 실패 패턴 분석 → 새 전략 생성 → 테스트 → PR |
|
| 진화 | `src/evolution/optimizer.py` | 실패 패턴 분석 → 새 전략 생성 → 테스트 → PR |
|
||||||
| DB | `src/db.py` | SQLite 거래 로그 기록 |
|
| DB | `src/db.py` | SQLite 거래 로그 기록 |
|
||||||
|
|
||||||
@@ -75,6 +76,34 @@ python -m src.main --mode=paper
|
|||||||
docker compose up -d ouroboros
|
docker compose up -d ouroboros
|
||||||
```
|
```
|
||||||
|
|
||||||
|
## 텔레그램 알림 (선택사항)
|
||||||
|
|
||||||
|
거래 실행, 서킷 브레이커 발동, 시스템 상태 등을 텔레그램으로 실시간 알림 받을 수 있습니다.
|
||||||
|
|
||||||
|
### 빠른 설정
|
||||||
|
|
||||||
|
1. **봇 생성**: 텔레그램에서 [@BotFather](https://t.me/BotFather) 메시지 → `/newbot` 명령
|
||||||
|
2. **채팅 ID 확인**: [@userinfobot](https://t.me/userinfobot) 메시지 → `/start` 명령
|
||||||
|
3. **환경변수 설정**: `.env` 파일에 추가
|
||||||
|
```bash
|
||||||
|
TELEGRAM_BOT_TOKEN=1234567890:ABCdefGHIjklMNOpqrsTUVwxyz
|
||||||
|
TELEGRAM_CHAT_ID=123456789
|
||||||
|
TELEGRAM_ENABLED=true
|
||||||
|
```
|
||||||
|
4. **테스트**: 봇과 대화 시작 (`/start` 전송) 후 에이전트 실행
|
||||||
|
|
||||||
|
**상세 문서**: [src/notifications/README.md](src/notifications/README.md)
|
||||||
|
|
||||||
|
### 알림 종류
|
||||||
|
|
||||||
|
- 🟢 거래 체결 알림 (BUY/SELL + 신뢰도)
|
||||||
|
- 🚨 서킷 브레이커 발동 (자동 거래 중단)
|
||||||
|
- ⚠️ 팻 핑거 차단 (과도한 주문 차단)
|
||||||
|
- ℹ️ 장 시작/종료 알림
|
||||||
|
- 📝 시스템 시작/종료 상태
|
||||||
|
|
||||||
|
**안전장치**: 알림 실패해도 거래는 계속 진행됩니다. 텔레그램 API 오류나 설정 누락이 있어도 거래 시스템은 정상 작동합니다.
|
||||||
|
|
||||||
## 테스트
|
## 테스트
|
||||||
|
|
||||||
35개 테스트가 TDD 방식으로 구현 전에 먼저 작성되었습니다.
|
35개 테스트가 TDD 방식으로 구현 전에 먼저 작성되었습니다.
|
||||||
@@ -111,6 +140,7 @@ The-Ouroboros/
|
|||||||
│ ├── broker/kis_api.py # KIS API 클라이언트
|
│ ├── broker/kis_api.py # KIS API 클라이언트
|
||||||
│ ├── brain/gemini_client.py # Gemini 의사결정 엔진
|
│ ├── brain/gemini_client.py # Gemini 의사결정 엔진
|
||||||
│ ├── core/risk_manager.py # 리스크 관리
|
│ ├── core/risk_manager.py # 리스크 관리
|
||||||
|
│ ├── notifications/telegram_client.py # 텔레그램 알림
|
||||||
│ ├── evolution/optimizer.py # 전략 진화 엔진
|
│ ├── evolution/optimizer.py # 전략 진화 엔진
|
||||||
│ └── strategies/base.py # 전략 베이스 클래스
|
│ └── strategies/base.py # 전략 베이스 클래스
|
||||||
├── tests/ # TDD 테스트 스위트
|
├── tests/ # TDD 테스트 스위트
|
||||||
|
|||||||
@@ -2,7 +2,42 @@
|
|||||||
|
|
||||||
## Overview
|
## Overview
|
||||||
|
|
||||||
Self-evolving AI trading agent for global stock markets via KIS (Korea Investment & Securities) API. The main loop in `src/main.py` orchestrates four components in a 60-second cycle per stock across multiple markets.
|
Self-evolving AI trading agent for global stock markets via KIS (Korea Investment & Securities) API. The main loop in `src/main.py` orchestrates four components across multiple markets with two trading modes: daily (batch API calls) or realtime (per-stock decisions).
|
||||||
|
|
||||||
|
## Trading Modes
|
||||||
|
|
||||||
|
The system supports two trading frequency modes controlled by the `TRADE_MODE` environment variable:
|
||||||
|
|
||||||
|
### Daily Mode (default)
|
||||||
|
|
||||||
|
Optimized for Gemini Free tier API limits (20 calls/day):
|
||||||
|
|
||||||
|
- **Batch decisions**: 1 API call per market per session
|
||||||
|
- **Fixed schedule**: 4 sessions per day at 6-hour intervals (configurable)
|
||||||
|
- **API efficiency**: Processes all stocks in a market simultaneously
|
||||||
|
- **Use case**: Free tier users, cost-conscious deployments
|
||||||
|
- **Configuration**:
|
||||||
|
```bash
|
||||||
|
TRADE_MODE=daily
|
||||||
|
DAILY_SESSIONS=4 # Sessions per day (1-10)
|
||||||
|
SESSION_INTERVAL_HOURS=6 # Hours between sessions (1-24)
|
||||||
|
```
|
||||||
|
|
||||||
|
**Example**: With 2 markets (US, KR) and 4 sessions/day = 8 API calls/day (within 20 call limit)
|
||||||
|
|
||||||
|
### Realtime Mode
|
||||||
|
|
||||||
|
High-frequency trading with individual stock analysis:
|
||||||
|
|
||||||
|
- **Per-stock decisions**: 1 API call per stock per cycle
|
||||||
|
- **60-second interval**: Continuous monitoring
|
||||||
|
- **Use case**: Production deployments with Gemini paid tier
|
||||||
|
- **Configuration**:
|
||||||
|
```bash
|
||||||
|
TRADE_MODE=realtime
|
||||||
|
```
|
||||||
|
|
||||||
|
**Note**: Realtime mode requires Gemini API subscription due to high call volume.
|
||||||
|
|
||||||
## Core Components
|
## Core Components
|
||||||
|
|
||||||
@@ -51,7 +86,26 @@ Self-evolving AI trading agent for global stock markets via KIS (Korea Investmen
|
|||||||
- **Fat-Finger Protection**: Rejects orders exceeding 30% of available cash
|
- **Fat-Finger Protection**: Rejects orders exceeding 30% of available cash
|
||||||
- Must always be enforced, cannot be disabled
|
- Must always be enforced, cannot be disabled
|
||||||
|
|
||||||
### 4. Evolution (`src/evolution/optimizer.py`)
|
### 4. Notifications (`src/notifications/telegram_client.py`)
|
||||||
|
|
||||||
|
**TelegramClient** — Real-time event notifications via Telegram Bot API
|
||||||
|
|
||||||
|
- Sends alerts for trades, circuit breakers, fat-finger rejections, system events
|
||||||
|
- Non-blocking: failures are logged but never crash trading
|
||||||
|
- Rate-limited: 1 message/second default to respect Telegram API limits
|
||||||
|
- Auto-disabled when credentials missing
|
||||||
|
- Gracefully handles API errors, network timeouts, invalid tokens
|
||||||
|
|
||||||
|
**Notification Types:**
|
||||||
|
- Trade execution (BUY/SELL with confidence)
|
||||||
|
- Circuit breaker trips (critical alert)
|
||||||
|
- Fat-finger protection triggers (order rejection)
|
||||||
|
- Market open/close events
|
||||||
|
- System startup/shutdown status
|
||||||
|
|
||||||
|
**Setup:** See [src/notifications/README.md](../src/notifications/README.md) for bot creation and configuration.
|
||||||
|
|
||||||
|
### 5. Evolution (`src/evolution/optimizer.py`)
|
||||||
|
|
||||||
**StrategyOptimizer** — Self-improvement loop
|
**StrategyOptimizer** — Self-improvement loop
|
||||||
|
|
||||||
@@ -115,6 +169,14 @@ Self-evolving AI trading agent for global stock markets via KIS (Korea Investmen
|
|||||||
│
|
│
|
||||||
▼
|
▼
|
||||||
┌──────────────────────────────────┐
|
┌──────────────────────────────────┐
|
||||||
|
│ Notifications: Send Alert │
|
||||||
|
│ - Trade execution notification │
|
||||||
|
│ - Non-blocking (errors logged) │
|
||||||
|
│ - Rate-limited to 1/sec │
|
||||||
|
└──────────────────┬────────────────┘
|
||||||
|
│
|
||||||
|
▼
|
||||||
|
┌──────────────────────────────────┐
|
||||||
│ Database: Log Trade │
|
│ Database: Log Trade │
|
||||||
│ - SQLite (data/trades.db) │
|
│ - SQLite (data/trades.db) │
|
||||||
│ - Track: action, confidence, │
|
│ - Track: action, confidence, │
|
||||||
@@ -164,6 +226,16 @@ CONFIDENCE_THRESHOLD=80
|
|||||||
MAX_LOSS_PCT=3.0
|
MAX_LOSS_PCT=3.0
|
||||||
MAX_ORDER_PCT=30.0
|
MAX_ORDER_PCT=30.0
|
||||||
ENABLED_MARKETS=KR,US_NASDAQ # Comma-separated market codes
|
ENABLED_MARKETS=KR,US_NASDAQ # Comma-separated market codes
|
||||||
|
|
||||||
|
# Trading Mode (API efficiency)
|
||||||
|
TRADE_MODE=daily # daily | realtime
|
||||||
|
DAILY_SESSIONS=4 # Sessions per day (daily mode only)
|
||||||
|
SESSION_INTERVAL_HOURS=6 # Hours between sessions (daily mode only)
|
||||||
|
|
||||||
|
# Telegram Notifications (optional)
|
||||||
|
TELEGRAM_BOT_TOKEN=1234567890:ABCdefGHIjklMNOpqrsTUVwxyz
|
||||||
|
TELEGRAM_CHAT_ID=123456789
|
||||||
|
TELEGRAM_ENABLED=true
|
||||||
```
|
```
|
||||||
|
|
||||||
Tests use in-memory SQLite (`DB_PATH=":memory:"`) and dummy credentials via `tests/conftest.py`.
|
Tests use in-memory SQLite (`DB_PATH=":memory:"`) and dummy credentials via `tests/conftest.py`.
|
||||||
@@ -189,3 +261,12 @@ Tests use in-memory SQLite (`DB_PATH=":memory:"`) and dummy credentials via `tes
|
|||||||
- Wait until next market opens
|
- Wait until next market opens
|
||||||
- Use `get_next_market_open()` to calculate wait time
|
- Use `get_next_market_open()` to calculate wait time
|
||||||
- Sleep until market open time
|
- Sleep until market open time
|
||||||
|
|
||||||
|
### Telegram API Errors
|
||||||
|
- Log warning but continue trading
|
||||||
|
- Missing credentials → auto-disable notifications
|
||||||
|
- Network timeout → skip notification, no retry
|
||||||
|
- Invalid token → log error, trading unaffected
|
||||||
|
- Rate limit exceeded → queued via rate limiter
|
||||||
|
|
||||||
|
**Guarantee**: Notification failures never interrupt trading operations.
|
||||||
|
|||||||
28
docs/requirements-log.md
Normal file
28
docs/requirements-log.md
Normal file
@@ -0,0 +1,28 @@
|
|||||||
|
# Requirements Log
|
||||||
|
|
||||||
|
프로젝트 진화를 위한 사용자 요구사항 기록.
|
||||||
|
|
||||||
|
이 문서는 시간순으로 사용자와의 대화에서 나온 요구사항과 피드백을 기록합니다.
|
||||||
|
새로운 요구사항이 있으면 날짜와 함께 추가하세요.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 2026-02-05
|
||||||
|
|
||||||
|
### API 효율화
|
||||||
|
- Gemini API는 귀중한 자원. 종목별 개별 호출 대신 배치 호출 필요
|
||||||
|
- Free tier 한도(20 calls/day) 고려하여 일일 몇 차례 거래 모드로 전환
|
||||||
|
- 배치 API 호출로 여러 종목을 한 번에 분석
|
||||||
|
|
||||||
|
### 거래 모드
|
||||||
|
- **Daily Mode**: 하루 4회 거래 세션 (6시간 간격) - Free tier 호환
|
||||||
|
- **Realtime Mode**: 60초 간격 실시간 거래 - 유료 구독 필요
|
||||||
|
- `TRADE_MODE` 환경변수로 모드 선택
|
||||||
|
|
||||||
|
### 진화 시스템
|
||||||
|
- 사용자 대화 내용을 문서로 기록하여 향후에도 의도 반영
|
||||||
|
- 프롬프트 품질 검증은 별도 이슈로 다룰 예정
|
||||||
|
|
||||||
|
### 문서화
|
||||||
|
- 시스템 구조, 기능별 설명 등 코드 문서화 항상 신경쓸 것
|
||||||
|
- 새로운 기능 추가 시 관련 문서 업데이트 필수
|
||||||
@@ -42,6 +42,7 @@ class MarketScanner:
|
|||||||
volatility_analyzer: VolatilityAnalyzer,
|
volatility_analyzer: VolatilityAnalyzer,
|
||||||
context_store: ContextStore,
|
context_store: ContextStore,
|
||||||
top_n: int = 5,
|
top_n: int = 5,
|
||||||
|
max_concurrent_scans: int = 1,
|
||||||
) -> None:
|
) -> None:
|
||||||
"""Initialize the market scanner.
|
"""Initialize the market scanner.
|
||||||
|
|
||||||
@@ -51,12 +52,14 @@ class MarketScanner:
|
|||||||
volatility_analyzer: Volatility analyzer instance
|
volatility_analyzer: Volatility analyzer instance
|
||||||
context_store: Context store for L7 real-time data
|
context_store: Context store for L7 real-time data
|
||||||
top_n: Number of top movers to return per market (default 5)
|
top_n: Number of top movers to return per market (default 5)
|
||||||
|
max_concurrent_scans: Max concurrent stock scans (default 1, fully serialized)
|
||||||
"""
|
"""
|
||||||
self.broker = broker
|
self.broker = broker
|
||||||
self.overseas_broker = overseas_broker
|
self.overseas_broker = overseas_broker
|
||||||
self.analyzer = volatility_analyzer
|
self.analyzer = volatility_analyzer
|
||||||
self.context_store = context_store
|
self.context_store = context_store
|
||||||
self.top_n = top_n
|
self.top_n = top_n
|
||||||
|
self._scan_semaphore = asyncio.Semaphore(max_concurrent_scans)
|
||||||
|
|
||||||
async def scan_stock(
|
async def scan_stock(
|
||||||
self,
|
self,
|
||||||
@@ -83,8 +86,8 @@ class MarketScanner:
|
|||||||
# Convert to orderbook-like structure
|
# Convert to orderbook-like structure
|
||||||
orderbook = {
|
orderbook = {
|
||||||
"output1": {
|
"output1": {
|
||||||
"stck_prpr": price_data.get("output", {}).get("last", "0"),
|
"stck_prpr": price_data.get("output", {}).get("last", "0") or "0",
|
||||||
"acml_vol": price_data.get("output", {}).get("tvol", "0"),
|
"acml_vol": price_data.get("output", {}).get("tvol", "0") or "0",
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -139,8 +142,12 @@ class MarketScanner:
|
|||||||
|
|
||||||
logger.info("Scanning %s market (%d stocks)", market.name, len(stock_codes))
|
logger.info("Scanning %s market (%d stocks)", market.name, len(stock_codes))
|
||||||
|
|
||||||
# Scan all stocks concurrently (with rate limiting handled by broker)
|
# Scan stocks with bounded concurrency to prevent API rate limit burst
|
||||||
tasks = [self.scan_stock(code, market) for code in stock_codes]
|
async def _bounded_scan(code: str) -> VolatilityMetrics | None:
|
||||||
|
async with self._scan_semaphore:
|
||||||
|
return await self.scan_stock(code, market)
|
||||||
|
|
||||||
|
tasks = [_bounded_scan(code) for code in stock_codes]
|
||||||
results = await asyncio.gather(*tasks)
|
results = await asyncio.gather(*tasks)
|
||||||
|
|
||||||
# Filter out failures and sort by momentum score
|
# Filter out failures and sort by momentum score
|
||||||
|
|||||||
@@ -525,3 +525,233 @@ class GeminiClient:
|
|||||||
DecisionCache instance or None if caching disabled
|
DecisionCache instance or None if caching disabled
|
||||||
"""
|
"""
|
||||||
return self._cache
|
return self._cache
|
||||||
|
|
||||||
|
# ------------------------------------------------------------------
|
||||||
|
# Batch Decision Making (for daily trading mode)
|
||||||
|
# ------------------------------------------------------------------
|
||||||
|
|
||||||
|
async def decide_batch(
|
||||||
|
self, stocks_data: list[dict[str, Any]]
|
||||||
|
) -> dict[str, TradeDecision]:
|
||||||
|
"""Make decisions for multiple stocks in a single API call.
|
||||||
|
|
||||||
|
This is designed for daily trading mode to minimize API usage
|
||||||
|
when working with Gemini Free tier (20 calls/day limit).
|
||||||
|
|
||||||
|
Args:
|
||||||
|
stocks_data: List of market data dictionaries, each with:
|
||||||
|
- stock_code: Stock ticker
|
||||||
|
- current_price: Current price
|
||||||
|
- market_name: Market name (optional)
|
||||||
|
- foreigner_net: Foreigner net buy/sell (optional)
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
Dictionary mapping stock_code to TradeDecision
|
||||||
|
|
||||||
|
Example:
|
||||||
|
>>> stocks_data = [
|
||||||
|
... {"stock_code": "AAPL", "current_price": 185.5},
|
||||||
|
... {"stock_code": "MSFT", "current_price": 420.0},
|
||||||
|
... ]
|
||||||
|
>>> decisions = await client.decide_batch(stocks_data)
|
||||||
|
>>> decisions["AAPL"].action
|
||||||
|
'BUY'
|
||||||
|
"""
|
||||||
|
if not stocks_data:
|
||||||
|
return {}
|
||||||
|
|
||||||
|
# Build compressed batch prompt
|
||||||
|
market_name = stocks_data[0].get("market_name", "stock market")
|
||||||
|
|
||||||
|
# Format stock data as compact JSON array
|
||||||
|
compact_stocks = []
|
||||||
|
for stock in stocks_data:
|
||||||
|
compact = {
|
||||||
|
"code": stock["stock_code"],
|
||||||
|
"price": stock["current_price"],
|
||||||
|
}
|
||||||
|
if stock.get("foreigner_net", 0) != 0:
|
||||||
|
compact["frgn"] = stock["foreigner_net"]
|
||||||
|
compact_stocks.append(compact)
|
||||||
|
|
||||||
|
data_str = json.dumps(compact_stocks, ensure_ascii=False)
|
||||||
|
|
||||||
|
prompt = (
|
||||||
|
f"You are a professional {market_name} trading analyst.\n"
|
||||||
|
"Analyze the following stocks and decide whether to BUY, SELL, or HOLD each one.\n\n"
|
||||||
|
f"Stock Data: {data_str}\n\n"
|
||||||
|
"You MUST respond with ONLY a valid JSON array in this format:\n"
|
||||||
|
'[{"code": "AAPL", "action": "BUY", "confidence": 85, "rationale": "..."},\n'
|
||||||
|
' {"code": "MSFT", "action": "HOLD", "confidence": 50, "rationale": "..."}, ...]\n\n'
|
||||||
|
"Rules:\n"
|
||||||
|
"- Return one decision object per stock\n"
|
||||||
|
"- action must be exactly: BUY, SELL, or HOLD\n"
|
||||||
|
"- confidence must be 0-100\n"
|
||||||
|
"- rationale should be concise (1-2 sentences)\n"
|
||||||
|
"- Do NOT wrap JSON in markdown code blocks\n"
|
||||||
|
)
|
||||||
|
|
||||||
|
# Estimate tokens
|
||||||
|
token_count = self._optimizer.estimate_tokens(prompt)
|
||||||
|
self._total_tokens_used += token_count
|
||||||
|
|
||||||
|
logger.info(
|
||||||
|
"Requesting batch decision for %d stocks from Gemini",
|
||||||
|
len(stocks_data),
|
||||||
|
extra={"estimated_tokens": token_count},
|
||||||
|
)
|
||||||
|
|
||||||
|
try:
|
||||||
|
response = await self._client.aio.models.generate_content(
|
||||||
|
model=self._model_name,
|
||||||
|
contents=prompt,
|
||||||
|
)
|
||||||
|
raw = response.text
|
||||||
|
except Exception as exc:
|
||||||
|
logger.error("Gemini API error in batch decision: %s", exc)
|
||||||
|
# Return HOLD for all stocks on API error
|
||||||
|
return {
|
||||||
|
stock["stock_code"]: TradeDecision(
|
||||||
|
action="HOLD",
|
||||||
|
confidence=0,
|
||||||
|
rationale=f"API error: {exc}",
|
||||||
|
token_count=token_count,
|
||||||
|
cached=False,
|
||||||
|
)
|
||||||
|
for stock in stocks_data
|
||||||
|
}
|
||||||
|
|
||||||
|
# Parse batch response
|
||||||
|
return self._parse_batch_response(raw, stocks_data, token_count)
|
||||||
|
|
||||||
|
def _parse_batch_response(
|
||||||
|
self, raw: str, stocks_data: list[dict[str, Any]], token_count: int
|
||||||
|
) -> dict[str, TradeDecision]:
|
||||||
|
"""Parse batch response into a dictionary of decisions.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
raw: Raw response from Gemini
|
||||||
|
stocks_data: Original stock data list
|
||||||
|
token_count: Token count for the request
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
Dictionary mapping stock_code to TradeDecision
|
||||||
|
"""
|
||||||
|
if not raw or not raw.strip():
|
||||||
|
logger.warning("Empty batch response from Gemini — defaulting all to HOLD")
|
||||||
|
return {
|
||||||
|
stock["stock_code"]: TradeDecision(
|
||||||
|
action="HOLD",
|
||||||
|
confidence=0,
|
||||||
|
rationale="Empty response",
|
||||||
|
token_count=0,
|
||||||
|
cached=False,
|
||||||
|
)
|
||||||
|
for stock in stocks_data
|
||||||
|
}
|
||||||
|
|
||||||
|
# Strip markdown code fences if present
|
||||||
|
cleaned = raw.strip()
|
||||||
|
match = re.search(r"```(?:json)?\s*\n?(.*?)\n?```", cleaned, re.DOTALL)
|
||||||
|
if match:
|
||||||
|
cleaned = match.group(1).strip()
|
||||||
|
|
||||||
|
try:
|
||||||
|
data = json.loads(cleaned)
|
||||||
|
except json.JSONDecodeError:
|
||||||
|
logger.warning("Malformed JSON in batch response — defaulting all to HOLD")
|
||||||
|
return {
|
||||||
|
stock["stock_code"]: TradeDecision(
|
||||||
|
action="HOLD",
|
||||||
|
confidence=0,
|
||||||
|
rationale="Malformed JSON response",
|
||||||
|
token_count=0,
|
||||||
|
cached=False,
|
||||||
|
)
|
||||||
|
for stock in stocks_data
|
||||||
|
}
|
||||||
|
|
||||||
|
if not isinstance(data, list):
|
||||||
|
logger.warning("Batch response is not a JSON array — defaulting all to HOLD")
|
||||||
|
return {
|
||||||
|
stock["stock_code"]: TradeDecision(
|
||||||
|
action="HOLD",
|
||||||
|
confidence=0,
|
||||||
|
rationale="Invalid response format",
|
||||||
|
token_count=0,
|
||||||
|
cached=False,
|
||||||
|
)
|
||||||
|
for stock in stocks_data
|
||||||
|
}
|
||||||
|
|
||||||
|
# Build decision map
|
||||||
|
decisions: dict[str, TradeDecision] = {}
|
||||||
|
stock_codes = {stock["stock_code"] for stock in stocks_data}
|
||||||
|
|
||||||
|
for item in data:
|
||||||
|
if not isinstance(item, dict):
|
||||||
|
continue
|
||||||
|
|
||||||
|
code = item.get("code")
|
||||||
|
if not code or code not in stock_codes:
|
||||||
|
continue
|
||||||
|
|
||||||
|
# Validate required fields
|
||||||
|
if not all(k in item for k in ("action", "confidence", "rationale")):
|
||||||
|
logger.warning("Missing fields for %s — using HOLD", code)
|
||||||
|
decisions[code] = TradeDecision(
|
||||||
|
action="HOLD",
|
||||||
|
confidence=0,
|
||||||
|
rationale="Missing required fields",
|
||||||
|
token_count=0,
|
||||||
|
cached=False,
|
||||||
|
)
|
||||||
|
continue
|
||||||
|
|
||||||
|
action = str(item["action"]).upper()
|
||||||
|
if action not in VALID_ACTIONS:
|
||||||
|
logger.warning("Invalid action '%s' for %s — forcing HOLD", action, code)
|
||||||
|
action = "HOLD"
|
||||||
|
|
||||||
|
confidence = int(item["confidence"])
|
||||||
|
rationale = str(item["rationale"])
|
||||||
|
|
||||||
|
# Enforce confidence threshold
|
||||||
|
if confidence < self._confidence_threshold:
|
||||||
|
logger.info(
|
||||||
|
"Confidence %d < threshold %d for %s — forcing HOLD",
|
||||||
|
confidence,
|
||||||
|
self._confidence_threshold,
|
||||||
|
code,
|
||||||
|
)
|
||||||
|
action = "HOLD"
|
||||||
|
|
||||||
|
decisions[code] = TradeDecision(
|
||||||
|
action=action,
|
||||||
|
confidence=confidence,
|
||||||
|
rationale=rationale,
|
||||||
|
token_count=token_count // len(stocks_data), # Split token cost
|
||||||
|
cached=False,
|
||||||
|
)
|
||||||
|
self._total_decisions += 1
|
||||||
|
|
||||||
|
# Fill in missing stocks with HOLD
|
||||||
|
for stock in stocks_data:
|
||||||
|
code = stock["stock_code"]
|
||||||
|
if code not in decisions:
|
||||||
|
logger.warning("No decision for %s in batch response — using HOLD", code)
|
||||||
|
decisions[code] = TradeDecision(
|
||||||
|
action="HOLD",
|
||||||
|
confidence=0,
|
||||||
|
rationale="Not found in batch response",
|
||||||
|
token_count=0,
|
||||||
|
cached=False,
|
||||||
|
)
|
||||||
|
|
||||||
|
logger.info(
|
||||||
|
"Batch decision completed for %d stocks",
|
||||||
|
len(decisions),
|
||||||
|
extra={"tokens": token_count},
|
||||||
|
)
|
||||||
|
|
||||||
|
return decisions
|
||||||
|
|||||||
@@ -55,6 +55,9 @@ class KISBroker:
|
|||||||
self._session: aiohttp.ClientSession | None = None
|
self._session: aiohttp.ClientSession | None = None
|
||||||
self._access_token: str | None = None
|
self._access_token: str | None = None
|
||||||
self._token_expires_at: float = 0.0
|
self._token_expires_at: float = 0.0
|
||||||
|
self._token_lock = asyncio.Lock()
|
||||||
|
self._last_refresh_attempt: float = 0.0
|
||||||
|
self._refresh_cooldown: float = 60.0 # Seconds (matches KIS 1/minute limit)
|
||||||
self._rate_limiter = LeakyBucket(settings.RATE_LIMIT_RPS)
|
self._rate_limiter = LeakyBucket(settings.RATE_LIMIT_RPS)
|
||||||
|
|
||||||
def _get_session(self) -> aiohttp.ClientSession:
|
def _get_session(self) -> aiohttp.ClientSession:
|
||||||
@@ -80,12 +83,36 @@ class KISBroker:
|
|||||||
# ------------------------------------------------------------------
|
# ------------------------------------------------------------------
|
||||||
|
|
||||||
async def _ensure_token(self) -> str:
|
async def _ensure_token(self) -> str:
|
||||||
"""Return a valid access token, refreshing if expired."""
|
"""Return a valid access token, refreshing if expired.
|
||||||
|
|
||||||
|
Uses a lock to prevent concurrent token refresh attempts that would
|
||||||
|
hit the API's 1-per-minute rate limit (EGW00133).
|
||||||
|
"""
|
||||||
|
# Fast path: check without lock
|
||||||
now = asyncio.get_event_loop().time()
|
now = asyncio.get_event_loop().time()
|
||||||
if self._access_token and now < self._token_expires_at:
|
if self._access_token and now < self._token_expires_at:
|
||||||
return self._access_token
|
return self._access_token
|
||||||
|
|
||||||
|
# Slow path: acquire lock and refresh
|
||||||
|
async with self._token_lock:
|
||||||
|
# Re-check after acquiring lock (another coroutine may have refreshed)
|
||||||
|
now = asyncio.get_event_loop().time()
|
||||||
|
if self._access_token and now < self._token_expires_at:
|
||||||
|
return self._access_token
|
||||||
|
|
||||||
|
# Check cooldown period (prevents hitting EGW00133: 1/minute limit)
|
||||||
|
time_since_last_attempt = now - self._last_refresh_attempt
|
||||||
|
if time_since_last_attempt < self._refresh_cooldown:
|
||||||
|
remaining = self._refresh_cooldown - time_since_last_attempt
|
||||||
|
error_msg = (
|
||||||
|
f"Token refresh on cooldown. "
|
||||||
|
f"Retry in {remaining:.1f}s (KIS allows 1/minute)"
|
||||||
|
)
|
||||||
|
logger.warning(error_msg)
|
||||||
|
raise ConnectionError(error_msg)
|
||||||
|
|
||||||
logger.info("Refreshing KIS access token")
|
logger.info("Refreshing KIS access token")
|
||||||
|
self._last_refresh_attempt = now
|
||||||
session = self._get_session()
|
session = self._get_session()
|
||||||
url = f"{self._base_url}/oauth2/tokenP"
|
url = f"{self._base_url}/oauth2/tokenP"
|
||||||
body = {
|
body = {
|
||||||
@@ -111,6 +138,7 @@ class KISBroker:
|
|||||||
|
|
||||||
async def _get_hash_key(self, body: dict[str, Any]) -> str:
|
async def _get_hash_key(self, body: dict[str, Any]) -> str:
|
||||||
"""Request a hash key from KIS for POST request body signing."""
|
"""Request a hash key from KIS for POST request body signing."""
|
||||||
|
await self._rate_limiter.acquire()
|
||||||
session = self._get_session()
|
session = self._get_session()
|
||||||
url = f"{self._base_url}/uapi/hashkey"
|
url = f"{self._base_url}/uapi/hashkey"
|
||||||
headers = {
|
headers = {
|
||||||
|
|||||||
@@ -37,11 +37,18 @@ class Settings(BaseSettings):
|
|||||||
DB_PATH: str = "data/trade_logs.db"
|
DB_PATH: str = "data/trade_logs.db"
|
||||||
|
|
||||||
# Rate Limiting (requests per second for KIS API)
|
# Rate Limiting (requests per second for KIS API)
|
||||||
RATE_LIMIT_RPS: float = 10.0
|
# Conservative limit to avoid EGW00201 "초당 거래건수 초과" errors.
|
||||||
|
# KIS API real limit is ~2 RPS; 2.0 provides maximum safety.
|
||||||
|
RATE_LIMIT_RPS: float = 2.0
|
||||||
|
|
||||||
# Trading mode
|
# Trading mode
|
||||||
MODE: str = Field(default="paper", pattern="^(paper|live)$")
|
MODE: str = Field(default="paper", pattern="^(paper|live)$")
|
||||||
|
|
||||||
|
# Trading frequency mode (daily = batch API calls, realtime = per-stock calls)
|
||||||
|
TRADE_MODE: str = Field(default="daily", pattern="^(daily|realtime)$")
|
||||||
|
DAILY_SESSIONS: int = Field(default=4, ge=1, le=10)
|
||||||
|
SESSION_INTERVAL_HOURS: int = Field(default=6, ge=1, le=24)
|
||||||
|
|
||||||
# Market selection (comma-separated market codes)
|
# Market selection (comma-separated market codes)
|
||||||
ENABLED_MARKETS: str = "KR"
|
ENABLED_MARKETS: str = "KR"
|
||||||
|
|
||||||
@@ -54,6 +61,15 @@ class Settings(BaseSettings):
|
|||||||
S3_BUCKET_NAME: str | None = None
|
S3_BUCKET_NAME: str | None = None
|
||||||
S3_REGION: str = "us-east-1"
|
S3_REGION: str = "us-east-1"
|
||||||
|
|
||||||
|
# Telegram Notifications (optional)
|
||||||
|
TELEGRAM_BOT_TOKEN: str | None = None
|
||||||
|
TELEGRAM_CHAT_ID: str | None = None
|
||||||
|
TELEGRAM_ENABLED: bool = True
|
||||||
|
|
||||||
|
# Telegram Commands (optional)
|
||||||
|
TELEGRAM_COMMANDS_ENABLED: bool = True
|
||||||
|
TELEGRAM_POLLING_INTERVAL: float = 1.0 # seconds
|
||||||
|
|
||||||
model_config = {"env_file": ".env", "env_file_encoding": "utf-8"}
|
model_config = {"env_file": ".env", "env_file_encoding": "utf-8"}
|
||||||
|
|
||||||
@property
|
@property
|
||||||
|
|||||||
571
src/main.py
571
src/main.py
@@ -10,6 +10,7 @@ import argparse
|
|||||||
import asyncio
|
import asyncio
|
||||||
import logging
|
import logging
|
||||||
import signal
|
import signal
|
||||||
|
import sys
|
||||||
from datetime import UTC, datetime
|
from datetime import UTC, datetime
|
||||||
from typing import Any
|
from typing import Any
|
||||||
|
|
||||||
@@ -23,14 +24,44 @@ from src.context.layer import ContextLayer
|
|||||||
from src.context.store import ContextStore
|
from src.context.store import ContextStore
|
||||||
from src.core.criticality import CriticalityAssessor
|
from src.core.criticality import CriticalityAssessor
|
||||||
from src.core.priority_queue import PriorityTaskQueue
|
from src.core.priority_queue import PriorityTaskQueue
|
||||||
from src.core.risk_manager import CircuitBreakerTripped, RiskManager
|
from src.core.risk_manager import CircuitBreakerTripped, FatFingerRejected, RiskManager
|
||||||
from src.db import init_db, log_trade
|
from src.db import init_db, log_trade
|
||||||
from src.logging.decision_logger import DecisionLogger
|
from src.logging.decision_logger import DecisionLogger
|
||||||
from src.logging_config import setup_logging
|
from src.logging_config import setup_logging
|
||||||
from src.markets.schedule import MarketInfo, get_next_market_open, get_open_markets
|
from src.markets.schedule import MarketInfo, get_next_market_open, get_open_markets
|
||||||
|
from src.notifications.telegram_client import TelegramClient, TelegramCommandHandler
|
||||||
|
|
||||||
logger = logging.getLogger(__name__)
|
logger = logging.getLogger(__name__)
|
||||||
|
|
||||||
|
|
||||||
|
def safe_float(value: str | float | None, default: float = 0.0) -> float:
|
||||||
|
"""Convert to float, handling empty strings and None.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
value: Value to convert (string, float, or None)
|
||||||
|
default: Default value if conversion fails
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
Converted float or default value
|
||||||
|
|
||||||
|
Examples:
|
||||||
|
>>> safe_float("123.45")
|
||||||
|
123.45
|
||||||
|
>>> safe_float("")
|
||||||
|
0.0
|
||||||
|
>>> safe_float(None)
|
||||||
|
0.0
|
||||||
|
>>> safe_float("invalid", 99.0)
|
||||||
|
99.0
|
||||||
|
"""
|
||||||
|
if value is None or value == "":
|
||||||
|
return default
|
||||||
|
try:
|
||||||
|
return float(value)
|
||||||
|
except (ValueError, TypeError):
|
||||||
|
return default
|
||||||
|
|
||||||
|
|
||||||
# Target stock codes to monitor per market
|
# Target stock codes to monitor per market
|
||||||
WATCHLISTS = {
|
WATCHLISTS = {
|
||||||
"KR": ["005930", "000660", "035420"], # Samsung, SK Hynix, NAVER
|
"KR": ["005930", "000660", "035420"], # Samsung, SK Hynix, NAVER
|
||||||
@@ -43,6 +74,10 @@ TRADE_INTERVAL_SECONDS = 60
|
|||||||
SCAN_INTERVAL_SECONDS = 60 # Scan markets every 60 seconds
|
SCAN_INTERVAL_SECONDS = 60 # Scan markets every 60 seconds
|
||||||
MAX_CONNECTION_RETRIES = 3
|
MAX_CONNECTION_RETRIES = 3
|
||||||
|
|
||||||
|
# Daily trading mode constants (for Free tier API efficiency)
|
||||||
|
DAILY_TRADE_SESSIONS = 4 # Number of trading sessions per day
|
||||||
|
TRADE_SESSION_INTERVAL_HOURS = 6 # Hours between sessions
|
||||||
|
|
||||||
# Full stock universe per market (for scanning)
|
# Full stock universe per market (for scanning)
|
||||||
# In production, this would be loaded from a database or API
|
# In production, this would be loaded from a database or API
|
||||||
STOCK_UNIVERSE = {
|
STOCK_UNIVERSE = {
|
||||||
@@ -62,6 +97,7 @@ async def trading_cycle(
|
|||||||
decision_logger: DecisionLogger,
|
decision_logger: DecisionLogger,
|
||||||
context_store: ContextStore,
|
context_store: ContextStore,
|
||||||
criticality_assessor: CriticalityAssessor,
|
criticality_assessor: CriticalityAssessor,
|
||||||
|
telegram: TelegramClient,
|
||||||
market: MarketInfo,
|
market: MarketInfo,
|
||||||
stock_code: str,
|
stock_code: str,
|
||||||
) -> None:
|
) -> None:
|
||||||
@@ -74,16 +110,16 @@ async def trading_cycle(
|
|||||||
balance_data = await broker.get_balance()
|
balance_data = await broker.get_balance()
|
||||||
|
|
||||||
output2 = balance_data.get("output2", [{}])
|
output2 = balance_data.get("output2", [{}])
|
||||||
total_eval = float(output2[0].get("tot_evlu_amt", "0")) if output2 else 0
|
total_eval = safe_float(output2[0].get("tot_evlu_amt", "0")) if output2 else 0
|
||||||
total_cash = float(
|
total_cash = safe_float(
|
||||||
balance_data.get("output2", [{}])[0].get("dnca_tot_amt", "0")
|
balance_data.get("output2", [{}])[0].get("dnca_tot_amt", "0")
|
||||||
if output2
|
if output2
|
||||||
else "0"
|
else "0"
|
||||||
)
|
)
|
||||||
purchase_total = float(output2[0].get("pchs_amt_smtl_amt", "0")) if output2 else 0
|
purchase_total = safe_float(output2[0].get("pchs_amt_smtl_amt", "0")) if output2 else 0
|
||||||
|
|
||||||
current_price = float(orderbook.get("output1", {}).get("stck_prpr", "0"))
|
current_price = safe_float(orderbook.get("output1", {}).get("stck_prpr", "0"))
|
||||||
foreigner_net = float(orderbook.get("output1", {}).get("frgn_ntby_qty", "0"))
|
foreigner_net = safe_float(orderbook.get("output1", {}).get("frgn_ntby_qty", "0"))
|
||||||
else:
|
else:
|
||||||
# Overseas market
|
# Overseas market
|
||||||
price_data = await overseas_broker.get_overseas_price(
|
price_data = await overseas_broker.get_overseas_price(
|
||||||
@@ -92,11 +128,19 @@ async def trading_cycle(
|
|||||||
balance_data = await overseas_broker.get_overseas_balance(market.exchange_code)
|
balance_data = await overseas_broker.get_overseas_balance(market.exchange_code)
|
||||||
|
|
||||||
output2 = balance_data.get("output2", [{}])
|
output2 = balance_data.get("output2", [{}])
|
||||||
total_eval = float(output2[0].get("frcr_evlu_tota", "0")) if output2 else 0
|
# Handle both list and dict response formats
|
||||||
total_cash = float(output2[0].get("frcr_dncl_amt_2", "0")) if output2 else 0
|
if isinstance(output2, list) and output2:
|
||||||
purchase_total = float(output2[0].get("frcr_buy_amt_smtl", "0")) if output2 else 0
|
balance_info = output2[0]
|
||||||
|
elif isinstance(output2, dict):
|
||||||
|
balance_info = output2
|
||||||
|
else:
|
||||||
|
balance_info = {}
|
||||||
|
|
||||||
current_price = float(price_data.get("output", {}).get("last", "0"))
|
total_eval = safe_float(balance_info.get("frcr_evlu_tota", "0") or "0")
|
||||||
|
total_cash = safe_float(balance_info.get("frcr_dncl_amt_2", "0") or "0")
|
||||||
|
purchase_total = safe_float(balance_info.get("frcr_buy_amt_smtl", "0") or "0")
|
||||||
|
|
||||||
|
current_price = safe_float(price_data.get("output", {}).get("last", "0"))
|
||||||
foreigner_net = 0.0 # Not available for overseas
|
foreigner_net = 0.0 # Not available for overseas
|
||||||
|
|
||||||
# Calculate daily P&L %
|
# Calculate daily P&L %
|
||||||
@@ -199,11 +243,23 @@ async def trading_cycle(
|
|||||||
order_amount = current_price * quantity
|
order_amount = current_price * quantity
|
||||||
|
|
||||||
# 4. Risk check BEFORE order
|
# 4. Risk check BEFORE order
|
||||||
|
try:
|
||||||
risk.validate_order(
|
risk.validate_order(
|
||||||
current_pnl_pct=pnl_pct,
|
current_pnl_pct=pnl_pct,
|
||||||
order_amount=order_amount,
|
order_amount=order_amount,
|
||||||
total_cash=total_cash,
|
total_cash=total_cash,
|
||||||
)
|
)
|
||||||
|
except FatFingerRejected as exc:
|
||||||
|
try:
|
||||||
|
await telegram.notify_fat_finger(
|
||||||
|
stock_code=stock_code,
|
||||||
|
order_amount=exc.order_amount,
|
||||||
|
total_cash=exc.total_cash,
|
||||||
|
max_pct=exc.max_pct,
|
||||||
|
)
|
||||||
|
except Exception as notify_exc:
|
||||||
|
logger.warning("Fat finger notification failed: %s", notify_exc)
|
||||||
|
raise # Re-raise to prevent trade
|
||||||
|
|
||||||
# 5. Send order
|
# 5. Send order
|
||||||
if market.is_domestic:
|
if market.is_domestic:
|
||||||
@@ -223,6 +279,19 @@ async def trading_cycle(
|
|||||||
)
|
)
|
||||||
logger.info("Order result: %s", result.get("msg1", "OK"))
|
logger.info("Order result: %s", result.get("msg1", "OK"))
|
||||||
|
|
||||||
|
# 5.5. Notify trade execution
|
||||||
|
try:
|
||||||
|
await telegram.notify_trade_execution(
|
||||||
|
stock_code=stock_code,
|
||||||
|
market=market.name,
|
||||||
|
action=decision.action,
|
||||||
|
quantity=quantity,
|
||||||
|
price=current_price,
|
||||||
|
confidence=decision.confidence,
|
||||||
|
)
|
||||||
|
except Exception as exc:
|
||||||
|
logger.warning("Telegram notification failed: %s", exc)
|
||||||
|
|
||||||
# 6. Log trade
|
# 6. Log trade
|
||||||
log_trade(
|
log_trade(
|
||||||
conn=db_conn,
|
conn=db_conn,
|
||||||
@@ -256,6 +325,239 @@ async def trading_cycle(
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
async def run_daily_session(
|
||||||
|
broker: KISBroker,
|
||||||
|
overseas_broker: OverseasBroker,
|
||||||
|
brain: GeminiClient,
|
||||||
|
risk: RiskManager,
|
||||||
|
db_conn: Any,
|
||||||
|
decision_logger: DecisionLogger,
|
||||||
|
context_store: ContextStore,
|
||||||
|
criticality_assessor: CriticalityAssessor,
|
||||||
|
telegram: TelegramClient,
|
||||||
|
settings: Settings,
|
||||||
|
) -> None:
|
||||||
|
"""Execute one daily trading session.
|
||||||
|
|
||||||
|
Designed for API efficiency with Gemini Free tier:
|
||||||
|
- Batch decision making (1 API call per market)
|
||||||
|
- Runs N times per day at fixed intervals
|
||||||
|
- Minimizes API usage while maintaining trading capability
|
||||||
|
"""
|
||||||
|
# Get currently open markets
|
||||||
|
open_markets = get_open_markets(settings.enabled_market_list)
|
||||||
|
|
||||||
|
if not open_markets:
|
||||||
|
logger.info("No markets open for this session")
|
||||||
|
return
|
||||||
|
|
||||||
|
logger.info("Starting daily trading session for %d markets", len(open_markets))
|
||||||
|
|
||||||
|
# Process each open market
|
||||||
|
for market in open_markets:
|
||||||
|
# Get watchlist for this market
|
||||||
|
watchlist = WATCHLISTS.get(market.code, [])
|
||||||
|
if not watchlist:
|
||||||
|
logger.debug("No watchlist for market %s", market.code)
|
||||||
|
continue
|
||||||
|
|
||||||
|
logger.info("Processing market: %s (%d stocks)", market.name, len(watchlist))
|
||||||
|
|
||||||
|
# Collect market data for all stocks in the watchlist
|
||||||
|
stocks_data = []
|
||||||
|
for stock_code in watchlist:
|
||||||
|
try:
|
||||||
|
if market.is_domestic:
|
||||||
|
orderbook = await broker.get_orderbook(stock_code)
|
||||||
|
current_price = safe_float(orderbook.get("output1", {}).get("stck_prpr", "0"))
|
||||||
|
foreigner_net = safe_float(
|
||||||
|
orderbook.get("output1", {}).get("frgn_ntby_qty", "0")
|
||||||
|
)
|
||||||
|
else:
|
||||||
|
price_data = await overseas_broker.get_overseas_price(
|
||||||
|
market.exchange_code, stock_code
|
||||||
|
)
|
||||||
|
current_price = safe_float(price_data.get("output", {}).get("last", "0"))
|
||||||
|
foreigner_net = 0.0
|
||||||
|
|
||||||
|
stocks_data.append(
|
||||||
|
{
|
||||||
|
"stock_code": stock_code,
|
||||||
|
"market_name": market.name,
|
||||||
|
"current_price": current_price,
|
||||||
|
"foreigner_net": foreigner_net,
|
||||||
|
}
|
||||||
|
)
|
||||||
|
except Exception as exc:
|
||||||
|
logger.error("Failed to fetch data for %s: %s", stock_code, exc)
|
||||||
|
continue
|
||||||
|
|
||||||
|
if not stocks_data:
|
||||||
|
logger.warning("No valid stock data for market %s", market.code)
|
||||||
|
continue
|
||||||
|
|
||||||
|
# Get batch decisions (1 API call for all stocks in this market)
|
||||||
|
logger.info("Requesting batch decision for %d stocks in %s", len(stocks_data), market.name)
|
||||||
|
decisions = await brain.decide_batch(stocks_data)
|
||||||
|
|
||||||
|
# Get balance data once for the market
|
||||||
|
if market.is_domestic:
|
||||||
|
balance_data = await broker.get_balance()
|
||||||
|
output2 = balance_data.get("output2", [{}])
|
||||||
|
total_eval = safe_float(output2[0].get("tot_evlu_amt", "0")) if output2 else 0
|
||||||
|
total_cash = safe_float(output2[0].get("dnca_tot_amt", "0")) if output2 else 0
|
||||||
|
purchase_total = safe_float(output2[0].get("pchs_amt_smtl_amt", "0")) if output2 else 0
|
||||||
|
else:
|
||||||
|
balance_data = await overseas_broker.get_overseas_balance(market.exchange_code)
|
||||||
|
output2 = balance_data.get("output2", [{}])
|
||||||
|
if isinstance(output2, list) and output2:
|
||||||
|
balance_info = output2[0]
|
||||||
|
elif isinstance(output2, dict):
|
||||||
|
balance_info = output2
|
||||||
|
else:
|
||||||
|
balance_info = {}
|
||||||
|
|
||||||
|
total_eval = safe_float(balance_info.get("frcr_evlu_tota", "0") or "0")
|
||||||
|
total_cash = safe_float(balance_info.get("frcr_dncl_amt_2", "0") or "0")
|
||||||
|
purchase_total = safe_float(balance_info.get("frcr_buy_amt_smtl", "0") or "0")
|
||||||
|
|
||||||
|
# Calculate daily P&L %
|
||||||
|
pnl_pct = (
|
||||||
|
((total_eval - purchase_total) / purchase_total * 100) if purchase_total > 0 else 0.0
|
||||||
|
)
|
||||||
|
|
||||||
|
# Execute decisions for each stock
|
||||||
|
for stock_data in stocks_data:
|
||||||
|
stock_code = stock_data["stock_code"]
|
||||||
|
decision = decisions.get(stock_code)
|
||||||
|
|
||||||
|
if not decision:
|
||||||
|
logger.warning("No decision for %s — skipping", stock_code)
|
||||||
|
continue
|
||||||
|
|
||||||
|
logger.info(
|
||||||
|
"Decision for %s (%s): %s (confidence=%d)",
|
||||||
|
stock_code,
|
||||||
|
market.name,
|
||||||
|
decision.action,
|
||||||
|
decision.confidence,
|
||||||
|
)
|
||||||
|
|
||||||
|
# Log decision
|
||||||
|
context_snapshot = {
|
||||||
|
"L1": {
|
||||||
|
"current_price": stock_data["current_price"],
|
||||||
|
"foreigner_net": stock_data["foreigner_net"],
|
||||||
|
},
|
||||||
|
"L2": {
|
||||||
|
"total_eval": total_eval,
|
||||||
|
"total_cash": total_cash,
|
||||||
|
"purchase_total": purchase_total,
|
||||||
|
"pnl_pct": pnl_pct,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
input_data = {
|
||||||
|
"current_price": stock_data["current_price"],
|
||||||
|
"foreigner_net": stock_data["foreigner_net"],
|
||||||
|
"total_eval": total_eval,
|
||||||
|
"total_cash": total_cash,
|
||||||
|
"pnl_pct": pnl_pct,
|
||||||
|
}
|
||||||
|
|
||||||
|
decision_logger.log_decision(
|
||||||
|
stock_code=stock_code,
|
||||||
|
market=market.code,
|
||||||
|
exchange_code=market.exchange_code,
|
||||||
|
action=decision.action,
|
||||||
|
confidence=decision.confidence,
|
||||||
|
rationale=decision.rationale,
|
||||||
|
context_snapshot=context_snapshot,
|
||||||
|
input_data=input_data,
|
||||||
|
)
|
||||||
|
|
||||||
|
# Execute if actionable
|
||||||
|
if decision.action in ("BUY", "SELL"):
|
||||||
|
quantity = 1
|
||||||
|
order_amount = stock_data["current_price"] * quantity
|
||||||
|
|
||||||
|
# Risk check
|
||||||
|
try:
|
||||||
|
risk.validate_order(
|
||||||
|
current_pnl_pct=pnl_pct,
|
||||||
|
order_amount=order_amount,
|
||||||
|
total_cash=total_cash,
|
||||||
|
)
|
||||||
|
except FatFingerRejected as exc:
|
||||||
|
try:
|
||||||
|
await telegram.notify_fat_finger(
|
||||||
|
stock_code=stock_code,
|
||||||
|
order_amount=exc.order_amount,
|
||||||
|
total_cash=exc.total_cash,
|
||||||
|
max_pct=exc.max_pct,
|
||||||
|
)
|
||||||
|
except Exception as notify_exc:
|
||||||
|
logger.warning("Fat finger notification failed: %s", notify_exc)
|
||||||
|
continue # Skip this order
|
||||||
|
except CircuitBreakerTripped as exc:
|
||||||
|
logger.critical("Circuit breaker tripped — stopping session")
|
||||||
|
try:
|
||||||
|
await telegram.notify_circuit_breaker(
|
||||||
|
pnl_pct=exc.pnl_pct,
|
||||||
|
threshold=exc.threshold,
|
||||||
|
)
|
||||||
|
except Exception as notify_exc:
|
||||||
|
logger.warning("Circuit breaker notification failed: %s", notify_exc)
|
||||||
|
raise
|
||||||
|
|
||||||
|
# Send order
|
||||||
|
try:
|
||||||
|
if market.is_domestic:
|
||||||
|
result = await broker.send_order(
|
||||||
|
stock_code=stock_code,
|
||||||
|
order_type=decision.action,
|
||||||
|
quantity=quantity,
|
||||||
|
price=0, # market order
|
||||||
|
)
|
||||||
|
else:
|
||||||
|
result = await overseas_broker.send_overseas_order(
|
||||||
|
exchange_code=market.exchange_code,
|
||||||
|
stock_code=stock_code,
|
||||||
|
order_type=decision.action,
|
||||||
|
quantity=quantity,
|
||||||
|
price=0.0, # market order
|
||||||
|
)
|
||||||
|
logger.info("Order result: %s", result.get("msg1", "OK"))
|
||||||
|
|
||||||
|
# Notify trade execution
|
||||||
|
try:
|
||||||
|
await telegram.notify_trade_execution(
|
||||||
|
stock_code=stock_code,
|
||||||
|
market=market.name,
|
||||||
|
action=decision.action,
|
||||||
|
quantity=quantity,
|
||||||
|
price=stock_data["current_price"],
|
||||||
|
confidence=decision.confidence,
|
||||||
|
)
|
||||||
|
except Exception as exc:
|
||||||
|
logger.warning("Telegram notification failed: %s", exc)
|
||||||
|
except Exception as exc:
|
||||||
|
logger.error("Order execution failed for %s: %s", stock_code, exc)
|
||||||
|
continue
|
||||||
|
|
||||||
|
# Log trade
|
||||||
|
log_trade(
|
||||||
|
conn=db_conn,
|
||||||
|
stock_code=stock_code,
|
||||||
|
action=decision.action,
|
||||||
|
confidence=decision.confidence,
|
||||||
|
rationale=decision.rationale,
|
||||||
|
market=market.code,
|
||||||
|
exchange_code=market.exchange_code,
|
||||||
|
)
|
||||||
|
|
||||||
|
logger.info("Daily trading session completed")
|
||||||
|
|
||||||
|
|
||||||
async def run(settings: Settings) -> None:
|
async def run(settings: Settings) -> None:
|
||||||
"""Main async loop — iterate over open markets on a timer."""
|
"""Main async loop — iterate over open markets on a timer."""
|
||||||
broker = KISBroker(settings)
|
broker = KISBroker(settings)
|
||||||
@@ -266,6 +568,149 @@ async def run(settings: Settings) -> None:
|
|||||||
decision_logger = DecisionLogger(db_conn)
|
decision_logger = DecisionLogger(db_conn)
|
||||||
context_store = ContextStore(db_conn)
|
context_store = ContextStore(db_conn)
|
||||||
|
|
||||||
|
# Initialize Telegram notifications
|
||||||
|
telegram = TelegramClient(
|
||||||
|
bot_token=settings.TELEGRAM_BOT_TOKEN,
|
||||||
|
chat_id=settings.TELEGRAM_CHAT_ID,
|
||||||
|
enabled=settings.TELEGRAM_ENABLED,
|
||||||
|
)
|
||||||
|
|
||||||
|
# Initialize Telegram command handler
|
||||||
|
command_handler = TelegramCommandHandler(telegram)
|
||||||
|
|
||||||
|
# Register basic commands
|
||||||
|
async def handle_help() -> None:
|
||||||
|
"""Handle /help command."""
|
||||||
|
message = (
|
||||||
|
"<b>📖 Available Commands</b>\n\n"
|
||||||
|
"/help - Show available commands\n"
|
||||||
|
"/status - Trading status (mode, markets, P&L)\n"
|
||||||
|
"/positions - Current holdings\n"
|
||||||
|
"/stop - Pause trading\n"
|
||||||
|
"/resume - Resume trading"
|
||||||
|
)
|
||||||
|
await telegram.send_message(message)
|
||||||
|
|
||||||
|
async def handle_stop() -> None:
|
||||||
|
"""Handle /stop command - pause trading."""
|
||||||
|
if not pause_trading.is_set():
|
||||||
|
await telegram.send_message("⏸️ Trading is already paused")
|
||||||
|
return
|
||||||
|
|
||||||
|
pause_trading.clear()
|
||||||
|
logger.info("Trading paused via Telegram command")
|
||||||
|
await telegram.send_message(
|
||||||
|
"<b>⏸️ Trading Paused</b>\n\n"
|
||||||
|
"All trading operations have been suspended.\n"
|
||||||
|
"Use /resume to restart trading."
|
||||||
|
)
|
||||||
|
|
||||||
|
async def handle_resume() -> None:
|
||||||
|
"""Handle /resume command - resume trading."""
|
||||||
|
if pause_trading.is_set():
|
||||||
|
await telegram.send_message("▶️ Trading is already active")
|
||||||
|
return
|
||||||
|
|
||||||
|
pause_trading.set()
|
||||||
|
logger.info("Trading resumed via Telegram command")
|
||||||
|
await telegram.send_message(
|
||||||
|
"<b>▶️ Trading Resumed</b>\n\n"
|
||||||
|
"Trading operations have been restarted."
|
||||||
|
)
|
||||||
|
|
||||||
|
async def handle_status() -> None:
|
||||||
|
"""Handle /status command - show trading status."""
|
||||||
|
try:
|
||||||
|
# Get trading status
|
||||||
|
trading_status = "Active" if pause_trading.is_set() else "Paused"
|
||||||
|
|
||||||
|
# Calculate P&L from balance data
|
||||||
|
try:
|
||||||
|
balance = await broker.get_balance()
|
||||||
|
output2 = balance.get("output2", [{}])
|
||||||
|
if output2:
|
||||||
|
total_eval = safe_float(output2[0].get("tot_evlu_amt", "0"))
|
||||||
|
purchase_total = safe_float(output2[0].get("pchs_amt_smtl_amt", "0"))
|
||||||
|
current_pnl = (
|
||||||
|
((total_eval - purchase_total) / purchase_total * 100)
|
||||||
|
if purchase_total > 0
|
||||||
|
else 0.0
|
||||||
|
)
|
||||||
|
pnl_str = f"{current_pnl:+.2f}%"
|
||||||
|
else:
|
||||||
|
pnl_str = "N/A"
|
||||||
|
except Exception as exc:
|
||||||
|
logger.warning("Failed to get P&L: %s", exc)
|
||||||
|
pnl_str = "N/A"
|
||||||
|
|
||||||
|
# Format market list
|
||||||
|
markets_str = ", ".join(settings.enabled_market_list)
|
||||||
|
|
||||||
|
message = (
|
||||||
|
"<b>📊 Trading Status</b>\n\n"
|
||||||
|
f"<b>Mode:</b> {settings.MODE.upper()}\n"
|
||||||
|
f"<b>Markets:</b> {markets_str}\n"
|
||||||
|
f"<b>Trading:</b> {trading_status}\n\n"
|
||||||
|
f"<b>Current P&L:</b> {pnl_str}\n"
|
||||||
|
f"<b>Circuit Breaker:</b> {risk._cb_threshold:.1f}%"
|
||||||
|
)
|
||||||
|
await telegram.send_message(message)
|
||||||
|
|
||||||
|
except Exception as exc:
|
||||||
|
logger.error("Error in /status handler: %s", exc)
|
||||||
|
await telegram.send_message(
|
||||||
|
"<b>⚠️ Error</b>\n\nFailed to retrieve trading status."
|
||||||
|
)
|
||||||
|
|
||||||
|
async def handle_positions() -> None:
|
||||||
|
"""Handle /positions command - show account summary."""
|
||||||
|
try:
|
||||||
|
# Get account balance
|
||||||
|
balance = await broker.get_balance()
|
||||||
|
output2 = balance.get("output2", [{}])
|
||||||
|
|
||||||
|
if not output2:
|
||||||
|
await telegram.send_message(
|
||||||
|
"<b>💼 Account Summary</b>\n\n"
|
||||||
|
"No balance information available."
|
||||||
|
)
|
||||||
|
return
|
||||||
|
|
||||||
|
# Extract account-level data
|
||||||
|
total_eval = safe_float(output2[0].get("tot_evlu_amt", "0"))
|
||||||
|
total_cash = safe_float(output2[0].get("dnca_tot_amt", "0"))
|
||||||
|
purchase_total = safe_float(output2[0].get("pchs_amt_smtl_amt", "0"))
|
||||||
|
|
||||||
|
# Calculate P&L
|
||||||
|
pnl_pct = (
|
||||||
|
((total_eval - purchase_total) / purchase_total * 100)
|
||||||
|
if purchase_total > 0
|
||||||
|
else 0.0
|
||||||
|
)
|
||||||
|
pnl_sign = "+" if pnl_pct >= 0 else ""
|
||||||
|
|
||||||
|
message = (
|
||||||
|
"<b>💼 Account Summary</b>\n\n"
|
||||||
|
f"<b>Total Evaluation:</b> ₩{total_eval:,.0f}\n"
|
||||||
|
f"<b>Available Cash:</b> ₩{total_cash:,.0f}\n"
|
||||||
|
f"<b>Purchase Total:</b> ₩{purchase_total:,.0f}\n"
|
||||||
|
f"<b>P&L:</b> {pnl_sign}{pnl_pct:.2f}%\n\n"
|
||||||
|
"<i>Note: Individual position details require API enhancement</i>"
|
||||||
|
)
|
||||||
|
await telegram.send_message(message)
|
||||||
|
|
||||||
|
except Exception as exc:
|
||||||
|
logger.error("Error in /positions handler: %s", exc)
|
||||||
|
await telegram.send_message(
|
||||||
|
"<b>⚠️ Error</b>\n\nFailed to retrieve positions."
|
||||||
|
)
|
||||||
|
|
||||||
|
command_handler.register_command("help", handle_help)
|
||||||
|
command_handler.register_command("stop", handle_stop)
|
||||||
|
command_handler.register_command("resume", handle_resume)
|
||||||
|
command_handler.register_command("status", handle_status)
|
||||||
|
command_handler.register_command("positions", handle_positions)
|
||||||
|
|
||||||
# Initialize volatility hunter
|
# Initialize volatility hunter
|
||||||
volatility_analyzer = VolatilityAnalyzer(min_volume_surge=2.0, min_price_change=1.0)
|
volatility_analyzer = VolatilityAnalyzer(min_volume_surge=2.0, min_price_change=1.0)
|
||||||
market_scanner = MarketScanner(
|
market_scanner = MarketScanner(
|
||||||
@@ -274,6 +719,7 @@ async def run(settings: Settings) -> None:
|
|||||||
volatility_analyzer=volatility_analyzer,
|
volatility_analyzer=volatility_analyzer,
|
||||||
context_store=context_store,
|
context_store=context_store,
|
||||||
top_n=5,
|
top_n=5,
|
||||||
|
max_concurrent_scans=1, # Fully serialized to avoid EGW00201
|
||||||
)
|
)
|
||||||
|
|
||||||
# Initialize latency control system
|
# Initialize latency control system
|
||||||
@@ -289,7 +735,13 @@ async def run(settings: Settings) -> None:
|
|||||||
# Track last scan time for each market
|
# Track last scan time for each market
|
||||||
last_scan_time: dict[str, float] = {}
|
last_scan_time: dict[str, float] = {}
|
||||||
|
|
||||||
|
# Track market open/close state for notifications
|
||||||
|
_market_states: dict[str, bool] = {} # market_code -> is_open
|
||||||
|
|
||||||
|
# Trading control events
|
||||||
shutdown = asyncio.Event()
|
shutdown = asyncio.Event()
|
||||||
|
pause_trading = asyncio.Event()
|
||||||
|
pause_trading.set() # Default: trading enabled
|
||||||
|
|
||||||
def _signal_handler() -> None:
|
def _signal_handler() -> None:
|
||||||
logger.info("Shutdown signal received")
|
logger.info("Shutdown signal received")
|
||||||
@@ -299,15 +751,89 @@ async def run(settings: Settings) -> None:
|
|||||||
for sig in (signal.SIGINT, signal.SIGTERM):
|
for sig in (signal.SIGINT, signal.SIGTERM):
|
||||||
loop.add_signal_handler(sig, _signal_handler)
|
loop.add_signal_handler(sig, _signal_handler)
|
||||||
|
|
||||||
logger.info("The Ouroboros is alive. Mode: %s", settings.MODE)
|
logger.info("The Ouroboros is alive. Mode: %s, Trading: %s", settings.MODE, settings.TRADE_MODE)
|
||||||
logger.info("Enabled markets: %s", settings.enabled_market_list)
|
logger.info("Enabled markets: %s", settings.enabled_market_list)
|
||||||
|
|
||||||
|
# Notify system startup
|
||||||
try:
|
try:
|
||||||
|
await telegram.notify_system_start(settings.MODE, settings.enabled_market_list)
|
||||||
|
except Exception as exc:
|
||||||
|
logger.warning("System startup notification failed: %s", exc)
|
||||||
|
|
||||||
|
# Start command handler
|
||||||
|
try:
|
||||||
|
await command_handler.start_polling()
|
||||||
|
except Exception as exc:
|
||||||
|
logger.warning("Failed to start command handler: %s", exc)
|
||||||
|
|
||||||
|
try:
|
||||||
|
# Branch based on trading mode
|
||||||
|
if settings.TRADE_MODE == "daily":
|
||||||
|
# Daily trading mode: batch decisions at fixed intervals
|
||||||
|
logger.info(
|
||||||
|
"Daily trading mode: %d sessions every %d hours",
|
||||||
|
settings.DAILY_SESSIONS,
|
||||||
|
settings.SESSION_INTERVAL_HOURS,
|
||||||
|
)
|
||||||
|
|
||||||
|
session_interval = settings.SESSION_INTERVAL_HOURS * 3600 # Convert to seconds
|
||||||
|
|
||||||
while not shutdown.is_set():
|
while not shutdown.is_set():
|
||||||
|
# Wait for trading to be unpaused
|
||||||
|
await pause_trading.wait()
|
||||||
|
|
||||||
|
try:
|
||||||
|
await run_daily_session(
|
||||||
|
broker,
|
||||||
|
overseas_broker,
|
||||||
|
brain,
|
||||||
|
risk,
|
||||||
|
db_conn,
|
||||||
|
decision_logger,
|
||||||
|
context_store,
|
||||||
|
criticality_assessor,
|
||||||
|
telegram,
|
||||||
|
settings,
|
||||||
|
)
|
||||||
|
except CircuitBreakerTripped:
|
||||||
|
logger.critical("Circuit breaker tripped — shutting down")
|
||||||
|
shutdown.set()
|
||||||
|
break
|
||||||
|
except Exception as exc:
|
||||||
|
logger.exception("Daily session error: %s", exc)
|
||||||
|
|
||||||
|
# Wait for next session or shutdown
|
||||||
|
logger.info("Next session in %.1f hours", session_interval / 3600)
|
||||||
|
try:
|
||||||
|
await asyncio.wait_for(shutdown.wait(), timeout=session_interval)
|
||||||
|
except TimeoutError:
|
||||||
|
pass # Normal — time for next session
|
||||||
|
|
||||||
|
else:
|
||||||
|
# Realtime trading mode: original per-stock loop
|
||||||
|
logger.info("Realtime trading mode: 60s interval per stock")
|
||||||
|
|
||||||
|
while not shutdown.is_set():
|
||||||
|
# Wait for trading to be unpaused
|
||||||
|
await pause_trading.wait()
|
||||||
|
|
||||||
# Get currently open markets
|
# Get currently open markets
|
||||||
open_markets = get_open_markets(settings.enabled_market_list)
|
open_markets = get_open_markets(settings.enabled_market_list)
|
||||||
|
|
||||||
if not open_markets:
|
if not open_markets:
|
||||||
|
# Notify market close for any markets that were open
|
||||||
|
for market_code, is_open in list(_market_states.items()):
|
||||||
|
if is_open:
|
||||||
|
try:
|
||||||
|
from src.markets.schedule import MARKETS
|
||||||
|
|
||||||
|
market_info = MARKETS.get(market_code)
|
||||||
|
if market_info:
|
||||||
|
await telegram.notify_market_close(market_info.name, 0.0)
|
||||||
|
except Exception as exc:
|
||||||
|
logger.warning("Market close notification failed: %s", exc)
|
||||||
|
_market_states[market_code] = False
|
||||||
|
|
||||||
# No markets open — wait until next market opens
|
# No markets open — wait until next market opens
|
||||||
try:
|
try:
|
||||||
next_market, next_open_time = get_next_market_open(
|
next_market, next_open_time = get_next_market_open(
|
||||||
@@ -333,6 +859,14 @@ async def run(settings: Settings) -> None:
|
|||||||
if shutdown.is_set():
|
if shutdown.is_set():
|
||||||
break
|
break
|
||||||
|
|
||||||
|
# Notify market open if it just opened
|
||||||
|
if not _market_states.get(market.code, False):
|
||||||
|
try:
|
||||||
|
await telegram.notify_market_open(market.name)
|
||||||
|
except Exception as exc:
|
||||||
|
logger.warning("Market open notification failed: %s", exc)
|
||||||
|
_market_states[market.code] = True
|
||||||
|
|
||||||
# Volatility Hunter: Scan market periodically to update watchlist
|
# Volatility Hunter: Scan market periodically to update watchlist
|
||||||
now_timestamp = asyncio.get_event_loop().time()
|
now_timestamp = asyncio.get_event_loop().time()
|
||||||
last_scan = last_scan_time.get(market.code, 0.0)
|
last_scan = last_scan_time.get(market.code, 0.0)
|
||||||
@@ -391,12 +925,22 @@ async def run(settings: Settings) -> None:
|
|||||||
decision_logger,
|
decision_logger,
|
||||||
context_store,
|
context_store,
|
||||||
criticality_assessor,
|
criticality_assessor,
|
||||||
|
telegram,
|
||||||
market,
|
market,
|
||||||
stock_code,
|
stock_code,
|
||||||
)
|
)
|
||||||
break # Success — exit retry loop
|
break # Success — exit retry loop
|
||||||
except CircuitBreakerTripped:
|
except CircuitBreakerTripped as exc:
|
||||||
logger.critical("Circuit breaker tripped — shutting down")
|
logger.critical("Circuit breaker tripped — shutting down")
|
||||||
|
try:
|
||||||
|
await telegram.notify_circuit_breaker(
|
||||||
|
pnl_pct=exc.pnl_pct,
|
||||||
|
threshold=exc.threshold,
|
||||||
|
)
|
||||||
|
except Exception as notify_exc:
|
||||||
|
logger.warning(
|
||||||
|
"Circuit breaker notification failed: %s", notify_exc
|
||||||
|
)
|
||||||
raise
|
raise
|
||||||
except ConnectionError as exc:
|
except ConnectionError as exc:
|
||||||
if attempt < MAX_CONNECTION_RETRIES:
|
if attempt < MAX_CONNECTION_RETRIES:
|
||||||
@@ -437,7 +981,10 @@ async def run(settings: Settings) -> None:
|
|||||||
except TimeoutError:
|
except TimeoutError:
|
||||||
pass # Normal — timeout means it's time for next cycle
|
pass # Normal — timeout means it's time for next cycle
|
||||||
finally:
|
finally:
|
||||||
|
# Clean up resources
|
||||||
|
await command_handler.stop_polling()
|
||||||
await broker.close()
|
await broker.close()
|
||||||
|
await telegram.close()
|
||||||
db_conn.close()
|
db_conn.close()
|
||||||
logger.info("The Ouroboros rests.")
|
logger.info("The Ouroboros rests.")
|
||||||
|
|
||||||
|
|||||||
@@ -200,14 +200,151 @@ telegram = TelegramClient(
|
|||||||
)
|
)
|
||||||
```
|
```
|
||||||
|
|
||||||
|
## Bidirectional Commands
|
||||||
|
|
||||||
|
Control your trading bot remotely via Telegram commands. The bot not only sends notifications but also accepts commands for real-time control.
|
||||||
|
|
||||||
|
### Available Commands
|
||||||
|
|
||||||
|
| Command | Description |
|
||||||
|
|---------|-------------|
|
||||||
|
| `/start` | Welcome message with quick start guide |
|
||||||
|
| `/help` | List all available commands |
|
||||||
|
| `/status` | Current trading status (mode, markets, P&L, circuit breaker) |
|
||||||
|
| `/positions` | View current holdings grouped by market |
|
||||||
|
| `/stop` | Pause all trading operations |
|
||||||
|
| `/resume` | Resume trading operations |
|
||||||
|
|
||||||
|
### Command Examples
|
||||||
|
|
||||||
|
**Check Trading Status**
|
||||||
|
```
|
||||||
|
You: /status
|
||||||
|
|
||||||
|
Bot:
|
||||||
|
📊 Trading Status
|
||||||
|
|
||||||
|
Mode: PAPER
|
||||||
|
Markets: Korea, United States
|
||||||
|
Trading: Active
|
||||||
|
|
||||||
|
Current P&L: +2.50%
|
||||||
|
Circuit Breaker: -3.0%
|
||||||
|
```
|
||||||
|
|
||||||
|
**View Holdings**
|
||||||
|
```
|
||||||
|
You: /positions
|
||||||
|
|
||||||
|
Bot:
|
||||||
|
💼 Current Holdings
|
||||||
|
|
||||||
|
🇰🇷 Korea
|
||||||
|
• 005930: 10 shares @ 70,000
|
||||||
|
• 035420: 5 shares @ 200,000
|
||||||
|
|
||||||
|
🇺🇸 Overseas
|
||||||
|
• AAPL: 15 shares @ 175
|
||||||
|
• TSLA: 8 shares @ 245
|
||||||
|
|
||||||
|
Cash: ₩5,000,000
|
||||||
|
```
|
||||||
|
|
||||||
|
**Pause Trading**
|
||||||
|
```
|
||||||
|
You: /stop
|
||||||
|
|
||||||
|
Bot:
|
||||||
|
⏸️ Trading Paused
|
||||||
|
|
||||||
|
All trading operations have been suspended.
|
||||||
|
Use /resume to restart trading.
|
||||||
|
```
|
||||||
|
|
||||||
|
**Resume Trading**
|
||||||
|
```
|
||||||
|
You: /resume
|
||||||
|
|
||||||
|
Bot:
|
||||||
|
▶️ Trading Resumed
|
||||||
|
|
||||||
|
Trading operations have been restarted.
|
||||||
|
```
|
||||||
|
|
||||||
|
### Security
|
||||||
|
|
||||||
|
**Chat ID Verification**
|
||||||
|
- Commands are only accepted from the configured `TELEGRAM_CHAT_ID`
|
||||||
|
- Unauthorized users receive no response
|
||||||
|
- Command attempts from wrong chat IDs are logged
|
||||||
|
|
||||||
|
**Authorization Required**
|
||||||
|
- Only the bot owner (chat ID in `.env`) can control trading
|
||||||
|
- No way for unauthorized users to discover or use commands
|
||||||
|
- All command executions are logged for audit
|
||||||
|
|
||||||
|
### Configuration
|
||||||
|
|
||||||
|
Add to your `.env` file:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
# Commands are enabled by default
|
||||||
|
TELEGRAM_COMMANDS_ENABLED=true
|
||||||
|
|
||||||
|
# Polling interval (seconds) - how often to check for commands
|
||||||
|
TELEGRAM_POLLING_INTERVAL=1.0
|
||||||
|
```
|
||||||
|
|
||||||
|
To disable commands but keep notifications:
|
||||||
|
```bash
|
||||||
|
TELEGRAM_COMMANDS_ENABLED=false
|
||||||
|
```
|
||||||
|
|
||||||
|
### How It Works
|
||||||
|
|
||||||
|
1. **Long Polling**: Bot checks Telegram API every second for new messages
|
||||||
|
2. **Command Parsing**: Messages starting with `/` are parsed as commands
|
||||||
|
3. **Authentication**: Chat ID is verified before executing any command
|
||||||
|
4. **Execution**: Command handler is called with current bot state
|
||||||
|
5. **Response**: Result is sent back via Telegram
|
||||||
|
|
||||||
|
### Error Handling
|
||||||
|
|
||||||
|
- Command parsing errors → "Unknown command" response
|
||||||
|
- API failures → Graceful degradation, error logged
|
||||||
|
- Invalid state → Appropriate message (e.g., "Trading is already paused")
|
||||||
|
- Trading loop isolation → Command errors never crash trading
|
||||||
|
|
||||||
|
### Troubleshooting Commands
|
||||||
|
|
||||||
|
**Commands not responding**
|
||||||
|
1. Check `TELEGRAM_COMMANDS_ENABLED=true` in `.env`
|
||||||
|
2. Verify you started conversation with `/start`
|
||||||
|
3. Check logs for command handler errors
|
||||||
|
4. Confirm chat ID matches `.env` configuration
|
||||||
|
|
||||||
|
**Wrong chat ID**
|
||||||
|
- Commands from unauthorized chats are silently ignored
|
||||||
|
- Check logs for "unauthorized chat_id" warnings
|
||||||
|
|
||||||
|
**Delayed responses**
|
||||||
|
- Polling interval is 1 second by default
|
||||||
|
- Network latency may add delay
|
||||||
|
- Check `TELEGRAM_POLLING_INTERVAL` setting
|
||||||
|
|
||||||
## API Reference
|
## API Reference
|
||||||
|
|
||||||
See `telegram_client.py` for full API documentation.
|
See `telegram_client.py` for full API documentation.
|
||||||
|
|
||||||
Key methods:
|
### Notification Methods
|
||||||
- `notify_trade_execution()` - Trade alerts
|
- `notify_trade_execution()` - Trade alerts
|
||||||
- `notify_circuit_breaker()` - Emergency stops
|
- `notify_circuit_breaker()` - Emergency stops
|
||||||
- `notify_fat_finger()` - Order rejections
|
- `notify_fat_finger()` - Order rejections
|
||||||
- `notify_market_open/close()` - Session tracking
|
- `notify_market_open/close()` - Session tracking
|
||||||
- `notify_system_start/shutdown()` - Lifecycle events
|
- `notify_system_start/shutdown()` - Lifecycle events
|
||||||
- `notify_error()` - Error alerts
|
- `notify_error()` - Error alerts
|
||||||
|
|
||||||
|
### Command Handler
|
||||||
|
- `TelegramCommandHandler` - Bidirectional command processing
|
||||||
|
- `register_command()` - Register custom command handlers
|
||||||
|
- `start_polling()` / `stop_polling()` - Lifecycle management
|
||||||
|
|||||||
@@ -3,6 +3,7 @@
|
|||||||
import asyncio
|
import asyncio
|
||||||
import logging
|
import logging
|
||||||
import time
|
import time
|
||||||
|
from collections.abc import Awaitable, Callable
|
||||||
from dataclasses import dataclass
|
from dataclasses import dataclass
|
||||||
from enum import Enum
|
from enum import Enum
|
||||||
|
|
||||||
@@ -117,26 +118,28 @@ class TelegramClient:
|
|||||||
if self._session is not None and not self._session.closed:
|
if self._session is not None and not self._session.closed:
|
||||||
await self._session.close()
|
await self._session.close()
|
||||||
|
|
||||||
async def _send_notification(self, msg: NotificationMessage) -> None:
|
async def send_message(self, text: str, parse_mode: str = "HTML") -> bool:
|
||||||
"""
|
"""
|
||||||
Send notification to Telegram with graceful degradation.
|
Send a generic text message to Telegram.
|
||||||
|
|
||||||
Args:
|
Args:
|
||||||
msg: Notification message to send
|
text: Message text to send
|
||||||
|
parse_mode: Parse mode for formatting (HTML or Markdown)
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
True if message was sent successfully, False otherwise
|
||||||
"""
|
"""
|
||||||
if not self._enabled:
|
if not self._enabled:
|
||||||
return
|
return False
|
||||||
|
|
||||||
try:
|
try:
|
||||||
await self._rate_limiter.acquire()
|
await self._rate_limiter.acquire()
|
||||||
|
|
||||||
formatted_message = f"{msg.priority.emoji} {msg.message}"
|
|
||||||
url = f"{self.API_BASE.format(token=self._bot_token)}/sendMessage"
|
url = f"{self.API_BASE.format(token=self._bot_token)}/sendMessage"
|
||||||
|
|
||||||
payload = {
|
payload = {
|
||||||
"chat_id": self._chat_id,
|
"chat_id": self._chat_id,
|
||||||
"text": formatted_message,
|
"text": text,
|
||||||
"parse_mode": "HTML",
|
"parse_mode": parse_mode,
|
||||||
}
|
}
|
||||||
|
|
||||||
session = self._get_session()
|
session = self._get_session()
|
||||||
@@ -146,15 +149,29 @@ class TelegramClient:
|
|||||||
logger.error(
|
logger.error(
|
||||||
"Telegram API error (status=%d): %s", resp.status, error_text
|
"Telegram API error (status=%d): %s", resp.status, error_text
|
||||||
)
|
)
|
||||||
else:
|
return False
|
||||||
logger.debug("Telegram notification sent: %s", msg.message[:50])
|
logger.debug("Telegram message sent: %s", text[:50])
|
||||||
|
return True
|
||||||
|
|
||||||
except asyncio.TimeoutError:
|
except asyncio.TimeoutError:
|
||||||
logger.error("Telegram notification timeout")
|
logger.error("Telegram message timeout")
|
||||||
|
return False
|
||||||
except aiohttp.ClientError as exc:
|
except aiohttp.ClientError as exc:
|
||||||
logger.error("Telegram notification failed: %s", exc)
|
logger.error("Telegram message failed: %s", exc)
|
||||||
|
return False
|
||||||
except Exception as exc:
|
except Exception as exc:
|
||||||
logger.error("Unexpected error sending notification: %s", exc)
|
logger.error("Unexpected error sending message: %s", exc)
|
||||||
|
return False
|
||||||
|
|
||||||
|
async def _send_notification(self, msg: NotificationMessage) -> None:
|
||||||
|
"""
|
||||||
|
Send notification to Telegram with graceful degradation.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
msg: Notification message to send
|
||||||
|
"""
|
||||||
|
formatted_message = f"{msg.priority.emoji} {msg.message}"
|
||||||
|
await self.send_message(formatted_message)
|
||||||
|
|
||||||
async def notify_trade_execution(
|
async def notify_trade_execution(
|
||||||
self,
|
self,
|
||||||
@@ -323,3 +340,172 @@ class TelegramClient:
|
|||||||
await self._send_notification(
|
await self._send_notification(
|
||||||
NotificationMessage(priority=NotificationPriority.HIGH, message=message)
|
NotificationMessage(priority=NotificationPriority.HIGH, message=message)
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
class TelegramCommandHandler:
|
||||||
|
"""Handles incoming Telegram commands via long polling."""
|
||||||
|
|
||||||
|
def __init__(
|
||||||
|
self, client: TelegramClient, polling_interval: float = 1.0
|
||||||
|
) -> None:
|
||||||
|
"""
|
||||||
|
Initialize command handler.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
client: TelegramClient instance for sending responses
|
||||||
|
polling_interval: Polling interval in seconds
|
||||||
|
"""
|
||||||
|
self._client = client
|
||||||
|
self._polling_interval = polling_interval
|
||||||
|
self._commands: dict[str, Callable[[], Awaitable[None]]] = {}
|
||||||
|
self._last_update_id = 0
|
||||||
|
self._polling_task: asyncio.Task[None] | None = None
|
||||||
|
self._running = False
|
||||||
|
|
||||||
|
def register_command(
|
||||||
|
self, command: str, handler: Callable[[], Awaitable[None]]
|
||||||
|
) -> None:
|
||||||
|
"""
|
||||||
|
Register a command handler.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
command: Command name (without leading slash, e.g., "start")
|
||||||
|
handler: Async function to handle the command
|
||||||
|
"""
|
||||||
|
self._commands[command] = handler
|
||||||
|
logger.debug("Registered command handler: /%s", command)
|
||||||
|
|
||||||
|
async def start_polling(self) -> None:
|
||||||
|
"""Start long polling for commands."""
|
||||||
|
if self._running:
|
||||||
|
logger.warning("Command handler already running")
|
||||||
|
return
|
||||||
|
|
||||||
|
if not self._client._enabled:
|
||||||
|
logger.info("Command handler disabled (TelegramClient disabled)")
|
||||||
|
return
|
||||||
|
|
||||||
|
self._running = True
|
||||||
|
self._polling_task = asyncio.create_task(self._poll_loop())
|
||||||
|
logger.info("Started Telegram command polling")
|
||||||
|
|
||||||
|
async def stop_polling(self) -> None:
|
||||||
|
"""Stop polling and cancel pending tasks."""
|
||||||
|
if not self._running:
|
||||||
|
return
|
||||||
|
|
||||||
|
self._running = False
|
||||||
|
if self._polling_task:
|
||||||
|
self._polling_task.cancel()
|
||||||
|
try:
|
||||||
|
await self._polling_task
|
||||||
|
except asyncio.CancelledError:
|
||||||
|
pass
|
||||||
|
logger.info("Stopped Telegram command polling")
|
||||||
|
|
||||||
|
async def _poll_loop(self) -> None:
|
||||||
|
"""Main polling loop that fetches updates."""
|
||||||
|
while self._running:
|
||||||
|
try:
|
||||||
|
updates = await self._get_updates()
|
||||||
|
for update in updates:
|
||||||
|
await self._handle_update(update)
|
||||||
|
except asyncio.CancelledError:
|
||||||
|
break
|
||||||
|
except Exception as exc:
|
||||||
|
logger.error("Error in polling loop: %s", exc)
|
||||||
|
|
||||||
|
await asyncio.sleep(self._polling_interval)
|
||||||
|
|
||||||
|
async def _get_updates(self) -> list[dict]:
|
||||||
|
"""
|
||||||
|
Fetch updates from Telegram API.
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
List of update objects
|
||||||
|
"""
|
||||||
|
try:
|
||||||
|
url = f"{self._client.API_BASE.format(token=self._client._bot_token)}/getUpdates"
|
||||||
|
payload = {
|
||||||
|
"offset": self._last_update_id + 1,
|
||||||
|
"timeout": int(self._polling_interval),
|
||||||
|
"allowed_updates": ["message"],
|
||||||
|
}
|
||||||
|
|
||||||
|
session = self._client._get_session()
|
||||||
|
async with session.post(url, json=payload) as resp:
|
||||||
|
if resp.status != 200:
|
||||||
|
error_text = await resp.text()
|
||||||
|
logger.error(
|
||||||
|
"getUpdates API error (status=%d): %s", resp.status, error_text
|
||||||
|
)
|
||||||
|
return []
|
||||||
|
|
||||||
|
data = await resp.json()
|
||||||
|
if not data.get("ok"):
|
||||||
|
logger.error("getUpdates returned ok=false: %s", data)
|
||||||
|
return []
|
||||||
|
|
||||||
|
updates = data.get("result", [])
|
||||||
|
if updates:
|
||||||
|
self._last_update_id = updates[-1]["update_id"]
|
||||||
|
|
||||||
|
return updates
|
||||||
|
|
||||||
|
except asyncio.TimeoutError:
|
||||||
|
logger.debug("getUpdates timeout (normal)")
|
||||||
|
return []
|
||||||
|
except aiohttp.ClientError as exc:
|
||||||
|
logger.error("getUpdates failed: %s", exc)
|
||||||
|
return []
|
||||||
|
except Exception as exc:
|
||||||
|
logger.error("Unexpected error in _get_updates: %s", exc)
|
||||||
|
return []
|
||||||
|
|
||||||
|
async def _handle_update(self, update: dict) -> None:
|
||||||
|
"""
|
||||||
|
Parse and handle a single update.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
update: Update object from Telegram API
|
||||||
|
"""
|
||||||
|
try:
|
||||||
|
message = update.get("message")
|
||||||
|
if not message:
|
||||||
|
return
|
||||||
|
|
||||||
|
# Verify chat_id matches configured chat
|
||||||
|
chat_id = str(message.get("chat", {}).get("id", ""))
|
||||||
|
if chat_id != self._client._chat_id:
|
||||||
|
logger.warning(
|
||||||
|
"Ignoring command from unauthorized chat_id: %s", chat_id
|
||||||
|
)
|
||||||
|
return
|
||||||
|
|
||||||
|
# Extract command text
|
||||||
|
text = message.get("text", "").strip()
|
||||||
|
if not text.startswith("/"):
|
||||||
|
return
|
||||||
|
|
||||||
|
# Parse command (remove leading slash and extract command name)
|
||||||
|
command_parts = text[1:].split()
|
||||||
|
if not command_parts:
|
||||||
|
return
|
||||||
|
|
||||||
|
# Remove @botname suffix if present (for group chats)
|
||||||
|
command_name = command_parts[0].split("@")[0]
|
||||||
|
|
||||||
|
# Execute handler
|
||||||
|
handler = self._commands.get(command_name)
|
||||||
|
if handler:
|
||||||
|
logger.info("Executing command: /%s", command_name)
|
||||||
|
await handler()
|
||||||
|
else:
|
||||||
|
logger.debug("Unknown command: /%s", command_name)
|
||||||
|
await self._client.send_message(
|
||||||
|
f"Unknown command: /{command_name}\nUse /help to see available commands."
|
||||||
|
)
|
||||||
|
|
||||||
|
except Exception as exc:
|
||||||
|
logger.error("Error handling update: %s", exc)
|
||||||
|
# Don't crash the polling loop on handler errors
|
||||||
|
|||||||
@@ -152,3 +152,121 @@ class TestPromptConstruction:
|
|||||||
assert "JSON" in prompt
|
assert "JSON" in prompt
|
||||||
assert "action" in prompt
|
assert "action" in prompt
|
||||||
assert "confidence" in prompt
|
assert "confidence" in prompt
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Batch Decision Making
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
class TestBatchDecisionParsing:
|
||||||
|
"""Batch response parser must handle JSON arrays correctly."""
|
||||||
|
|
||||||
|
def test_parse_valid_batch_response(self, settings):
|
||||||
|
client = GeminiClient(settings)
|
||||||
|
stocks_data = [
|
||||||
|
{"stock_code": "AAPL", "current_price": 185.5},
|
||||||
|
{"stock_code": "MSFT", "current_price": 420.0},
|
||||||
|
]
|
||||||
|
raw = """[
|
||||||
|
{"code": "AAPL", "action": "BUY", "confidence": 85, "rationale": "Strong momentum"},
|
||||||
|
{"code": "MSFT", "action": "HOLD", "confidence": 50, "rationale": "Wait for earnings"}
|
||||||
|
]"""
|
||||||
|
|
||||||
|
decisions = client._parse_batch_response(raw, stocks_data, token_count=100)
|
||||||
|
|
||||||
|
assert len(decisions) == 2
|
||||||
|
assert decisions["AAPL"].action == "BUY"
|
||||||
|
assert decisions["AAPL"].confidence == 85
|
||||||
|
assert decisions["MSFT"].action == "HOLD"
|
||||||
|
assert decisions["MSFT"].confidence == 50
|
||||||
|
|
||||||
|
def test_parse_batch_with_markdown_wrapper(self, settings):
|
||||||
|
client = GeminiClient(settings)
|
||||||
|
stocks_data = [{"stock_code": "AAPL", "current_price": 185.5}]
|
||||||
|
raw = """```json
|
||||||
|
[{"code": "AAPL", "action": "BUY", "confidence": 90, "rationale": "Good"}]
|
||||||
|
```"""
|
||||||
|
|
||||||
|
decisions = client._parse_batch_response(raw, stocks_data, token_count=100)
|
||||||
|
|
||||||
|
assert decisions["AAPL"].action == "BUY"
|
||||||
|
assert decisions["AAPL"].confidence == 90
|
||||||
|
|
||||||
|
def test_parse_batch_empty_response_returns_hold_for_all(self, settings):
|
||||||
|
client = GeminiClient(settings)
|
||||||
|
stocks_data = [
|
||||||
|
{"stock_code": "AAPL", "current_price": 185.5},
|
||||||
|
{"stock_code": "MSFT", "current_price": 420.0},
|
||||||
|
]
|
||||||
|
|
||||||
|
decisions = client._parse_batch_response("", stocks_data, token_count=100)
|
||||||
|
|
||||||
|
assert len(decisions) == 2
|
||||||
|
assert decisions["AAPL"].action == "HOLD"
|
||||||
|
assert decisions["AAPL"].confidence == 0
|
||||||
|
assert decisions["MSFT"].action == "HOLD"
|
||||||
|
|
||||||
|
def test_parse_batch_malformed_json_returns_hold_for_all(self, settings):
|
||||||
|
client = GeminiClient(settings)
|
||||||
|
stocks_data = [{"stock_code": "AAPL", "current_price": 185.5}]
|
||||||
|
raw = "This is not JSON"
|
||||||
|
|
||||||
|
decisions = client._parse_batch_response(raw, stocks_data, token_count=100)
|
||||||
|
|
||||||
|
assert decisions["AAPL"].action == "HOLD"
|
||||||
|
assert decisions["AAPL"].confidence == 0
|
||||||
|
|
||||||
|
def test_parse_batch_not_array_returns_hold_for_all(self, settings):
|
||||||
|
client = GeminiClient(settings)
|
||||||
|
stocks_data = [{"stock_code": "AAPL", "current_price": 185.5}]
|
||||||
|
raw = '{"code": "AAPL", "action": "BUY", "confidence": 90, "rationale": "Good"}'
|
||||||
|
|
||||||
|
decisions = client._parse_batch_response(raw, stocks_data, token_count=100)
|
||||||
|
|
||||||
|
assert decisions["AAPL"].action == "HOLD"
|
||||||
|
assert decisions["AAPL"].confidence == 0
|
||||||
|
|
||||||
|
def test_parse_batch_missing_stock_gets_hold(self, settings):
|
||||||
|
client = GeminiClient(settings)
|
||||||
|
stocks_data = [
|
||||||
|
{"stock_code": "AAPL", "current_price": 185.5},
|
||||||
|
{"stock_code": "MSFT", "current_price": 420.0},
|
||||||
|
]
|
||||||
|
# Response only has AAPL, MSFT is missing
|
||||||
|
raw = '[{"code": "AAPL", "action": "BUY", "confidence": 85, "rationale": "Good"}]'
|
||||||
|
|
||||||
|
decisions = client._parse_batch_response(raw, stocks_data, token_count=100)
|
||||||
|
|
||||||
|
assert decisions["AAPL"].action == "BUY"
|
||||||
|
assert decisions["MSFT"].action == "HOLD"
|
||||||
|
assert decisions["MSFT"].confidence == 0
|
||||||
|
|
||||||
|
def test_parse_batch_invalid_action_becomes_hold(self, settings):
|
||||||
|
client = GeminiClient(settings)
|
||||||
|
stocks_data = [{"stock_code": "AAPL", "current_price": 185.5}]
|
||||||
|
raw = '[{"code": "AAPL", "action": "YOLO", "confidence": 90, "rationale": "Moon"}]'
|
||||||
|
|
||||||
|
decisions = client._parse_batch_response(raw, stocks_data, token_count=100)
|
||||||
|
|
||||||
|
assert decisions["AAPL"].action == "HOLD"
|
||||||
|
|
||||||
|
def test_parse_batch_low_confidence_becomes_hold(self, settings):
|
||||||
|
client = GeminiClient(settings)
|
||||||
|
stocks_data = [{"stock_code": "AAPL", "current_price": 185.5}]
|
||||||
|
raw = '[{"code": "AAPL", "action": "BUY", "confidence": 65, "rationale": "Weak"}]'
|
||||||
|
|
||||||
|
decisions = client._parse_batch_response(raw, stocks_data, token_count=100)
|
||||||
|
|
||||||
|
assert decisions["AAPL"].action == "HOLD"
|
||||||
|
assert decisions["AAPL"].confidence == 65
|
||||||
|
|
||||||
|
def test_parse_batch_missing_fields_gets_hold(self, settings):
|
||||||
|
client = GeminiClient(settings)
|
||||||
|
stocks_data = [{"stock_code": "AAPL", "current_price": 185.5}]
|
||||||
|
raw = '[{"code": "AAPL", "action": "BUY"}]' # Missing confidence and rationale
|
||||||
|
|
||||||
|
decisions = client._parse_batch_response(raw, stocks_data, token_count=100)
|
||||||
|
|
||||||
|
assert decisions["AAPL"].action == "HOLD"
|
||||||
|
assert decisions["AAPL"].confidence == 0
|
||||||
|
|||||||
@@ -49,6 +49,110 @@ class TestTokenManagement:
|
|||||||
|
|
||||||
await broker.close()
|
await broker.close()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_concurrent_token_refresh_calls_api_once(self, settings):
|
||||||
|
"""Multiple concurrent token requests should only call API once."""
|
||||||
|
broker = KISBroker(settings)
|
||||||
|
|
||||||
|
# Track how many times the mock API is called
|
||||||
|
call_count = [0]
|
||||||
|
|
||||||
|
def create_mock_resp():
|
||||||
|
call_count[0] += 1
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.json = AsyncMock(
|
||||||
|
return_value={
|
||||||
|
"access_token": "tok_concurrent",
|
||||||
|
"token_type": "Bearer",
|
||||||
|
"expires_in": 86400,
|
||||||
|
}
|
||||||
|
)
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
return mock_resp
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=create_mock_resp()):
|
||||||
|
# Launch 5 concurrent token requests
|
||||||
|
tokens = await asyncio.gather(
|
||||||
|
broker._ensure_token(),
|
||||||
|
broker._ensure_token(),
|
||||||
|
broker._ensure_token(),
|
||||||
|
broker._ensure_token(),
|
||||||
|
broker._ensure_token(),
|
||||||
|
)
|
||||||
|
|
||||||
|
# All should get the same token
|
||||||
|
assert all(t == "tok_concurrent" for t in tokens)
|
||||||
|
# API should be called only once (due to lock)
|
||||||
|
assert call_count[0] == 1
|
||||||
|
|
||||||
|
await broker.close()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_token_refresh_cooldown_prevents_rapid_retries(self, settings):
|
||||||
|
"""Token refresh should enforce cooldown after failure (issue #54)."""
|
||||||
|
broker = KISBroker(settings)
|
||||||
|
broker._refresh_cooldown = 2.0 # Short cooldown for testing
|
||||||
|
|
||||||
|
# First refresh attempt fails with 403 (EGW00133)
|
||||||
|
mock_resp_403 = AsyncMock()
|
||||||
|
mock_resp_403.status = 403
|
||||||
|
mock_resp_403.text = AsyncMock(
|
||||||
|
return_value='{"error_code":"EGW00133","error_description":"접근토큰 발급 잠시 후 다시 시도하세요(1분당 1회)"}'
|
||||||
|
)
|
||||||
|
mock_resp_403.__aenter__ = AsyncMock(return_value=mock_resp_403)
|
||||||
|
mock_resp_403.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp_403):
|
||||||
|
# First attempt should fail with 403
|
||||||
|
with pytest.raises(ConnectionError, match="Token refresh failed"):
|
||||||
|
await broker._ensure_token()
|
||||||
|
|
||||||
|
# Second attempt within cooldown should fail with cooldown error
|
||||||
|
with pytest.raises(ConnectionError, match="Token refresh on cooldown"):
|
||||||
|
await broker._ensure_token()
|
||||||
|
|
||||||
|
await broker.close()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_token_refresh_allowed_after_cooldown(self, settings):
|
||||||
|
"""Token refresh should be allowed after cooldown period expires."""
|
||||||
|
broker = KISBroker(settings)
|
||||||
|
broker._refresh_cooldown = 0.1 # Very short cooldown for testing
|
||||||
|
|
||||||
|
# First attempt fails
|
||||||
|
mock_resp_403 = AsyncMock()
|
||||||
|
mock_resp_403.status = 403
|
||||||
|
mock_resp_403.text = AsyncMock(return_value='{"error_code":"EGW00133"}')
|
||||||
|
mock_resp_403.__aenter__ = AsyncMock(return_value=mock_resp_403)
|
||||||
|
mock_resp_403.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
# Second attempt succeeds
|
||||||
|
mock_resp_200 = AsyncMock()
|
||||||
|
mock_resp_200.status = 200
|
||||||
|
mock_resp_200.json = AsyncMock(
|
||||||
|
return_value={
|
||||||
|
"access_token": "tok_after_cooldown",
|
||||||
|
"expires_in": 86400,
|
||||||
|
}
|
||||||
|
)
|
||||||
|
mock_resp_200.__aenter__ = AsyncMock(return_value=mock_resp_200)
|
||||||
|
mock_resp_200.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp_403):
|
||||||
|
with pytest.raises(ConnectionError, match="Token refresh failed"):
|
||||||
|
await broker._ensure_token()
|
||||||
|
|
||||||
|
# Wait for cooldown to expire
|
||||||
|
await asyncio.sleep(0.15)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp_200):
|
||||||
|
token = await broker._ensure_token()
|
||||||
|
assert token == "tok_after_cooldown"
|
||||||
|
|
||||||
|
await broker.close()
|
||||||
|
|
||||||
|
|
||||||
# ---------------------------------------------------------------------------
|
# ---------------------------------------------------------------------------
|
||||||
# Network Error Handling
|
# Network Error Handling
|
||||||
@@ -107,6 +211,38 @@ class TestRateLimiter:
|
|||||||
await broker._rate_limiter.acquire()
|
await broker._rate_limiter.acquire()
|
||||||
await broker.close()
|
await broker.close()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_send_order_acquires_rate_limiter_twice(self, settings):
|
||||||
|
"""send_order must acquire rate limiter for both hash key and order call."""
|
||||||
|
broker = KISBroker(settings)
|
||||||
|
broker._access_token = "tok"
|
||||||
|
broker._token_expires_at = asyncio.get_event_loop().time() + 3600
|
||||||
|
|
||||||
|
# Mock hash key response
|
||||||
|
mock_hash_resp = AsyncMock()
|
||||||
|
mock_hash_resp.status = 200
|
||||||
|
mock_hash_resp.json = AsyncMock(return_value={"HASH": "abc123"})
|
||||||
|
mock_hash_resp.__aenter__ = AsyncMock(return_value=mock_hash_resp)
|
||||||
|
mock_hash_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
# Mock order response
|
||||||
|
mock_order_resp = AsyncMock()
|
||||||
|
mock_order_resp.status = 200
|
||||||
|
mock_order_resp.json = AsyncMock(return_value={"rt_cd": "0"})
|
||||||
|
mock_order_resp.__aenter__ = AsyncMock(return_value=mock_order_resp)
|
||||||
|
mock_order_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
with patch(
|
||||||
|
"aiohttp.ClientSession.post", side_effect=[mock_hash_resp, mock_order_resp]
|
||||||
|
):
|
||||||
|
with patch.object(
|
||||||
|
broker._rate_limiter, "acquire", new_callable=AsyncMock
|
||||||
|
) as mock_acquire:
|
||||||
|
await broker.send_order("005930", "BUY", 1, 50000)
|
||||||
|
assert mock_acquire.call_count == 2
|
||||||
|
|
||||||
|
await broker.close()
|
||||||
|
|
||||||
|
|
||||||
# ---------------------------------------------------------------------------
|
# ---------------------------------------------------------------------------
|
||||||
# Hash Key Generation
|
# Hash Key Generation
|
||||||
@@ -136,3 +272,27 @@ class TestHashKey:
|
|||||||
assert len(hash_key) > 0
|
assert len(hash_key) > 0
|
||||||
|
|
||||||
await broker.close()
|
await broker.close()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_hash_key_acquires_rate_limiter(self, settings):
|
||||||
|
"""_get_hash_key must go through the rate limiter to prevent burst."""
|
||||||
|
broker = KISBroker(settings)
|
||||||
|
broker._access_token = "tok"
|
||||||
|
broker._token_expires_at = asyncio.get_event_loop().time() + 3600
|
||||||
|
|
||||||
|
body = {"CANO": "12345678", "ACNT_PRDT_CD": "01"}
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.json = AsyncMock(return_value={"HASH": "abc123hash"})
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp):
|
||||||
|
with patch.object(
|
||||||
|
broker._rate_limiter, "acquire", new_callable=AsyncMock
|
||||||
|
) as mock_acquire:
|
||||||
|
await broker._get_hash_key(body)
|
||||||
|
mock_acquire.assert_called_once()
|
||||||
|
|
||||||
|
await broker.close()
|
||||||
|
|||||||
651
tests/test_main.py
Normal file
651
tests/test_main.py
Normal file
@@ -0,0 +1,651 @@
|
|||||||
|
"""Tests for main trading loop telegram integration."""
|
||||||
|
|
||||||
|
import asyncio
|
||||||
|
from unittest.mock import AsyncMock, MagicMock, patch
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
from src.core.risk_manager import CircuitBreakerTripped, FatFingerRejected
|
||||||
|
from src.main import safe_float, trading_cycle
|
||||||
|
|
||||||
|
|
||||||
|
class TestSafeFloat:
|
||||||
|
"""Test safe_float() helper function."""
|
||||||
|
|
||||||
|
def test_converts_valid_string(self):
|
||||||
|
"""Test conversion of valid numeric string."""
|
||||||
|
assert safe_float("123.45") == 123.45
|
||||||
|
assert safe_float("0") == 0.0
|
||||||
|
assert safe_float("-99.9") == -99.9
|
||||||
|
|
||||||
|
def test_handles_empty_string(self):
|
||||||
|
"""Test empty string returns default."""
|
||||||
|
assert safe_float("") == 0.0
|
||||||
|
assert safe_float("", 99.0) == 99.0
|
||||||
|
|
||||||
|
def test_handles_none(self):
|
||||||
|
"""Test None returns default."""
|
||||||
|
assert safe_float(None) == 0.0
|
||||||
|
assert safe_float(None, 42.0) == 42.0
|
||||||
|
|
||||||
|
def test_handles_invalid_string(self):
|
||||||
|
"""Test invalid string returns default."""
|
||||||
|
assert safe_float("invalid") == 0.0
|
||||||
|
assert safe_float("not_a_number", 100.0) == 100.0
|
||||||
|
assert safe_float("12.34.56") == 0.0
|
||||||
|
|
||||||
|
def test_handles_float_input(self):
|
||||||
|
"""Test float input passes through."""
|
||||||
|
assert safe_float(123.45) == 123.45
|
||||||
|
assert safe_float(0.0) == 0.0
|
||||||
|
|
||||||
|
def test_custom_default(self):
|
||||||
|
"""Test custom default value."""
|
||||||
|
assert safe_float("", -1.0) == -1.0
|
||||||
|
assert safe_float(None, 999.0) == 999.0
|
||||||
|
|
||||||
|
|
||||||
|
class TestTradingCycleTelegramIntegration:
|
||||||
|
"""Test telegram notifications in trading_cycle function."""
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_broker(self) -> MagicMock:
|
||||||
|
"""Create mock broker."""
|
||||||
|
broker = MagicMock()
|
||||||
|
broker.get_orderbook = AsyncMock(
|
||||||
|
return_value={
|
||||||
|
"output1": {
|
||||||
|
"stck_prpr": "50000",
|
||||||
|
"frgn_ntby_qty": "100",
|
||||||
|
}
|
||||||
|
}
|
||||||
|
)
|
||||||
|
broker.get_balance = AsyncMock(
|
||||||
|
return_value={
|
||||||
|
"output2": [
|
||||||
|
{
|
||||||
|
"tot_evlu_amt": "10000000",
|
||||||
|
"dnca_tot_amt": "5000000",
|
||||||
|
"pchs_amt_smtl_amt": "5000000",
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
)
|
||||||
|
broker.send_order = AsyncMock(return_value={"msg1": "OK"})
|
||||||
|
return broker
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_overseas_broker(self) -> MagicMock:
|
||||||
|
"""Create mock overseas broker."""
|
||||||
|
broker = MagicMock()
|
||||||
|
return broker
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_brain(self) -> MagicMock:
|
||||||
|
"""Create mock brain that decides to buy."""
|
||||||
|
brain = MagicMock()
|
||||||
|
decision = MagicMock()
|
||||||
|
decision.action = "BUY"
|
||||||
|
decision.confidence = 85
|
||||||
|
decision.rationale = "Test buy"
|
||||||
|
brain.decide = AsyncMock(return_value=decision)
|
||||||
|
return brain
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_risk(self) -> MagicMock:
|
||||||
|
"""Create mock risk manager."""
|
||||||
|
risk = MagicMock()
|
||||||
|
risk.validate_order = MagicMock()
|
||||||
|
return risk
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_db(self) -> MagicMock:
|
||||||
|
"""Create mock database connection."""
|
||||||
|
return MagicMock()
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_decision_logger(self) -> MagicMock:
|
||||||
|
"""Create mock decision logger."""
|
||||||
|
logger = MagicMock()
|
||||||
|
logger.log_decision = MagicMock()
|
||||||
|
return logger
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_context_store(self) -> MagicMock:
|
||||||
|
"""Create mock context store."""
|
||||||
|
store = MagicMock()
|
||||||
|
store.get_latest_timeframe = MagicMock(return_value=None)
|
||||||
|
return store
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_criticality_assessor(self) -> MagicMock:
|
||||||
|
"""Create mock criticality assessor."""
|
||||||
|
assessor = MagicMock()
|
||||||
|
assessor.assess_market_conditions = MagicMock(
|
||||||
|
return_value=MagicMock(value="NORMAL")
|
||||||
|
)
|
||||||
|
assessor.get_timeout = MagicMock(return_value=5.0)
|
||||||
|
return assessor
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_telegram(self) -> MagicMock:
|
||||||
|
"""Create mock telegram client."""
|
||||||
|
telegram = MagicMock()
|
||||||
|
telegram.notify_trade_execution = AsyncMock()
|
||||||
|
telegram.notify_fat_finger = AsyncMock()
|
||||||
|
telegram.notify_circuit_breaker = AsyncMock()
|
||||||
|
return telegram
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_market(self) -> MagicMock:
|
||||||
|
"""Create mock market info."""
|
||||||
|
market = MagicMock()
|
||||||
|
market.name = "Korea"
|
||||||
|
market.code = "KR"
|
||||||
|
market.exchange_code = "KRX"
|
||||||
|
market.is_domestic = True
|
||||||
|
return market
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_trade_execution_notification_sent(
|
||||||
|
self,
|
||||||
|
mock_broker: MagicMock,
|
||||||
|
mock_overseas_broker: MagicMock,
|
||||||
|
mock_brain: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test telegram notification sent on trade execution."""
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_broker,
|
||||||
|
overseas_broker=mock_overseas_broker,
|
||||||
|
brain=mock_brain,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_market,
|
||||||
|
stock_code="005930",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify notification was sent
|
||||||
|
mock_telegram.notify_trade_execution.assert_called_once()
|
||||||
|
call_kwargs = mock_telegram.notify_trade_execution.call_args.kwargs
|
||||||
|
assert call_kwargs["stock_code"] == "005930"
|
||||||
|
assert call_kwargs["market"] == "Korea"
|
||||||
|
assert call_kwargs["action"] == "BUY"
|
||||||
|
assert call_kwargs["confidence"] == 85
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_trade_execution_notification_failure_doesnt_crash(
|
||||||
|
self,
|
||||||
|
mock_broker: MagicMock,
|
||||||
|
mock_overseas_broker: MagicMock,
|
||||||
|
mock_brain: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test trading continues even if notification fails."""
|
||||||
|
# Make notification fail
|
||||||
|
mock_telegram.notify_trade_execution.side_effect = Exception("API error")
|
||||||
|
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
# Should not raise exception
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_broker,
|
||||||
|
overseas_broker=mock_overseas_broker,
|
||||||
|
brain=mock_brain,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_market,
|
||||||
|
stock_code="005930",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify notification was attempted
|
||||||
|
mock_telegram.notify_trade_execution.assert_called_once()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_fat_finger_notification_sent(
|
||||||
|
self,
|
||||||
|
mock_broker: MagicMock,
|
||||||
|
mock_overseas_broker: MagicMock,
|
||||||
|
mock_brain: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test telegram notification sent on fat finger rejection."""
|
||||||
|
# Make risk manager reject the order
|
||||||
|
mock_risk.validate_order.side_effect = FatFingerRejected(
|
||||||
|
order_amount=2000000,
|
||||||
|
total_cash=5000000,
|
||||||
|
max_pct=30.0,
|
||||||
|
)
|
||||||
|
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
with pytest.raises(FatFingerRejected):
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_broker,
|
||||||
|
overseas_broker=mock_overseas_broker,
|
||||||
|
brain=mock_brain,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_market,
|
||||||
|
stock_code="005930",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify notification was sent
|
||||||
|
mock_telegram.notify_fat_finger.assert_called_once()
|
||||||
|
call_kwargs = mock_telegram.notify_fat_finger.call_args.kwargs
|
||||||
|
assert call_kwargs["stock_code"] == "005930"
|
||||||
|
assert call_kwargs["order_amount"] == 2000000
|
||||||
|
assert call_kwargs["total_cash"] == 5000000
|
||||||
|
assert call_kwargs["max_pct"] == 30.0
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_fat_finger_notification_failure_still_raises(
|
||||||
|
self,
|
||||||
|
mock_broker: MagicMock,
|
||||||
|
mock_overseas_broker: MagicMock,
|
||||||
|
mock_brain: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test fat finger exception still raised even if notification fails."""
|
||||||
|
# Make risk manager reject the order
|
||||||
|
mock_risk.validate_order.side_effect = FatFingerRejected(
|
||||||
|
order_amount=2000000,
|
||||||
|
total_cash=5000000,
|
||||||
|
max_pct=30.0,
|
||||||
|
)
|
||||||
|
# Make notification fail
|
||||||
|
mock_telegram.notify_fat_finger.side_effect = Exception("API error")
|
||||||
|
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
with pytest.raises(FatFingerRejected):
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_broker,
|
||||||
|
overseas_broker=mock_overseas_broker,
|
||||||
|
brain=mock_brain,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_market,
|
||||||
|
stock_code="005930",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify notification was attempted
|
||||||
|
mock_telegram.notify_fat_finger.assert_called_once()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_no_notification_on_hold_decision(
|
||||||
|
self,
|
||||||
|
mock_broker: MagicMock,
|
||||||
|
mock_overseas_broker: MagicMock,
|
||||||
|
mock_brain: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test no trade notification sent when decision is HOLD."""
|
||||||
|
# Change brain decision to HOLD
|
||||||
|
decision = MagicMock()
|
||||||
|
decision.action = "HOLD"
|
||||||
|
decision.confidence = 50
|
||||||
|
decision.rationale = "Insufficient signal"
|
||||||
|
mock_brain.decide = AsyncMock(return_value=decision)
|
||||||
|
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_broker,
|
||||||
|
overseas_broker=mock_overseas_broker,
|
||||||
|
brain=mock_brain,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_market,
|
||||||
|
stock_code="005930",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify no trade notification sent
|
||||||
|
mock_telegram.notify_trade_execution.assert_not_called()
|
||||||
|
|
||||||
|
|
||||||
|
class TestRunFunctionTelegramIntegration:
|
||||||
|
"""Test telegram notifications in run function."""
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_circuit_breaker_notification_sent(self) -> None:
|
||||||
|
"""Test telegram notification sent when circuit breaker trips."""
|
||||||
|
mock_telegram = MagicMock()
|
||||||
|
mock_telegram.notify_circuit_breaker = AsyncMock()
|
||||||
|
|
||||||
|
# Simulate circuit breaker exception
|
||||||
|
exc = CircuitBreakerTripped(pnl_pct=-3.5, threshold=-3.0)
|
||||||
|
|
||||||
|
# Test the notification logic
|
||||||
|
try:
|
||||||
|
await mock_telegram.notify_circuit_breaker(
|
||||||
|
pnl_pct=exc.pnl_pct,
|
||||||
|
threshold=exc.threshold,
|
||||||
|
)
|
||||||
|
except Exception:
|
||||||
|
pass # Ignore errors in notification
|
||||||
|
|
||||||
|
# Verify notification was called
|
||||||
|
mock_telegram.notify_circuit_breaker.assert_called_once_with(
|
||||||
|
pnl_pct=-3.5,
|
||||||
|
threshold=-3.0,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
class TestOverseasBalanceParsing:
|
||||||
|
"""Test overseas balance output2 parsing handles different formats."""
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_overseas_broker_with_list(self) -> MagicMock:
|
||||||
|
"""Create mock overseas broker returning list format."""
|
||||||
|
broker = MagicMock()
|
||||||
|
broker.get_overseas_price = AsyncMock(
|
||||||
|
return_value={"output": {"last": "150.50"}}
|
||||||
|
)
|
||||||
|
broker.get_overseas_balance = AsyncMock(
|
||||||
|
return_value={
|
||||||
|
"output2": [
|
||||||
|
{
|
||||||
|
"frcr_evlu_tota": "10000.00",
|
||||||
|
"frcr_dncl_amt_2": "5000.00",
|
||||||
|
"frcr_buy_amt_smtl": "4500.00",
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
)
|
||||||
|
return broker
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_overseas_broker_with_dict(self) -> MagicMock:
|
||||||
|
"""Create mock overseas broker returning dict format."""
|
||||||
|
broker = MagicMock()
|
||||||
|
broker.get_overseas_price = AsyncMock(
|
||||||
|
return_value={"output": {"last": "150.50"}}
|
||||||
|
)
|
||||||
|
broker.get_overseas_balance = AsyncMock(
|
||||||
|
return_value={
|
||||||
|
"output2": {
|
||||||
|
"frcr_evlu_tota": "10000.00",
|
||||||
|
"frcr_dncl_amt_2": "5000.00",
|
||||||
|
"frcr_buy_amt_smtl": "4500.00",
|
||||||
|
}
|
||||||
|
}
|
||||||
|
)
|
||||||
|
return broker
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_overseas_broker_with_empty(self) -> MagicMock:
|
||||||
|
"""Create mock overseas broker returning empty output2."""
|
||||||
|
broker = MagicMock()
|
||||||
|
broker.get_overseas_price = AsyncMock(
|
||||||
|
return_value={"output": {"last": "150.50"}}
|
||||||
|
)
|
||||||
|
broker.get_overseas_balance = AsyncMock(return_value={"output2": []})
|
||||||
|
return broker
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_overseas_broker_with_empty_price(self) -> MagicMock:
|
||||||
|
"""Create mock overseas broker returning empty string for price."""
|
||||||
|
broker = MagicMock()
|
||||||
|
broker.get_overseas_price = AsyncMock(
|
||||||
|
return_value={"output": {"last": ""}} # Empty string
|
||||||
|
)
|
||||||
|
broker.get_overseas_balance = AsyncMock(
|
||||||
|
return_value={
|
||||||
|
"output2": [
|
||||||
|
{
|
||||||
|
"frcr_evlu_tota": "10000.00",
|
||||||
|
"frcr_dncl_amt_2": "5000.00",
|
||||||
|
"frcr_buy_amt_smtl": "4500.00",
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
)
|
||||||
|
return broker
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_domestic_broker(self) -> MagicMock:
|
||||||
|
"""Create minimal mock domestic broker."""
|
||||||
|
broker = MagicMock()
|
||||||
|
return broker
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_overseas_market(self) -> MagicMock:
|
||||||
|
"""Create mock overseas market info."""
|
||||||
|
market = MagicMock()
|
||||||
|
market.name = "NASDAQ"
|
||||||
|
market.code = "US_NASDAQ"
|
||||||
|
market.exchange_code = "NASD"
|
||||||
|
market.is_domestic = False
|
||||||
|
return market
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_brain_hold(self) -> MagicMock:
|
||||||
|
"""Create mock brain that always holds."""
|
||||||
|
brain = MagicMock()
|
||||||
|
decision = MagicMock()
|
||||||
|
decision.action = "HOLD"
|
||||||
|
decision.confidence = 50
|
||||||
|
decision.rationale = "Testing balance parsing"
|
||||||
|
brain.decide = AsyncMock(return_value=decision)
|
||||||
|
return brain
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_risk(self) -> MagicMock:
|
||||||
|
"""Create mock risk manager."""
|
||||||
|
return MagicMock()
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_db(self) -> MagicMock:
|
||||||
|
"""Create mock database."""
|
||||||
|
return MagicMock()
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_decision_logger(self) -> MagicMock:
|
||||||
|
"""Create mock decision logger."""
|
||||||
|
return MagicMock()
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_context_store(self) -> MagicMock:
|
||||||
|
"""Create mock context store."""
|
||||||
|
store = MagicMock()
|
||||||
|
store.get_latest_timeframe = MagicMock(return_value=None)
|
||||||
|
return store
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_criticality_assessor(self) -> MagicMock:
|
||||||
|
"""Create mock criticality assessor."""
|
||||||
|
assessor = MagicMock()
|
||||||
|
assessor.assess_market_conditions = MagicMock(
|
||||||
|
return_value=MagicMock(value="NORMAL")
|
||||||
|
)
|
||||||
|
assessor.get_timeout = MagicMock(return_value=5.0)
|
||||||
|
return assessor
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def mock_telegram(self) -> MagicMock:
|
||||||
|
"""Create mock telegram client."""
|
||||||
|
return MagicMock()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_overseas_balance_list_format(
|
||||||
|
self,
|
||||||
|
mock_domestic_broker: MagicMock,
|
||||||
|
mock_overseas_broker_with_list: MagicMock,
|
||||||
|
mock_brain_hold: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_overseas_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test overseas balance parsing with list format (output2=[{...}])."""
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
# Should not raise KeyError
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_domestic_broker,
|
||||||
|
overseas_broker=mock_overseas_broker_with_list,
|
||||||
|
brain=mock_brain_hold,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_overseas_market,
|
||||||
|
stock_code="AAPL",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify balance API was called
|
||||||
|
mock_overseas_broker_with_list.get_overseas_balance.assert_called_once()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_overseas_balance_dict_format(
|
||||||
|
self,
|
||||||
|
mock_domestic_broker: MagicMock,
|
||||||
|
mock_overseas_broker_with_dict: MagicMock,
|
||||||
|
mock_brain_hold: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_overseas_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test overseas balance parsing with dict format (output2={...})."""
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
# Should not raise KeyError
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_domestic_broker,
|
||||||
|
overseas_broker=mock_overseas_broker_with_dict,
|
||||||
|
brain=mock_brain_hold,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_overseas_market,
|
||||||
|
stock_code="AAPL",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify balance API was called
|
||||||
|
mock_overseas_broker_with_dict.get_overseas_balance.assert_called_once()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_overseas_balance_empty_format(
|
||||||
|
self,
|
||||||
|
mock_domestic_broker: MagicMock,
|
||||||
|
mock_overseas_broker_with_empty: MagicMock,
|
||||||
|
mock_brain_hold: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_overseas_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test overseas balance parsing with empty output2."""
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
# Should not raise KeyError, should default to 0
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_domestic_broker,
|
||||||
|
overseas_broker=mock_overseas_broker_with_empty,
|
||||||
|
brain=mock_brain_hold,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_overseas_market,
|
||||||
|
stock_code="AAPL",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify balance API was called
|
||||||
|
mock_overseas_broker_with_empty.get_overseas_balance.assert_called_once()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_overseas_price_empty_string(
|
||||||
|
self,
|
||||||
|
mock_domestic_broker: MagicMock,
|
||||||
|
mock_overseas_broker_with_empty_price: MagicMock,
|
||||||
|
mock_brain_hold: MagicMock,
|
||||||
|
mock_risk: MagicMock,
|
||||||
|
mock_db: MagicMock,
|
||||||
|
mock_decision_logger: MagicMock,
|
||||||
|
mock_context_store: MagicMock,
|
||||||
|
mock_criticality_assessor: MagicMock,
|
||||||
|
mock_telegram: MagicMock,
|
||||||
|
mock_overseas_market: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
"""Test overseas price parsing with empty string (issue #49)."""
|
||||||
|
with patch("src.main.log_trade"):
|
||||||
|
# Should not raise ValueError, should default to 0.0
|
||||||
|
await trading_cycle(
|
||||||
|
broker=mock_domestic_broker,
|
||||||
|
overseas_broker=mock_overseas_broker_with_empty_price,
|
||||||
|
brain=mock_brain_hold,
|
||||||
|
risk=mock_risk,
|
||||||
|
db_conn=mock_db,
|
||||||
|
decision_logger=mock_decision_logger,
|
||||||
|
context_store=mock_context_store,
|
||||||
|
criticality_assessor=mock_criticality_assessor,
|
||||||
|
telegram=mock_telegram,
|
||||||
|
market=mock_overseas_market,
|
||||||
|
stock_code="AAPL",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Verify price API was called
|
||||||
|
mock_overseas_broker_with_empty_price.get_overseas_price.assert_called_once()
|
||||||
@@ -39,6 +39,76 @@ class TestTelegramClientInit:
|
|||||||
class TestNotificationSending:
|
class TestNotificationSending:
|
||||||
"""Test notification sending behavior."""
|
"""Test notification sending behavior."""
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_send_message_success(self) -> None:
|
||||||
|
"""send_message returns True on successful send."""
|
||||||
|
client = TelegramClient(
|
||||||
|
bot_token="123:abc", chat_id="456", enabled=True
|
||||||
|
)
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp) as mock_post:
|
||||||
|
result = await client.send_message("Test message")
|
||||||
|
|
||||||
|
assert result is True
|
||||||
|
assert mock_post.call_count == 1
|
||||||
|
|
||||||
|
payload = mock_post.call_args.kwargs["json"]
|
||||||
|
assert payload["chat_id"] == "456"
|
||||||
|
assert payload["text"] == "Test message"
|
||||||
|
assert payload["parse_mode"] == "HTML"
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_send_message_disabled_client(self) -> None:
|
||||||
|
"""send_message returns False when client disabled."""
|
||||||
|
client = TelegramClient(enabled=False)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post") as mock_post:
|
||||||
|
result = await client.send_message("Test message")
|
||||||
|
|
||||||
|
assert result is False
|
||||||
|
mock_post.assert_not_called()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_send_message_api_error(self) -> None:
|
||||||
|
"""send_message returns False on API error."""
|
||||||
|
client = TelegramClient(
|
||||||
|
bot_token="123:abc", chat_id="456", enabled=True
|
||||||
|
)
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 400
|
||||||
|
mock_resp.text = AsyncMock(return_value="Bad Request")
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp):
|
||||||
|
result = await client.send_message("Test message")
|
||||||
|
assert result is False
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_send_message_with_markdown(self) -> None:
|
||||||
|
"""send_message supports different parse modes."""
|
||||||
|
client = TelegramClient(
|
||||||
|
bot_token="123:abc", chat_id="456", enabled=True
|
||||||
|
)
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp) as mock_post:
|
||||||
|
result = await client.send_message("*bold*", parse_mode="Markdown")
|
||||||
|
|
||||||
|
assert result is True
|
||||||
|
payload = mock_post.call_args.kwargs["json"]
|
||||||
|
assert payload["parse_mode"] == "Markdown"
|
||||||
|
|
||||||
@pytest.mark.asyncio
|
@pytest.mark.asyncio
|
||||||
async def test_no_send_when_disabled(self) -> None:
|
async def test_no_send_when_disabled(self) -> None:
|
||||||
"""Notifications not sent when client disabled."""
|
"""Notifications not sent when client disabled."""
|
||||||
|
|||||||
777
tests/test_telegram_commands.py
Normal file
777
tests/test_telegram_commands.py
Normal file
@@ -0,0 +1,777 @@
|
|||||||
|
"""Tests for Telegram command handler."""
|
||||||
|
|
||||||
|
from unittest.mock import AsyncMock, patch
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
from src.notifications.telegram_client import TelegramClient, TelegramCommandHandler
|
||||||
|
|
||||||
|
|
||||||
|
class TestCommandHandlerInit:
|
||||||
|
"""Test command handler initialization."""
|
||||||
|
|
||||||
|
def test_init_with_client(self) -> None:
|
||||||
|
"""Handler initializes with TelegramClient."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
assert handler._client is client
|
||||||
|
assert handler._polling_interval == 1.0
|
||||||
|
assert handler._commands == {}
|
||||||
|
assert handler._running is False
|
||||||
|
|
||||||
|
def test_custom_polling_interval(self) -> None:
|
||||||
|
"""Handler accepts custom polling interval."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client, polling_interval=2.5)
|
||||||
|
|
||||||
|
assert handler._polling_interval == 2.5
|
||||||
|
|
||||||
|
|
||||||
|
class TestCommandRegistration:
|
||||||
|
"""Test command registration."""
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_register_command(self) -> None:
|
||||||
|
"""Commands can be registered."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
async def test_handler() -> None:
|
||||||
|
pass
|
||||||
|
|
||||||
|
handler.register_command("test", test_handler)
|
||||||
|
|
||||||
|
assert "test" in handler._commands
|
||||||
|
assert handler._commands["test"] is test_handler
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_register_multiple_commands(self) -> None:
|
||||||
|
"""Multiple commands can be registered."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
async def handler1() -> None:
|
||||||
|
pass
|
||||||
|
|
||||||
|
async def handler2() -> None:
|
||||||
|
pass
|
||||||
|
|
||||||
|
handler.register_command("start", handler1)
|
||||||
|
handler.register_command("help", handler2)
|
||||||
|
|
||||||
|
assert len(handler._commands) == 2
|
||||||
|
assert handler._commands["start"] is handler1
|
||||||
|
assert handler._commands["help"] is handler2
|
||||||
|
|
||||||
|
|
||||||
|
class TestPollingLifecycle:
|
||||||
|
"""Test polling start/stop."""
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_start_polling(self) -> None:
|
||||||
|
"""Polling can be started."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
with patch.object(handler, "_poll_loop", new_callable=AsyncMock):
|
||||||
|
await handler.start_polling()
|
||||||
|
|
||||||
|
assert handler._running is True
|
||||||
|
assert handler._polling_task is not None
|
||||||
|
|
||||||
|
await handler.stop_polling()
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_start_polling_disabled_client(self) -> None:
|
||||||
|
"""Polling not started when client disabled."""
|
||||||
|
client = TelegramClient(enabled=False)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
await handler.start_polling()
|
||||||
|
|
||||||
|
assert handler._running is False
|
||||||
|
assert handler._polling_task is None
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_stop_polling(self) -> None:
|
||||||
|
"""Polling can be stopped."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
with patch.object(handler, "_poll_loop", new_callable=AsyncMock):
|
||||||
|
await handler.start_polling()
|
||||||
|
await handler.stop_polling()
|
||||||
|
|
||||||
|
assert handler._running is False
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_double_start_ignored(self) -> None:
|
||||||
|
"""Starting already running handler is ignored."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
with patch.object(handler, "_poll_loop", new_callable=AsyncMock):
|
||||||
|
await handler.start_polling()
|
||||||
|
task1 = handler._polling_task
|
||||||
|
|
||||||
|
await handler.start_polling() # Second start
|
||||||
|
task2 = handler._polling_task
|
||||||
|
|
||||||
|
# Should be the same task
|
||||||
|
assert task1 is task2
|
||||||
|
|
||||||
|
await handler.stop_polling()
|
||||||
|
|
||||||
|
|
||||||
|
class TestUpdateHandling:
|
||||||
|
"""Test update parsing and handling."""
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_handle_valid_command(self) -> None:
|
||||||
|
"""Valid commands are executed."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
executed = False
|
||||||
|
|
||||||
|
async def test_command() -> None:
|
||||||
|
nonlocal executed
|
||||||
|
executed = True
|
||||||
|
|
||||||
|
handler.register_command("test", test_command)
|
||||||
|
|
||||||
|
update = {
|
||||||
|
"update_id": 1,
|
||||||
|
"message": {
|
||||||
|
"chat": {"id": 456},
|
||||||
|
"text": "/test",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
await handler._handle_update(update)
|
||||||
|
assert executed is True
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_handle_unknown_command(self) -> None:
|
||||||
|
"""Unknown commands send help message."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp) as mock_post:
|
||||||
|
update = {
|
||||||
|
"update_id": 1,
|
||||||
|
"message": {
|
||||||
|
"chat": {"id": 456},
|
||||||
|
"text": "/unknown",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
await handler._handle_update(update)
|
||||||
|
|
||||||
|
# Should send error message
|
||||||
|
assert mock_post.call_count == 1
|
||||||
|
payload = mock_post.call_args.kwargs["json"]
|
||||||
|
assert "Unknown command" in payload["text"]
|
||||||
|
assert "/unknown" in payload["text"]
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_ignore_unauthorized_chat(self) -> None:
|
||||||
|
"""Commands from unauthorized chats are ignored."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
executed = False
|
||||||
|
|
||||||
|
async def test_command() -> None:
|
||||||
|
nonlocal executed
|
||||||
|
executed = True
|
||||||
|
|
||||||
|
handler.register_command("test", test_command)
|
||||||
|
|
||||||
|
update = {
|
||||||
|
"update_id": 1,
|
||||||
|
"message": {
|
||||||
|
"chat": {"id": 999}, # Wrong chat_id
|
||||||
|
"text": "/test",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
await handler._handle_update(update)
|
||||||
|
assert executed is False
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_ignore_non_command_text(self) -> None:
|
||||||
|
"""Non-command text is ignored."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
executed = False
|
||||||
|
|
||||||
|
async def test_command() -> None:
|
||||||
|
nonlocal executed
|
||||||
|
executed = True
|
||||||
|
|
||||||
|
handler.register_command("test", test_command)
|
||||||
|
|
||||||
|
update = {
|
||||||
|
"update_id": 1,
|
||||||
|
"message": {
|
||||||
|
"chat": {"id": 456},
|
||||||
|
"text": "Hello, not a command",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
await handler._handle_update(update)
|
||||||
|
assert executed is False
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_handle_command_with_botname(self) -> None:
|
||||||
|
"""Commands with @botname suffix are handled correctly."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
executed = False
|
||||||
|
|
||||||
|
async def test_command() -> None:
|
||||||
|
nonlocal executed
|
||||||
|
executed = True
|
||||||
|
|
||||||
|
handler.register_command("start", test_command)
|
||||||
|
|
||||||
|
update = {
|
||||||
|
"update_id": 1,
|
||||||
|
"message": {
|
||||||
|
"chat": {"id": 456},
|
||||||
|
"text": "/start@mybot",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
await handler._handle_update(update)
|
||||||
|
assert executed is True
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_handle_update_error_isolation(self) -> None:
|
||||||
|
"""Errors in handlers don't crash the system."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
async def failing_command() -> None:
|
||||||
|
raise ValueError("Test error")
|
||||||
|
|
||||||
|
handler.register_command("fail", failing_command)
|
||||||
|
|
||||||
|
update = {
|
||||||
|
"update_id": 1,
|
||||||
|
"message": {
|
||||||
|
"chat": {"id": 456},
|
||||||
|
"text": "/fail",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
# Should not raise exception
|
||||||
|
await handler._handle_update(update)
|
||||||
|
|
||||||
|
|
||||||
|
class TestTradingControlCommands:
|
||||||
|
"""Test trading control commands."""
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_stop_command_pauses_trading(self) -> None:
|
||||||
|
"""Stop command clears pause event."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
# Create mock pause event
|
||||||
|
import asyncio
|
||||||
|
|
||||||
|
pause_event = asyncio.Event()
|
||||||
|
pause_event.set() # Initially active
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
async def mock_stop() -> None:
|
||||||
|
"""Mock /stop handler."""
|
||||||
|
if not pause_event.is_set():
|
||||||
|
await client.send_message("⏸️ Trading is already paused")
|
||||||
|
return
|
||||||
|
|
||||||
|
pause_event.clear()
|
||||||
|
await client.send_message(
|
||||||
|
"<b>⏸️ Trading Paused</b>\n\n"
|
||||||
|
"All trading operations have been suspended.\n"
|
||||||
|
"Use /resume to restart trading."
|
||||||
|
)
|
||||||
|
|
||||||
|
handler.register_command("stop", mock_stop)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp) as mock_post:
|
||||||
|
update = {
|
||||||
|
"update_id": 1,
|
||||||
|
"message": {
|
||||||
|
"chat": {"id": 456},
|
||||||
|
"text": "/stop",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
await handler._handle_update(update)
|
||||||
|
|
||||||
|
# Verify pause event was cleared
|
||||||
|
assert not pause_event.is_set()
|
||||||
|
|
||||||
|
# Verify message was sent
|
||||||
|
assert mock_post.call_count == 1
|
||||||
|
payload = mock_post.call_args.kwargs["json"]
|
||||||
|
assert "Trading Paused" in payload["text"]
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_resume_command_resumes_trading(self) -> None:
|
||||||
|
"""Resume command sets pause event."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
# Create mock pause event (initially paused)
|
||||||
|
import asyncio
|
||||||
|
|
||||||
|
pause_event = asyncio.Event()
|
||||||
|
pause_event.clear() # Initially paused
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
async def mock_resume() -> None:
|
||||||
|
"""Mock /resume handler."""
|
||||||
|
if pause_event.is_set():
|
||||||
|
await client.send_message("▶️ Trading is already active")
|
||||||
|
return
|
||||||
|
|
||||||
|
pause_event.set()
|
||||||
|
await client.send_message(
|
||||||
|
"<b>▶️ Trading Resumed</b>\n\n"
|
||||||
|
"Trading operations have been restarted."
|
||||||
|
)
|
||||||
|
|
||||||
|
handler.register_command("resume", mock_resume)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp) as mock_post:
|
||||||
|
update = {
|
||||||
|
"update_id": 1,
|
||||||
|
"message": {
|
||||||
|
"chat": {"id": 456},
|
||||||
|
"text": "/resume",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
await handler._handle_update(update)
|
||||||
|
|
||||||
|
# Verify pause event was set
|
||||||
|
assert pause_event.is_set()
|
||||||
|
|
||||||
|
# Verify message was sent
|
||||||
|
assert mock_post.call_count == 1
|
||||||
|
payload = mock_post.call_args.kwargs["json"]
|
||||||
|
assert "Trading Resumed" in payload["text"]
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_stop_when_already_paused(self) -> None:
|
||||||
|
"""Stop command when already paused sends appropriate message."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
# Create mock pause event (already paused)
|
||||||
|
import asyncio
|
||||||
|
|
||||||
|
pause_event = asyncio.Event()
|
||||||
|
pause_event.clear()
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
async def mock_stop() -> None:
|
||||||
|
"""Mock /stop handler."""
|
||||||
|
if not pause_event.is_set():
|
||||||
|
await client.send_message("⏸️ Trading is already paused")
|
||||||
|
return
|
||||||
|
|
||||||
|
pause_event.clear()
|
||||||
|
|
||||||
|
handler.register_command("stop", mock_stop)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp) as mock_post:
|
||||||
|
update = {
|
||||||
|
"update_id": 1,
|
||||||
|
"message": {
|
||||||
|
"chat": {"id": 456},
|
||||||
|
"text": "/stop",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
await handler._handle_update(update)
|
||||||
|
|
||||||
|
# Verify message was sent
|
||||||
|
payload = mock_post.call_args.kwargs["json"]
|
||||||
|
assert "already paused" in payload["text"]
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_resume_when_already_active(self) -> None:
|
||||||
|
"""Resume command when already active sends appropriate message."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
# Create mock pause event (already active)
|
||||||
|
import asyncio
|
||||||
|
|
||||||
|
pause_event = asyncio.Event()
|
||||||
|
pause_event.set()
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
async def mock_resume() -> None:
|
||||||
|
"""Mock /resume handler."""
|
||||||
|
if pause_event.is_set():
|
||||||
|
await client.send_message("▶️ Trading is already active")
|
||||||
|
return
|
||||||
|
|
||||||
|
pause_event.set()
|
||||||
|
|
||||||
|
handler.register_command("resume", mock_resume)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp) as mock_post:
|
||||||
|
update = {
|
||||||
|
"update_id": 1,
|
||||||
|
"message": {
|
||||||
|
"chat": {"id": 456},
|
||||||
|
"text": "/resume",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
await handler._handle_update(update)
|
||||||
|
|
||||||
|
# Verify message was sent
|
||||||
|
payload = mock_post.call_args.kwargs["json"]
|
||||||
|
assert "already active" in payload["text"]
|
||||||
|
|
||||||
|
|
||||||
|
class TestStatusCommands:
|
||||||
|
"""Test status query commands."""
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_status_command_shows_trading_info(self) -> None:
|
||||||
|
"""Status command displays mode, markets, and P&L."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
async def mock_status() -> None:
|
||||||
|
"""Mock /status handler."""
|
||||||
|
message = (
|
||||||
|
"<b>📊 Trading Status</b>\n\n"
|
||||||
|
"<b>Mode:</b> PAPER\n"
|
||||||
|
"<b>Markets:</b> Korea, United States\n"
|
||||||
|
"<b>Trading:</b> Active\n\n"
|
||||||
|
"<b>Current P&L:</b> +2.50%\n"
|
||||||
|
"<b>Circuit Breaker:</b> -3.0%"
|
||||||
|
)
|
||||||
|
await client.send_message(message)
|
||||||
|
|
||||||
|
handler.register_command("status", mock_status)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp) as mock_post:
|
||||||
|
update = {
|
||||||
|
"update_id": 1,
|
||||||
|
"message": {
|
||||||
|
"chat": {"id": 456},
|
||||||
|
"text": "/status",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
await handler._handle_update(update)
|
||||||
|
|
||||||
|
# Verify message was sent
|
||||||
|
assert mock_post.call_count == 1
|
||||||
|
payload = mock_post.call_args.kwargs["json"]
|
||||||
|
assert "Trading Status" in payload["text"]
|
||||||
|
assert "PAPER" in payload["text"]
|
||||||
|
assert "P&L" in payload["text"]
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_status_command_error_handling(self) -> None:
|
||||||
|
"""Status command handles errors gracefully."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
async def mock_status_error() -> None:
|
||||||
|
"""Mock /status handler with error."""
|
||||||
|
await client.send_message(
|
||||||
|
"<b>⚠️ Error</b>\n\nFailed to retrieve trading status."
|
||||||
|
)
|
||||||
|
|
||||||
|
handler.register_command("status", mock_status_error)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp) as mock_post:
|
||||||
|
update = {
|
||||||
|
"update_id": 1,
|
||||||
|
"message": {
|
||||||
|
"chat": {"id": 456},
|
||||||
|
"text": "/status",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
await handler._handle_update(update)
|
||||||
|
|
||||||
|
# Should send error message
|
||||||
|
payload = mock_post.call_args.kwargs["json"]
|
||||||
|
assert "Error" in payload["text"]
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_positions_command_shows_holdings(self) -> None:
|
||||||
|
"""Positions command displays account summary."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
async def mock_positions() -> None:
|
||||||
|
"""Mock /positions handler."""
|
||||||
|
message = (
|
||||||
|
"<b>💼 Account Summary</b>\n\n"
|
||||||
|
"<b>Total Evaluation:</b> ₩10,500,000\n"
|
||||||
|
"<b>Available Cash:</b> ₩5,000,000\n"
|
||||||
|
"<b>Purchase Total:</b> ₩10,000,000\n"
|
||||||
|
"<b>P&L:</b> +5.00%\n\n"
|
||||||
|
"<i>Note: Individual position details require API enhancement</i>"
|
||||||
|
)
|
||||||
|
await client.send_message(message)
|
||||||
|
|
||||||
|
handler.register_command("positions", mock_positions)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp) as mock_post:
|
||||||
|
update = {
|
||||||
|
"update_id": 1,
|
||||||
|
"message": {
|
||||||
|
"chat": {"id": 456},
|
||||||
|
"text": "/positions",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
await handler._handle_update(update)
|
||||||
|
|
||||||
|
# Verify message was sent
|
||||||
|
assert mock_post.call_count == 1
|
||||||
|
payload = mock_post.call_args.kwargs["json"]
|
||||||
|
assert "Account Summary" in payload["text"]
|
||||||
|
assert "Total Evaluation" in payload["text"]
|
||||||
|
assert "P&L" in payload["text"]
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_positions_command_empty_holdings(self) -> None:
|
||||||
|
"""Positions command handles empty portfolio."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
async def mock_positions_empty() -> None:
|
||||||
|
"""Mock /positions handler with no positions."""
|
||||||
|
message = (
|
||||||
|
"<b>💼 Account Summary</b>\n\n"
|
||||||
|
"No balance information available."
|
||||||
|
)
|
||||||
|
await client.send_message(message)
|
||||||
|
|
||||||
|
handler.register_command("positions", mock_positions_empty)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp) as mock_post:
|
||||||
|
update = {
|
||||||
|
"update_id": 1,
|
||||||
|
"message": {
|
||||||
|
"chat": {"id": 456},
|
||||||
|
"text": "/positions",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
await handler._handle_update(update)
|
||||||
|
|
||||||
|
# Verify message was sent
|
||||||
|
payload = mock_post.call_args.kwargs["json"]
|
||||||
|
assert "No balance information available" in payload["text"]
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_positions_command_error_handling(self) -> None:
|
||||||
|
"""Positions command handles errors gracefully."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
async def mock_positions_error() -> None:
|
||||||
|
"""Mock /positions handler with error."""
|
||||||
|
await client.send_message(
|
||||||
|
"<b>⚠️ Error</b>\n\nFailed to retrieve positions."
|
||||||
|
)
|
||||||
|
|
||||||
|
handler.register_command("positions", mock_positions_error)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp) as mock_post:
|
||||||
|
update = {
|
||||||
|
"update_id": 1,
|
||||||
|
"message": {
|
||||||
|
"chat": {"id": 456},
|
||||||
|
"text": "/positions",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
await handler._handle_update(update)
|
||||||
|
|
||||||
|
# Should send error message
|
||||||
|
payload = mock_post.call_args.kwargs["json"]
|
||||||
|
assert "Error" in payload["text"]
|
||||||
|
|
||||||
|
|
||||||
|
class TestBasicCommands:
|
||||||
|
"""Test basic command implementations."""
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_help_command_content(self) -> None:
|
||||||
|
"""Help command lists all available commands."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
async def mock_help() -> None:
|
||||||
|
"""Mock /help handler."""
|
||||||
|
message = (
|
||||||
|
"<b>📖 Available Commands</b>\n\n"
|
||||||
|
"/help - Show available commands\n"
|
||||||
|
"/status - Trading status (mode, markets, P&L)\n"
|
||||||
|
"/positions - Current holdings\n"
|
||||||
|
"/stop - Pause trading\n"
|
||||||
|
"/resume - Resume trading"
|
||||||
|
)
|
||||||
|
await client.send_message(message)
|
||||||
|
|
||||||
|
handler.register_command("help", mock_help)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp) as mock_post:
|
||||||
|
update = {
|
||||||
|
"update_id": 1,
|
||||||
|
"message": {
|
||||||
|
"chat": {"id": 456},
|
||||||
|
"text": "/help",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
await handler._handle_update(update)
|
||||||
|
|
||||||
|
# Verify message was sent
|
||||||
|
assert mock_post.call_count == 1
|
||||||
|
payload = mock_post.call_args.kwargs["json"]
|
||||||
|
assert "Available Commands" in payload["text"]
|
||||||
|
assert "/help" in payload["text"]
|
||||||
|
assert "/status" in payload["text"]
|
||||||
|
assert "/positions" in payload["text"]
|
||||||
|
assert "/stop" in payload["text"]
|
||||||
|
assert "/resume" in payload["text"]
|
||||||
|
|
||||||
|
|
||||||
|
class TestGetUpdates:
|
||||||
|
"""Test getUpdates API interaction."""
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_get_updates_success(self) -> None:
|
||||||
|
"""getUpdates fetches and parses updates."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.json = AsyncMock(
|
||||||
|
return_value={
|
||||||
|
"ok": True,
|
||||||
|
"result": [
|
||||||
|
{"update_id": 1, "message": {"text": "/test"}},
|
||||||
|
{"update_id": 2, "message": {"text": "/help"}},
|
||||||
|
],
|
||||||
|
}
|
||||||
|
)
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp):
|
||||||
|
updates = await handler._get_updates()
|
||||||
|
|
||||||
|
assert len(updates) == 2
|
||||||
|
assert updates[0]["update_id"] == 1
|
||||||
|
assert updates[1]["update_id"] == 2
|
||||||
|
assert handler._last_update_id == 2
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_get_updates_api_error(self) -> None:
|
||||||
|
"""getUpdates handles API errors gracefully."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 400
|
||||||
|
mock_resp.text = AsyncMock(return_value="Bad Request")
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp):
|
||||||
|
updates = await handler._get_updates()
|
||||||
|
|
||||||
|
assert updates == []
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_get_updates_empty_result(self) -> None:
|
||||||
|
"""getUpdates handles empty results."""
|
||||||
|
client = TelegramClient(bot_token="123:abc", chat_id="456", enabled=True)
|
||||||
|
handler = TelegramCommandHandler(client)
|
||||||
|
|
||||||
|
mock_resp = AsyncMock()
|
||||||
|
mock_resp.status = 200
|
||||||
|
mock_resp.json = AsyncMock(return_value={"ok": True, "result": []})
|
||||||
|
mock_resp.__aenter__ = AsyncMock(return_value=mock_resp)
|
||||||
|
mock_resp.__aexit__ = AsyncMock(return_value=False)
|
||||||
|
|
||||||
|
with patch("aiohttp.ClientSession.post", return_value=mock_resp):
|
||||||
|
updates = await handler._get_updates()
|
||||||
|
|
||||||
|
assert updates == []
|
||||||
@@ -2,6 +2,7 @@
|
|||||||
|
|
||||||
from __future__ import annotations
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import asyncio
|
||||||
import sqlite3
|
import sqlite3
|
||||||
from typing import Any
|
from typing import Any
|
||||||
from unittest.mock import AsyncMock
|
from unittest.mock import AsyncMock
|
||||||
@@ -338,6 +339,28 @@ class TestMarketScanner:
|
|||||||
assert metrics.stock_code == "AAPL"
|
assert metrics.stock_code == "AAPL"
|
||||||
assert metrics.current_price == 150.50
|
assert metrics.current_price == 150.50
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_scan_stock_overseas_empty_price(
|
||||||
|
self,
|
||||||
|
scanner: MarketScanner,
|
||||||
|
mock_overseas_broker: OverseasBroker,
|
||||||
|
context_store: ContextStore,
|
||||||
|
) -> None:
|
||||||
|
"""Test scanning overseas stock with empty price string (issue #49)."""
|
||||||
|
mock_overseas_broker.get_overseas_price.return_value = {
|
||||||
|
"output": {
|
||||||
|
"last": "", # Empty string
|
||||||
|
"tvol": "", # Empty string
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
market = MARKETS["US_NASDAQ"]
|
||||||
|
metrics = await scanner.scan_stock("AAPL", market)
|
||||||
|
|
||||||
|
assert metrics is not None
|
||||||
|
assert metrics.stock_code == "AAPL"
|
||||||
|
assert metrics.current_price == 0.0 # Should default to 0.0
|
||||||
|
|
||||||
@pytest.mark.asyncio
|
@pytest.mark.asyncio
|
||||||
async def test_scan_stock_error_handling(
|
async def test_scan_stock_error_handling(
|
||||||
self,
|
self,
|
||||||
@@ -509,3 +532,45 @@ class TestMarketScanner:
|
|||||||
new_additions = [code for code in updated if code not in current_watchlist]
|
new_additions = [code for code in updated if code not in current_watchlist]
|
||||||
assert len(new_additions) <= 1
|
assert len(new_additions) <= 1
|
||||||
assert len(updated) == len(current_watchlist)
|
assert len(updated) == len(current_watchlist)
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_scan_market_respects_concurrency_limit(
|
||||||
|
self,
|
||||||
|
mock_broker: KISBroker,
|
||||||
|
mock_overseas_broker: OverseasBroker,
|
||||||
|
volatility_analyzer: VolatilityAnalyzer,
|
||||||
|
context_store: ContextStore,
|
||||||
|
) -> None:
|
||||||
|
"""scan_market should limit concurrent scans to max_concurrent_scans."""
|
||||||
|
max_concurrent = 2
|
||||||
|
scanner = MarketScanner(
|
||||||
|
broker=mock_broker,
|
||||||
|
overseas_broker=mock_overseas_broker,
|
||||||
|
volatility_analyzer=volatility_analyzer,
|
||||||
|
context_store=context_store,
|
||||||
|
top_n=5,
|
||||||
|
max_concurrent_scans=max_concurrent,
|
||||||
|
)
|
||||||
|
|
||||||
|
# Track peak concurrency
|
||||||
|
active_count = 0
|
||||||
|
peak_count = 0
|
||||||
|
|
||||||
|
original_scan = scanner.scan_stock
|
||||||
|
|
||||||
|
async def tracking_scan(code: str, market: Any) -> VolatilityMetrics:
|
||||||
|
nonlocal active_count, peak_count
|
||||||
|
active_count += 1
|
||||||
|
peak_count = max(peak_count, active_count)
|
||||||
|
await asyncio.sleep(0.05) # Simulate API call duration
|
||||||
|
active_count -= 1
|
||||||
|
return VolatilityMetrics(code, 50000, 500, 1.0, 1.0, 1.0, 1.0, 10.0, 50.0)
|
||||||
|
|
||||||
|
scanner.scan_stock = tracking_scan # type: ignore[method-assign]
|
||||||
|
|
||||||
|
market = MARKETS["KR"]
|
||||||
|
stock_codes = ["001", "002", "003", "004", "005", "006"]
|
||||||
|
|
||||||
|
await scanner.scan_market(market, stock_codes)
|
||||||
|
|
||||||
|
assert peak_count <= max_concurrent
|
||||||
|
|||||||
Reference in New Issue
Block a user