feat: explicit session_id propagation in logs (#326) #336

agentson · 2026-02-28T14:37:41+09:00

agentson commented

2026-02-28 14:37:41 +09:00

Summary

Add session_id column/migration for decision_logs
Extend DecisionLogger.log_decision to accept/store session_id
Pass runtime session_id explicitly in main.py decision/trade logging paths
Add/adjust tests for decision logger and DB migration behavior

Validation

pytest -q tests/test_db.py tests/test_decision_logger.py tests/test_main.py -k "decision_logger or session_id or context_snapshot_includes_scenario_match"

## Summary - Add `session_id` column/migration for `decision_logs` - Extend `DecisionLogger.log_decision` to accept/store session_id - Pass runtime session_id explicitly in `main.py` decision/trade logging paths - Add/adjust tests for decision logger and DB migration behavior ## Validation - pytest -q tests/test_db.py tests/test_decision_logger.py tests/test_main.py -k "decision_logger or session_id or context_snapshot_includes_scenario_match"

agentson added 1 commit 2026-02-28 14:37:41 +09:00

feat: propagate runtime session_id across decision and trade logs (#326 )

Gitea CI / test (push) Waiting to run

Details

Gitea CI / test (pull_request) Waiting to run

Details

11b9ad126f

agentson commented

2026-02-28 16:12:00 +09:00

Ticket Maturity Update (2026-02-28)

Implemented: done
Integrated: done
Observed: done (targeted test commands executed and passing)
Accepted: pending (reviewer + runtime verifier approval required)

Coverage Matrix:

Stage	Status
Implemented	PASS
Integrated	PASS
Observed	PASS
Accepted	NOT_OBSERVED

## Ticket Maturity Update (2026-02-28) - Implemented: done - Integrated: done - Observed: done (targeted test commands executed and passing) - Accepted: pending (reviewer + runtime verifier approval required) Coverage Matrix: | Stage | Status | | --- | --- | | Implemented | PASS | | Integrated | PASS | | Observed | PASS | | Accepted | NOT_OBSERVED |

agentson reviewed 2026-02-28 16:15:23 +09:00

agentson left a comment

Review: PR #336 — feat: explicit session_id propagation in logs (#326)

플랜 일치: ✅ ACT-09 정확히 일치

log_decision()에 session_id 파라미터 추가
log_trade() 호출 시 런타임 session_id 명시적 전달
DecisionLog dataclass에 session_id 필드 추가

코드 품질: ✅ 우수

DB 마이그레이션: ALTER TABLE + 기존 데이터 UNKNOWN 백필 — 올바른 마이그레이션
session_id 기본값: session_id or "UNKNOWN" — NULL 방어
SELECT 쿼리 순서 일관성: 모든 SELECT에서 session_id 위치 통일 (exchange_code 다음)
main.py 반영: 실시간(trading_cycle) + 일간(run_daily_session) + sync_positions 3곳 모두 session_id 전달
outcome_pnl/outcome_accuracy/reviewed/review_notes 마이그레이션: decision_logs 테이블의 누락 컬럼도 함께 마이그레이션 — bonus 수정

테스트: ✅ 충분

decision_logs session_id 마이그레이션 백필 테스트
log_decision 기본값(UNKNOWN) 테스트
log_decision 명시적 session_id 테스트
DecisionLog dataclass session_id 필드 테스트

결론: LGTM ✅

## Review: PR #336 — feat: explicit session_id propagation in logs (#326) ### 플랜 일치: ✅ ACT-09 정확히 일치 - `log_decision()`에 session_id 파라미터 추가 - `log_trade()` 호출 시 런타임 session_id 명시적 전달 - DecisionLog dataclass에 session_id 필드 추가 ### 코드 품질: ✅ 우수 - **DB 마이그레이션**: `ALTER TABLE` + 기존 데이터 UNKNOWN 백필 — 올바른 마이그레이션 - **session_id 기본값**: `session_id or "UNKNOWN"` — NULL 방어 - **SELECT 쿼리 순서 일관성**: 모든 SELECT에서 session_id 위치 통일 (exchange_code 다음) - **main.py 반영**: 실시간(trading_cycle) + 일간(run_daily_session) + sync_positions 3곳 모두 session_id 전달 - **outcome_pnl/outcome_accuracy/reviewed/review_notes 마이그레이션**: decision_logs 테이블의 누락 컬럼도 함께 마이그레이션 — bonus 수정 ### 테스트: ✅ 충분 - decision_logs session_id 마이그레이션 백필 테스트 - log_decision 기본값(UNKNOWN) 테스트 - log_decision 명시적 session_id 테스트 - DecisionLog dataclass session_id 필드 테스트 ### 결론: **LGTM** ✅

jihoson merged commit ea7260d574 into feature/v3-session-policy-stream

2026-02-28 17:07:34 +09:00

jihoson deleted branch feature/issue-326-session-id-explicit-propagation

2026-02-28 17:07:34 +09:00

jihoson referenced this issue from a commit

2026-02-28 17:07:36 +09:00

Merge pull request 'feat: explicit session_id propagation in logs (#326)' (#336) from feature/issue-326-session-id-explicit-propagation into feature/v3-session-policy-stream

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: jihoson/The-Ouroboros#336