jihoson/The-Ouroboros
1
0
Fork 0
Code Issues 14 Pull Requests 1 Actions 47 Packages Projects Releases Wiki Activity

feat: minute-based triple barrier horizon (#329) #334

Merged
jihoson merged 1 commits from feature/issue-329-triple-barrier-minutes into feature/v3-session-policy-stream 2026-02-28 17:06:32 +09:00
Conversation 1 Commits 1 Files Changed 2 +89 -8
agentson commented 2026-02-28 14:35:59 +09:00
Collaborator
Copy Link

Summary

  • Add max_holding_minutes support to triple barrier labeling with timestamp-based expiry
  • Keep max_holding_bars for backward compatibility with deprecation warning
  • Add tests for minute-based behavior and deprecation path

Validation

  • pytest -q tests/test_triple_barrier.py
## Summary - Add `max_holding_minutes` support to triple barrier labeling with timestamp-based expiry - Keep `max_holding_bars` for backward compatibility with deprecation warning - Add tests for minute-based behavior and deprecation path ## Validation - pytest -q tests/test_triple_barrier.py
agentson added 1 commit 2026-02-28 14:36:00 +09:00
feat: support minute-based triple barrier horizon (#329)
Some checks are pending
Gitea CI / test (push) Waiting to run
Details
Gitea CI / test (pull_request) Waiting to run
Details
c641097fe7
agentson commented 2026-02-28 16:11:59 +09:00
Author
Collaborator
Copy Link

Ticket Maturity Update (2026-02-28)

  • Implemented: done
  • Integrated: done
  • Observed: done (targeted test commands executed and passing)
  • Accepted: pending (reviewer + runtime verifier approval required)

Coverage Matrix:

Stage Status
Implemented PASS
Integrated PASS
Observed PASS
Accepted NOT_OBSERVED
## Ticket Maturity Update (2026-02-28) - Implemented: done - Integrated: done - Observed: done (targeted test commands executed and passing) - Accepted: pending (reviewer + runtime verifier approval required) Coverage Matrix: | Stage | Status | | --- | --- | | Implemented | PASS | | Integrated | PASS | | Observed | PASS | | Accepted | NOT_OBSERVED |
agentson reviewed 2026-02-28 16:15:00 +09:00
agentson left a comment
Author
Collaborator
Copy Link

Review: PR #334 — feat: minute-based triple barrier horizon (#329)

플랜 일치: ✅ ACT-12 정확히 일치

  • max_holding_minutes 지원 추가, max_holding_bars deprecated 경고, 하위 호환 유지

코드 품질: ✅ 우수

  • __post_init__ 검증: 둘 중 하나 필수, 양수 값 강제 — 올바른 invariant 보호
  • timestamps 의존성: max_holding_minutes 사용 시 timestamps 필수 + 명확한 에러
  • DeprecationWarning: stacklevel=2 — 표준 패턴
  • 변수명 개선: h/l → high_price/low_price

테스트: ✅ 충분

  • 1분봉/5분봉 다른 샘플링에서 시간장벽 일관성 테스트
  • bars 모드 deprecation 경고 테스트

결론: LGTM ✅

## Review: PR #334 — feat: minute-based triple barrier horizon (#329) ### 플랜 일치: ✅ ACT-12 정확히 일치 - `max_holding_minutes` 지원 추가, `max_holding_bars` deprecated 경고, 하위 호환 유지 ### 코드 품질: ✅ 우수 - `__post_init__` 검증: 둘 중 하나 필수, 양수 값 강제 — 올바른 invariant 보호 - timestamps 의존성: `max_holding_minutes` 사용 시 `timestamps` 필수 + 명확한 에러 - DeprecationWarning: `stacklevel=2` — 표준 패턴 - 변수명 개선: `h/l` → `high_price/low_price` ### 테스트: ✅ 충분 - 1분봉/5분봉 다른 샘플링에서 시간장벽 일관성 테스트 - bars 모드 deprecation 경고 테스트 ### 결론: **LGTM** ✅
jihoson merged commit a2855e286e into feature/v3-session-policy-stream 2026-02-28 17:06:32 +09:00
jihoson deleted branch feature/issue-329-triple-barrier-minutes 2026-02-28 17:06:32 +09:00
Sign in to join this conversation.
Reviewers
No Reviewers
agentson
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agentson jihoson
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jihoson/The-Ouroboros#334
Delete Branch "feature/issue-329-triple-barrier-minutes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?